Page MenuHomePhabricator

Fix feed query cursor-based pagination on 32-bit systems
ClosedPublic

Authored by epriestley on Jun 11 2015, 4:45 PM.

Details

Summary

Fixes T8503. On 32-bit systems, these 64-bit integers will be mangled by the '%d' conversion implied by the 'int' type.

Test Plan

Somewhat guessing here since I don't have a 32-bit system handy, but this strongly echoes similar issues in the past. Feed works fine locally. Looked at the generated queries.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix feed query cursor-based pagination on 32-bit systems.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 11 2015, 5:22 PM
This revision was automatically updated to reflect the committed changes.