Page MenuHomePhabricator

Fix a fatal in Calendar widget in Conpherence
ClosedPublic

Authored by epriestley on Jun 15 2015, 2:54 PM.
Tags
None
Referenced Files
F14054797: D13299.diff
Sat, Nov 16, 5:03 AM
F14042203: D13299.diff
Tue, Nov 12, 1:20 AM
F14026763: D13299.diff
Fri, Nov 8, 2:05 AM
F13991023: D13299.diff
Tue, Oct 22, 8:11 AM
F13976898: D13299.id32168.diff
Oct 18 2024, 4:12 PM
F13975043: D13299.id32178.diff
Oct 18 2024, 8:27 AM
Unknown Object (File)
Oct 3 2024, 9:21 PM
Unknown Object (File)
Sep 11 2024, 6:51 AM
Subscribers

Details

Summary

Fixes T8548. This needs to be cleaned up more generally at some point, but stop the bleeding for now.

If a thread member is invited to an event with a non-thread-member host, we try to render the host but don't have their handle (this is a holdover from the bygone days of events as statuses).

For now, just don't render anything. In the future, it might be nice to render (some of?) the attendees who are thread members, but I suspect we may revisit this widget more generally.

Test Plan
  • As a non thread-member, created an event and invited a thread member.
  • Viewed thread as thread-member.
  • Saw widget fatal.
  • Applied patch.
  • As thread-member, saw widget render with just "9AM-10AM", instead of "host, 9AM-10AM".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix a fatal in Calendar widget in Conpherence.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 15 2015, 6:49 PM
This revision was automatically updated to reflect the committed changes.