Page MenuHomePhabricator
Differential D13058

Conpherence - massage email notification to have proper link to how to update email settings
ClosedPublic
Actions

Authored by btrahan on May 28 2015, 10:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 8:22 AM
Unknown Object (File)
Thu, Dec 12, 5:53 AM
Unknown Object (File)
Sun, Dec 8, 9:38 AM
Unknown Object (File)
Fri, Dec 6, 9:46 AM
Unknown Object (File)
Tue, Dec 3, 7:24 PM
Unknown Object (File)
Tue, Dec 3, 5:43 AM
Unknown Object (File)
Sat, Nov 30, 1:14 PM
Unknown Object (File)
Fri, Nov 29, 7:02 AM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Piece of Eight" token, awarded by chad.

Details

Reviewers
epriestley
Maniphest Tasks
T8329: Email settings link for conpherence emails should be savvier
Commits
Restricted Diffusion Commit
rPc7de17663a9d: Conpherence - massage email notification to have proper link to how to update…
Summary

Fixes T8329. I was able to figure out a reasonable way to have the full conpherence default to the email settings panel. I think this is cleaner than making things a dialogue as I rambled about in the description for T8329.

Test Plan

using /bin/mail to verify correct email links were generated for conpherence notifications and maniphest (general) notifications.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 31506.May 28 2015, 10:08 PM
btrahan added a task: T8329: Email settings link for conpherence emails should be savvier.
btrahan retitled this revision from to Conpherence - massage email notification to have proper link to how to update email settings.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 28 2015, 10:08 PM
epriestley accepted this revision.May 28 2015, 10:18 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 28 2015, 10:18 PM
chad awarded a token.May 28 2015, 10:18 PM
Closed by commit rPc7de17663a9d: Conpherence - massage email notification to have proper link to how to update… (authored by btrahan, committed by btrahan). · Explain WhyMay 28 2015, 10:30 PM
This revision was automatically updated to reflect the committed changes.
btrahan mentioned this in D13228: Conpherence - fix default widget on main Conpherence view..Jun 9 2015, 8:46 PM
btrahan mentioned this in T8489: conpherence widget column defaults to Settings instead of Participants.Jun 9 2015, 8:47 PM
btrahan mentioned this in rP0fab38e0229d: Conpherence - fix default widget on main Conpherence view..Jun 9 2015, 8:48 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
32 lines
src/
applications/
conpherence/
editor/
15 lines
metamta/
view/
20 lines
transactions/
editor/
22 lines
webroot/
rsrc/
js/
application/
conpherence/
5 lines

Diff 31512

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/conpherence/editor/ConpherenceEditor.php

Loading...
View Options

src/applications/metamta/view/PhabricatorMetaMTAMailBody.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
View Options

webroot/rsrc/js/application/conpherence/behavior-menu.js

Loading...
Phabricator · Built by Phacility