Paths

Table of Contentst

Differential D13227

Make "Order By" field render correctly when showing a SavedQuery with an order alias
ClosedPublic
Actions

Authored by epriestley on Jun 9 2015, 8:46 PM.

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rPbdef1255e398: Make "Order By" field render correctly when showing a SavedQuery with an…

Summary

If you have a saved query with an order alias, we currently apply the order correctly but don't show the right value in the UI.

Map any saved value to the canoncial value when rendering the control.

Test Plan

Added some var_dump() and verified order key was getting mapped forward correctly.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 31971.Jun 9 2015, 8:46 PM

epriestley retitled this revision from to Make "Order By" field render correctly when showing a SavedQuery with an order alias.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 9 2015, 8:46 PM

btrahan accepted this revision.Jun 9 2015, 8:48 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 9 2015, 8:48 PM

Closed by commit rPbdef1255e398: Make "Order By" field render correctly when showing a SavedQuery with an… (authored by epriestley, committed by epriestley). · Explain WhyJun 9 2015, 8:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

engine/

PhabricatorApplicationSearchEngine.php

1 line

field/

PhabricatorSearchOrderField.php

20 lines

Diff 31974

View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php