Page MenuHomePhabricator

Use ApplicationTransactions in ApplicationEmail
ClosedPublic

Authored by epriestley on Jun 11 2015, 2:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 1:13 AM
Unknown Object (File)
Fri, Dec 6, 1:49 PM
Unknown Object (File)
Thu, Dec 5, 11:56 PM
Unknown Object (File)
Thu, Dec 5, 12:12 AM
Unknown Object (File)
Mon, Dec 2, 9:28 PM
Unknown Object (File)
Sun, Dec 1, 8:11 AM
Unknown Object (File)
Sat, Nov 30, 3:57 AM
Unknown Object (File)
Mon, Nov 25, 3:52 AM
Subscribers

Details

Summary

Ref T8498. I want to add Spaces to these, and the logic for getting Spaces right is a bit tricky, so swap these to ApplicationTransactions.

One new piece of tech: made it easier for Editors to raise DuplicateKeyException as a normal ValidationException, so callers don't have to handle this case specially.

One behavioral change: we no longer require these addresses to be at the auth.email-domains domains -- I think this wasn't quite right in the general case. It's OK to require users to have @mycompany.com addresses but add @phabricator.mycompany-infrastructure.com addresses here if you want.

Test Plan
  • Tried to create a duplicate email.
  • Tried to create an empty email.
  • Tried to create an invalid email.
  • Created a new email.
  • Deleted an email.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Use ApplicationTransactions in ApplicationEmail.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

One new piece of tech: made it easier for Editors to raise DuplicateKeyException as a normal ValidationException, so callers don't have to handle this case specially.

<3

This revision is now accepted and ready to land.Jun 11 2015, 5:11 PM
This revision was automatically updated to reflect the committed changes.