Page MenuHomePhabricator

Allow Spaces to be archived
ClosedPublic

Authored by epriestley on Jun 10 2015, 7:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 12 2024, 9:02 PM
Unknown Object (File)
Feb 12 2024, 4:52 PM
Unknown Object (File)
Feb 12 2024, 4:36 PM
Unknown Object (File)
Feb 12 2024, 4:25 PM
Unknown Object (File)
Jan 30 2024, 8:02 PM
Unknown Object (File)
Jan 30 2024, 6:06 PM
Unknown Object (File)
Jan 26 2024, 4:36 PM
Unknown Object (File)
Jan 24 2024, 2:26 PM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
T8377: Build the core "Spaces" Application
Commits
Restricted Diffusion Commit
rP88e7cd158f28: Allow Spaces to be archived
Summary

Ref T8377. This adds a standard disable/enable feature to Spaces, with a couple of twists:

  • You can't create new stuff in an archived space, and you can't move stuff into an archived space.
  • We don't show results from an archived space by default in ApplicationSearch queries. You can still find these objects if you explicitly search for "Spaces: <the archived space>".

So this is a "put it in a box in the attic" sort of operation, but that seems fairly nice/reasonable.

Test Plan
  • Archived and activated spaces.
  • Used ApplicationSearch, which omitted archived objects by default but allowed searches for them, specifically, to succeed.
  • Tried to create objects into an archived space (this is not allowed).
  • Edited objects in an archived space (this is OK).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow Spaces to be archived.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/spaces/application/PhabricatorSpacesApplication.php
41–48

nice, docs

src/applications/spaces/editor/PhabricatorSpacesNamespaceEditor.php
154–155

I can't remember the create UI but I think surfacing this forever default thing there sounds groovy

This revision is now accepted and ready to land.Jun 11 2015, 5:00 PM
src/applications/spaces/editor/PhabricatorSpacesNamespaceEditor.php
154–155

I'll take another look at the message once things settle down a bit more, the default space doesn't really do anything right now (except "contain all existing objects when first created") so we might be able to just kind of get rid of the idea as a formal thing that users need to worry about.

This revision was automatically updated to reflect the committed changes.