Page MenuHomePhabricator
Differential D13194

Convert Macro to SearchFields
ClosedPublic
Actions

Authored by epriestley on Jun 7 2015, 7:33 PM.
Tags
None
Referenced Files
F17858540: D13194.id.diff
Sun, Jul 27, 7:43 PM
F17827773: D13194.diff
Sat, Jul 26, 8:31 AM
F17712929: D13194.id31934.diff
Thu, Jul 17, 11:47 AM
F17625373: D13194.diff
Thu, Jul 10, 3:13 AM
Unknown Object (File)
Jun 20 2025, 7:36 AM
Unknown Object (File)
May 25 2025, 7:33 PM
Unknown Object (File)
May 20 2025, 7:18 PM
Unknown Object (File)
May 19 2025, 7:21 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch
T8441: Integrate Spaces into ApplicationSearch
Commits
Restricted Diffusion Commit
rP1de0ba58c146: Convert Macro to SearchFields
Summary

Ref T8441. Ref T7715. I'm primarily clearing callers to saveQueryOrder() so I can get rid of it.

Test Plan

Used all Macro search features.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 31884.Jun 7 2015, 7:33 PM
epriestley retitled this revision from to Convert Macro to SearchFields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T8441: Integrate Spaces into ApplicationSearch, T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 7 2015, 7:33 PM
btrahan accepted this revision.Jun 8 2015, 6:39 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 8 2015, 6:39 PM
Closed by commit rP1de0ba58c146: Convert Macro to SearchFields (authored by epriestley, committed by epriestley). · Explain WhyJun 8 2015, 7:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
macro/
query/
43 lines
161 lines
search/
field/
8 lines

Diff 31934

View Options

src/applications/macro/query/PhabricatorMacroQuery.php

Loading...
View Options

src/applications/macro/query/PhabricatorMacroSearchEngine.php

Loading...
View Options

src/applications/search/field/PhabricatorSearchSelectField.php

Loading...
Phabricator · Built by Phacility