Page MenuHomePhabricator

Don't require users be activated in order to establish Web sessions
ClosedPublic

Authored by epriestley on Jun 10 2015, 8:24 PM.
Tags
None
Referenced Files
F19056658: D13239.diff
Fri, Nov 28, 8:16 PM
F18929565: D13239.diff
Nov 10 2025, 12:17 AM
F18906242: D13239.id.diff
Nov 8 2025, 5:38 PM
F18904010: D13239.id32008.diff
Nov 8 2025, 7:21 AM
F18857133: D13239.id.diff
Nov 1 2025, 1:27 PM
F18841172: D13239.diff
Oct 28 2025, 7:31 AM
F18835894: D13239.diff
Oct 26 2025, 7:48 PM
F18805855: D13239.id31999.diff
Oct 18 2025, 4:48 PM

Details

Summary

Ref T8496. In D13123, the condition for establishing a web session was made too strict: we need to let non-activated users establish web sessions in order to see "you are a bad disabled person" or "your account needs approval" messages. The previous behavior let them in, the new behavior incorrectly locks them out.

Test Plan

Enabled login approvals and registered a new account with username/password auth.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable