Page MenuHomePhabricator

Don't require users be activated in order to establish Web sessions
ClosedPublic

Authored by epriestley on Jun 10 2015, 8:24 PM.
Tags
None
Referenced Files
F18835894: D13239.diff
Sun, Oct 26, 7:48 PM
F18805855: D13239.id31999.diff
Sat, Oct 18, 4:48 PM
F18708596: D13239.id31999.diff
Sun, Sep 28, 10:15 PM
F18658561: D13239.diff
Sep 23 2025, 7:14 AM
F18631390: D13239.diff
Sep 16 2025, 3:13 PM
F18625914: D13239.id32008.diff
Sep 15 2025, 11:54 PM
F18620525: D13239.diff
Sep 15 2025, 5:31 AM
F18523882: D13239.diff
Sep 6 2025, 11:25 AM

Details

Summary

Ref T8496. In D13123, the condition for establishing a web session was made too strict: we need to let non-activated users establish web sessions in order to see "you are a bad disabled person" or "your account needs approval" messages. The previous behavior let them in, the new behavior incorrectly locks them out.

Test Plan

Enabled login approvals and registered a new account with username/password auth.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable