Page MenuHomePhabricator

Add a "template" parameter to application default policies
ClosedPublic

Authored by epriestley on Jun 11 2015, 7:08 PM.
Tags
None
Referenced Files
F18830491: D13251.id.diff
Sat, Oct 25, 7:05 AM
F18829523: D13251.id.diff
Fri, Oct 24, 10:39 PM
F18822907: D13251.diff
Thu, Oct 23, 9:13 AM
F18703709: D13251.diff
Sep 28 2025, 4:53 AM
F18697873: D13251.id32034.diff
Sep 27 2025, 10:32 AM
F18656496: D13251.id.diff
Sep 22 2025, 10:41 PM
F18652308: D13251.diff
Sep 21 2025, 7:35 AM
F18623763: D13251.id32037.diff
Sep 15 2025, 5:32 PM
Subscribers

Details

Summary

Ref T5681. Ref T6860. This doesn't do anything interesting on its own, just makes the next diff smaller.

In the next diff, policies become aware of the types of objects they're acting on. We need to specify which object type all the "Default View/Edit" settings are for so they get the right rules.

For example, a rule like "Allow task author" is OK for "View Policy" on a task, and also OK for "Default View Policy" on ManiphestApplication. But it's not OK for "Can Create Tasks" on ManiphestApplication.

So annotate all the "template"/"default" policies with their types. The next diff will use these to let you select appropriate rules for the given object type.

Test Plan
  • Used grep to find these.
  • This change has no effect.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable