Page MenuHomePhabricator
Feed Advanced Search

May 29 2015

epriestley added a comment to T8359: Switching between images in Pholio causes a full reload of the image.

It's intentional that these images aren't cacheable, but we should try to improve the browser behavior.

May 29 2015, 9:23 PM · Pholio
epriestley added a comment to T8347: Recurring events start generating at range start, but should start generating at (range start - event duration).

For a weekly event, I'd expect about 52. For a daily event, I'd expect about 365.

May 29 2015, 9:20 PM · Calendar
epriestley added a comment to T8115: arcanist plugin system.

I don't want to build a hacky version of this blindly without having a future plan for solving the real package management problems we'll eventually encounter (off the top of my head: versioning, dependencies, trust, signing, channels/distribution, support for Phabricator applications and general-purpose libphutil libraries rather than just arc extensions).

May 29 2015, 9:13 PM · Arcanist
epriestley closed T8350: Synchronize Projects across servers. as Wontfix.

We don't plan to support this.

May 29 2015, 2:22 PM · Projects
epriestley closed T8351: There is no way in Harbormaster to delete a Build plan as Wontfix.

Sorry, we do not support or accept feature requests for prototype applications like Harbormaster. See here for discussion:

May 29 2015, 2:21 PM · Harbormaster
epriestley added a comment to T8353: Unhandled Exception when viewing a Diffusion commit.

Restart Apache (if you use Apache) or php-fpm (if you use nginx + php-fpm), and let me know if you still see the issue?

May 29 2015, 2:20 PM · Diffusion
epriestley added a comment to T8347: Recurring events start generating at range start, but should start generating at (range start - event duration).

Screen Shot 2015-05-28 at 5.40.21 PM.png (1×2 px, 217 KB)

May 29 2015, 12:40 AM · Calendar
epriestley created T8347: Recurring events start generating at range start, but should start generating at (range start - event duration).
May 29 2015, 12:40 AM · Calendar
epriestley closed T8210: Phacility Cluster: Bastion host stopped responding as Resolved.

See subtasks for details, but I've:

May 29 2015, 12:00 AM · Ops, Phacility

May 28 2015

epriestley closed T8344: `arc land` Exception; null passed to `idx()` as Resolved by committing Restricted Diffusion Commit.
May 28 2015, 11:11 PM · Arcanist
epriestley closed T8344: `arc land` Exception; null passed to `idx()`, a subtask of T7604: Remove "Arcanist Projects", as Resolved.
May 28 2015, 11:11 PM · Diffusion
epriestley added a revision to T8344: `arc land` Exception; null passed to `idx()`: Unknown Object (Differential Revision).
May 28 2015, 11:10 PM · Arcanist
epriestley added a comment to T8346: Config issues should not use remarkup.

This is intentional in the general case because some config issues may be raised before we can load CSS, so they can't contain Remarkup.

May 28 2015, 11:09 PM · Config
epriestley claimed T8344: `arc land` Exception; null passed to `idx()`.
May 28 2015, 7:52 PM · Arcanist
epriestley added a parent task for T8344: `arc land` Exception; null passed to `idx()`: T7604: Remove "Arcanist Projects".
May 28 2015, 7:52 PM · Arcanist
epriestley added a subtask for T7604: Remove "Arcanist Projects": T8344: `arc land` Exception; null passed to `idx()`.
May 28 2015, 7:52 PM · Diffusion
epriestley added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.

That sounds like a poor field name for users...

May 28 2015, 6:08 PM · Spaces, Wikimedia, Policy
epriestley added a comment to T6766: `arc diff` should do an early check for total diff size and provide appropriate hints for the user.

From T8343, the total corpus size warning didn't appear to fire properly.

May 28 2015, 5:42 PM · Arcanist
epriestley created T8343: Copied code detection takes >30s on 48MB diff.
May 28 2015, 5:40 PM · Differential
epriestley added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.

In concrete terms, major items here that we know about specifically are:

May 28 2015, 5:05 PM · Spaces, Wikimedia, Policy
epriestley added a comment to T8336: Make a workflow that integrates nicely with list based email/patch reviews.

we want to decide which emails just do not get sent, because a list will be cc'ed

May 28 2015, 3:34 PM · llvm, FreeBSD, Herald
epriestley removed a subtask for T8333: linters with deprecated configurations give hard-to-debug errors: T8335: Email verification link doesn't let you verify on first click.
May 28 2015, 3:00 PM · Lint
epriestley removed a parent task for T8335: Email verification link doesn't let you verify on first click: T8333: linters with deprecated configurations give hard-to-debug errors.
May 28 2015, 3:00 PM · FreeBSD, Auth
epriestley added a comment to T8336: Make a workflow that integrates nicely with list based email/patch reviews.

ability to enforce selecting a mailing list to cc

May 28 2015, 2:59 PM · llvm, FreeBSD, Herald
epriestley updated subscribers of T7870: List of cases where ghost comments end up somewhere confusing or unexpected.

@avivey, added your case from D13036 above.

May 28 2015, 2:28 PM · Inline Comments, Restricted Project, Differential
epriestley updated the task description for T7870: List of cases where ghost comments end up somewhere confusing or unexpected.
May 28 2015, 2:28 PM · Inline Comments, Restricted Project, Differential
gaconkzk awarded T6526: Implement "Badges" or "Medals", for annotating special users a Like token.
May 28 2015, 1:37 AM · Restricted Project, Badges (v0), People
epriestley added a comment to T8090: Allow Harbormaster to perform change handoff in a defensible way.

If some commit, "A", is on some other commit, "B", which is on master, we consider that to be the "correct" form of "A": it's the one you tested, it's the one any local lint / unit ran against, and it's what we expect you to land.

May 28 2015, 12:19 AM · Haskell.org, Restricted Project, Harbormaster

May 27 2015

epriestley added a comment to T8332: Allow arcanist output to be sent to a file.

Is there a practical use case motivating this? The cases I can come up with are:

May 27 2015, 11:22 PM · Arcanist
epriestley edited P1794 arc lint.
May 27 2015, 11:05 PM
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

We could really push two refs: phabricator/diff/12345 and phabricator/base/12345. To phabricator/base/12345, we push the first parent of the last thing that pops out of git log HEAD --not --remotes -- (that is, the first ancestor of the diff which is also present in any remote)?

May 27 2015, 10:59 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

From D13041, it looks like the first time git does a push to a totally separate staging area it pushes a lot of extra data, probably because none of the heads in the remote are ancestors of the head being pushed, so it can't detect that their ancestries are 99.9% identical.

May 27 2015, 10:51 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
btrahan awarded T8330: Detect/repair invalid "enum" config a Like token.
May 27 2015, 10:31 PM · Contributor Onboarding, Setup
epriestley updated subscribers of T8330: Detect/repair invalid "enum" config.
May 27 2015, 10:11 PM · Contributor Onboarding, Setup
epriestley created T8330: Detect/repair invalid "enum" config.
May 27 2015, 10:11 PM · Contributor Onboarding, Setup
epriestley added a comment to T8200: Upload File explanation dialog displays behind fullscreen editor.

make the fullscreen mode z-index some smaller value

May 27 2015, 9:49 PM · Restricted Project, Remarkup, Files
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

I configured this for our repos; only hiccup so far is that there's no way to disable "Commit Hook" Herald rules right now so the first pushes (which pushed the entire repo history) took a little while. Normal "arc diff" staging pushes only take about a second.

May 27 2015, 7:04 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley edited P1791 Instance Config.
May 27 2015, 6:40 PM
epriestley added a comment to T8326: Scripts may try to access PhabricatorStartup, but can not.

A clean-ish but very non-general fix would be to load PhabricatorStartup explicitly before using it in code which might be hit on a non-web pathway. It looks like PhabricatorAccessControlTestCase.php already does this.

May 27 2015, 5:47 PM · Infrastructure
epriestley created T8326: Scripts may try to access PhabricatorStartup, but can not.
May 27 2015, 5:44 PM · Infrastructure
epriestley closed T7127: Saving new path list when deletes occur is erroneous at best as Resolved by committing Restricted Diffusion Commit.
May 27 2015, 5:30 PM · Owners
epriestley closed T7127: Saving new path list when deletes occur is erroneous at best, a subtask of T8320: Bring Owners out of the dark ages, as Resolved.
May 27 2015, 5:30 PM · Prioritized, Owners
epriestley closed T8073: Unable to add Repositories to Owner groups (Packages) after creation as Resolved by committing Restricted Diffusion Commit.
May 27 2015, 5:30 PM · Owners
epriestley closed T8073: Unable to add Repositories to Owner groups (Packages) after creation, a subtask of T8320: Bring Owners out of the dark ages, as Resolved.
May 27 2015, 5:30 PM · Prioritized, Owners
epriestley closed Restricted Maniphest Task, a subtask of T8320: Bring Owners out of the dark ages, as Resolved.
May 27 2015, 5:30 PM · Prioritized, Owners
epriestley closed T8317: Can't add a new path to an owner's package as Resolved by committing Restricted Diffusion Commit.
May 27 2015, 5:30 PM · Owners
epriestley closed T8317: Can't add a new path to an owner's package, a subtask of T8320: Bring Owners out of the dark ages, as Resolved.
May 27 2015, 5:30 PM · Prioritized, Owners
epriestley closed T8259: `arc diff` doesn't use chunked uploads as Resolved by committing Restricted Diffusion Commit.
May 27 2015, 5:26 PM · Arcanist
epriestley added a revision to T8259: `arc diff` doesn't use chunked uploads: Unknown Object (Differential Revision).
May 27 2015, 5:18 PM · Arcanist
CodeMouse92 awarded T8022: Implement a meeting autoscheduler a Like token.
May 27 2015, 5:54 AM · Calendar
epriestley added a revision to T7127: Saving new path list when deletes occur is erroneous at best: Unknown Object (Differential Revision).
May 27 2015, 1:29 AM · Owners
epriestley added a revision to T8317: Can't add a new path to an owner's package: Unknown Object (Differential Revision).
May 27 2015, 1:29 AM · Owners
epriestley added a revision to T8073: Unable to add Repositories to Owner groups (Packages) after creation: Unknown Object (Differential Revision).
May 27 2015, 1:29 AM · Owners
epriestley added a revision to T8320: Bring Owners out of the dark ages: Unknown Object (Differential Revision).
May 27 2015, 1:29 AM · Prioritized, Owners
epriestley created T8323: Saving draft inlines on left hand side of files not present in newer diff in diff-of-diffs fails.
May 27 2015, 12:29 AM · Inline Comments, Differential

May 26 2015

epriestley added a comment to T8321: Re-enable reentrant code.

Maybe put "../arcanist/bin" as the first component of your PATH? That should work from arcanist/ or libphutil/.

May 26 2015, 11:47 PM · Arcanist
epriestley added a revision to T8320: Bring Owners out of the dark ages: Unknown Object (Differential Revision).
May 26 2015, 11:22 PM · Prioritized, Owners
epriestley added a comment to T8321: Re-enable reentrant code.

Can you just... not run different copies of arc in other different copies of arc? Crazy workaround, I know.

May 26 2015, 11:07 PM · Arcanist
epriestley added a comment to T8320: Bring Owners out of the dark ages.

So, anyone have any clue what we use "primary owner" for?

May 26 2015, 9:01 PM · Prioritized, Owners
epriestley added a revision to T8320: Bring Owners out of the dark ages: Unknown Object (Differential Revision).
May 26 2015, 8:57 PM · Prioritized, Owners
epriestley added a comment to T8320: Bring Owners out of the dark ages.

Installs which relied on "Arcanist Project" Herald rules don't necessarily have a perfect way forward; "Owners"-based rules are one of the alternatives I suggest in the upgrading guide in the description of that task.

May 26 2015, 8:38 PM · Prioritized, Owners
epriestley added a revision to T8320: Bring Owners out of the dark ages: Unknown Object (Differential Revision).
May 26 2015, 8:33 PM · Prioritized, Owners
epriestley updated the task description for T4830: Applications with Public permissions requiring users to login.
May 26 2015, 7:49 PM · Facts, Policy, People
epriestley removed a project from T4830: Applications with Public permissions requiring users to login: Owners.
May 26 2015, 7:49 PM · Facts, Policy, People
epriestley added a comment to T4830: Applications with Public permissions requiring users to login.

D13024 fixes this for Owners.

May 26 2015, 7:49 PM · Facts, Policy, People
epriestley added a revision to T8320: Bring Owners out of the dark ages: Unknown Object (Differential Revision).
May 26 2015, 7:49 PM · Prioritized, Owners
epriestley added a subtask for T8320: Bring Owners out of the dark ages: T5263: Owners does not interact well with Subversion repositories using "Import Only" to import a subset of the repository.
May 26 2015, 7:11 PM · Prioritized, Owners
epriestley added a parent task for T5263: Owners does not interact well with Subversion repositories using "Import Only" to import a subset of the repository: T8320: Bring Owners out of the dark ages.
May 26 2015, 7:11 PM · Owners
chad awarded T8320: Bring Owners out of the dark ages a Manufacturing Defect? token.
May 26 2015, 7:11 PM · Prioritized, Owners
epriestley moved T4830: Applications with Public permissions requiring users to login from Future to Dark Ages on the Owners board.
May 26 2015, 7:11 PM · Facts, Policy, People
epriestley moved T5263: Owners does not interact well with Subversion repositories using "Import Only" to import a subset of the repository from Future to Dark Ages on the Owners board.
May 26 2015, 7:11 PM · Owners
epriestley added a parent task for T7127: Saving new path list when deletes occur is erroneous at best: T8320: Bring Owners out of the dark ages.
May 26 2015, 7:11 PM · Owners
epriestley added a subtask for T8320: Bring Owners out of the dark ages: T7127: Saving new path list when deletes occur is erroneous at best.
May 26 2015, 7:11 PM · Prioritized, Owners
epriestley moved T7127: Saving new path list when deletes occur is erroneous at best from Backlog to Dark Ages on the Owners board.
May 26 2015, 7:11 PM · Owners
epriestley moved T8073: Unable to add Repositories to Owner groups (Packages) after creation from Backlog to Dark Ages on the Owners board.
May 26 2015, 7:11 PM · Owners
epriestley moved T8317: Can't add a new path to an owner's package from Backlog to Dark Ages on the Owners board.
May 26 2015, 7:11 PM · Owners
epriestley moved T8320: Bring Owners out of the dark ages from Backlog to Dark Ages on the Owners board.
May 26 2015, 7:10 PM · Prioritized, Owners
epriestley added a subtask for T8320: Bring Owners out of the dark ages: T8073: Unable to add Repositories to Owner groups (Packages) after creation.
May 26 2015, 7:10 PM · Prioritized, Owners
epriestley added a parent task for T8073: Unable to add Repositories to Owner groups (Packages) after creation: T8320: Bring Owners out of the dark ages.
May 26 2015, 7:10 PM · Owners
epriestley added a subtask for T8320: Bring Owners out of the dark ages: Unknown Object (Maniphest Task).
May 26 2015, 7:10 PM · Prioritized, Owners
epriestley added a subtask for T8320: Bring Owners out of the dark ages: T8317: Can't add a new path to an owner's package.
May 26 2015, 7:10 PM · Prioritized, Owners
epriestley added a parent task for T8317: Can't add a new path to an owner's package: T8320: Bring Owners out of the dark ages.
May 26 2015, 7:10 PM · Owners
epriestley created T8320: Bring Owners out of the dark ages.
May 26 2015, 7:10 PM · Prioritized, Owners
epriestley added a comment to T8317: Can't add a new path to an owner's package.

I can't immediately reproduce this, but Owners is in generally bad shape. I think I can justify spending at least some time unearthing it because of vaguely related work in T7604, though, so let's see how far I get.

May 26 2015, 7:09 PM · Owners
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

Yep, that's right. My plan for the upstream to move forward in the short term (until we build virtual refs) is:

May 26 2015, 6:46 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley closed T8318: Diffusion closes tasks when commit message has a line ending in "fixes" followed by a line beginning with a Txxx task reference as Wontfix.

In the general case, this is working as intended. Specifically, it's intentional that we accept linebreaks in the middle of a "Fixes X, Y" statement, because linebreaks aren't always added explicitly by users.

May 26 2015, 5:53 PM · Diffusion
epriestley added a revision to T8238: Formally support side-band change handoff in external repositories: Unknown Object (Differential Revision).
May 26 2015, 5:42 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a revision to T8238: Formally support side-band change handoff in external repositories: Unknown Object (Differential Revision).
May 26 2015, 5:39 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

It looks like we can push to some secret place:

May 26 2015, 5:31 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

I have this working, but pushing to tags in the same repo is pretty leaky. The docs say this of git fetch:

May 26 2015, 5:19 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a revision to T8259: `arc diff` doesn't use chunked uploads: Restricted Differential Revision.
May 26 2015, 3:57 PM · Arcanist
epriestley added a revision to T8259: `arc diff` doesn't use chunked uploads: Unknown Object (Differential Revision).
May 26 2015, 3:18 PM · Arcanist
epriestley added a comment to T7484: Lock is not locked by this process.

spooky!

May 26 2015, 1:52 PM · Restricted Project, Daemons
epriestley lowered the priority of T5375: Tokenizers fail in Firefox on Android from Unbreak Now! to Wishlist.
May 26 2015, 1:36 PM · Firefox, Android
gerriet awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
May 26 2015, 1:29 PM · Workboards (v3), Restricted Project
epriestley closed T8312: Example for postponed linters as Wontfix.

See T8089 / T8097. We are moving away from the "postponed linters" mechanism, specifically.

May 26 2015, 1:15 PM · Support
epriestley closed T8314: arc diff causes exception if no reviewers are specified as Resolved by committing Restricted Diffusion Commit.
May 26 2015, 1:07 PM · Arcanist
epriestley closed T8156: Linter failures don't provide relevant stacktraces as Resolved by committing Restricted Diffusion Commit.
May 26 2015, 1:06 PM · Arcanist, Lint

May 25 2015

epriestley added a revision to T7447: Bring inline comments forward across revision updates: Unknown Object (Differential Revision).
May 25 2015, 6:58 PM · Prioritized, Differential
epriestley added a comment to T8302: Maybe allow ctrl-click to search for any symbol?.

Using command on Macs is fine.

May 25 2015, 6:11 PM · Symbols