Page MenuHomePhabricator

Recurring events start generating at range start, but should start generating at (range start - event duration)
Closed, ResolvedPublic

Description

Repro steps:

  • Create a year-long event which recurs daily, starting about a year ago.
  • View the calendar.

Expected results:

  • Each day has about 365 events on it.

Actual results:

  • Days have about 1, 2, 3, 4, 5, 6, etc., events on them.

Discussion:

I think this is because we begin generating instances at the range start, but should actually begin generating them at (range start - event duration).

For example, if a 4-hour recurring event began at 11:30 the night before the 1st of the month on the Calendar view, it won't generate because we start generating instances at 12:00 AM on the 1st. Instead, we should start generating instances at (12:00 AM - 4 hours), i.e. 8:00 PM on the previous day.

Revisions and Commits

Restricted Differential Revision

Event Timeline

epriestley raised the priority of this task from to Needs Triage.
epriestley updated the task description. (Show Details)
epriestley added a project: Calendar.
epriestley moved this task to Backlog on the Calendar board.
epriestley added a subscriber: epriestley.

Screen Shot 2015-05-28 at 5.40.21 PM.png (1×2 px, 217 KB)

Screen Shot 2015-05-28 at 5.40.18 PM.png (1×2 px, 491 KB)

lpriestley added a parent task: Restricted Maniphest Task.May 29 2015, 4:40 PM

As "Expected Result", maybe each day should have 52? For number of weeks?

For a weekly event, I'd expect about 52. For a daily event, I'd expect about 365.

lpriestley added a revision: Restricted Differential Revision.May 29 2015, 9:53 PM
lpriestley closed this task as Resolved by committing Restricted Diffusion Commit.May 29 2015, 10:46 PM
lpriestley added a commit: Restricted Diffusion Commit.