Page MenuHomePhabricator

Add skeleton for Portals, a collection of dashboards and other resources
ClosedPublic

Authored by epriestley on Mar 29 2019, 5:39 PM.
Tags
None
Referenced Files
F13325036: D20348.diff
Sat, Jun 15, 1:16 AM
F13305601: D20348.diff
Sat, Jun 8, 11:46 PM
F13298635: D20348.diff
Fri, Jun 7, 7:03 AM
F13281664: D20348.diff
Sun, Jun 2, 11:04 AM
F13244827: D20348.diff
Thu, May 23, 5:21 AM
F13207014: D20348.id.diff
May 15 2024, 8:10 PM
F13201931: D20348.diff
May 14 2024, 6:45 PM
F13194961: D20348.diff
May 12 2024, 10:01 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13275. Today, you can build a custom page on the home page, on project pages, and in your favorites menu.

PHI374 would approximately like to build a completely standalone custom page, and this generally seems like a reasonable capability which we should support, and which should be easy to support if the "custom menu" stuff is built right.

In the near future, I'm planning to shore up some of the outstanding issues with profile menus and then build charts (which will have a big dashboard/panel component), so adding Portals now should let me double up on a lot of the testing and maybe make some of it a bit easier.

Test Plan

Viewed the list of portals, created a new portal. Everything is currently a pure skeleton with no unique behavior.

Here's a glorious portal page:

Screen Shot 2019-03-29 at 10.38.55 AM.png (619×1 px, 96 KB)

Diff Detail

Repository
rP Phabricator
Branch
portal1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22434
Build 30700: Run Core Tests
Build 30699: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Mar 29 2019, 5:39 PM

I'm not planning to land any of this stuff before the release cut unless it somehow magically all comes together in the next three hours and appears to work flawlessly, which seems unlikely, although there aren't that many major outstanding bugs ProfileMenuItem so maybe it's within the realm of physical possibility.

This revision is now accepted and ready to land.Mar 29 2019, 7:27 PM
This revision was automatically updated to reflect the committed changes.