Access policies for content within Phabricator.
Details
Details
Description
Feb 25 2021
Feb 25 2021
epriestley added a comment to T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers.
See also T13068, which suggests rendering mentions in a special style when the user has muted the object.
Feb 19 2021
Feb 19 2021
Feb 18 2021
Feb 18 2021
epriestley closed T4411: Adding a CC to a Maniphest Task should give View rights for that user as Resolved.
I'm going to close this in favor of T13602, which has a more cohesive/modern discussion of the issue. Broadly:
Feb 13 2021
Feb 13 2021
Feb 5 2021
Feb 5 2021
epriestley added a comment to T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers.
- When rendering a "no view permission" hovercard, it would be nice to annotate it with an explicit "The user can't see this object" piece of context information.
epriestley added a comment to T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers.
- Context objects don't make it into timeline rendering engines.
- Context objects don't make it into comment previews.
Feb 4 2021
Feb 4 2021
epriestley triaged T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers as Normal priority.
Jan 28 2021
Jan 28 2021
epriestley added a comment to T13478: Fix various policy issues with project member materialization around interactions between "Project Members" policies and Subprojects/Milestones.
Leftover Raw Members
Sep 1 2020
Sep 1 2020
20after4 added a comment to T13478: Fix various policy issues with project member materialization around interactions between "Project Members" policies and Subprojects/Milestones.
Probably related: According to https://phabricator.wikimedia.org/T261642, it seems that when leaving a project, phabricator leaves behind some cruft in the form of materialized memberships for milestones of that project.
Jun 5 2020
Jun 5 2020
• sshannin added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.
Spaces have been working great for my install. The only real place where they're lacking I think arises from their coarseness/mutual-exclusivity.
Feb 20 2020
Feb 20 2020
epriestley added a comment to T13381: Policy explanations for some extended policy objects with "open" default policy plus constraints are misleading.
In T13493, PhabricatorExternalAccountIdentifier could also benefit from this null policy behavior.
Feb 3 2020
Feb 3 2020
epriestley triaged T13484: Allow the policy layer to mark objects as damaged when filtering them as Wishlist priority.
Jan 17 2020
Jan 17 2020
epriestley renamed T13478: Fix various policy issues with project member materialization around interactions between "Project Members" policies and Subprojects/Milestones from Fix various policy issues issues with project member materialization around interactions between "Project Members" policies and Subprojects/Milestones to Fix various policy issues with project member materialization around interactions between "Project Members" policies and Subprojects/Milestones.
Jan 16 2020
Jan 16 2020
Nov 19 2019
Nov 19 2019
epriestley added a comment to T13462: Correct some policy/membership issues in milestone creation.
We materialize some members into the milestone? This causes no real problems, but we shouldn't materialize members into milestones.
epriestley added a comment to T13462: Correct some policy/membership issues in milestone creation.
We predict the wrong set of members for the milestone when testing policies: we predict "no members", but should predict "exactly the same as the members of the parent project"?
epriestley added a comment to T13462: Correct some policy/membership issues in milestone creation.
We check the wrong edit policy when testing if you can create a milestone: we check the default application policy, but should check the parent project policy?
epriestley triaged T13462: Correct some policy/membership issues in milestone creation as Normal priority.
epriestley updated the task description for T13461: Remove policy tag coloration in object header UI.
epriestley triaged T13460: Restore "Owner can view/edit task" policy hint in Task policy explanation dialogs as Low priority.
Sep 12 2019
Sep 12 2019
Here's the fate of the various issues discussed here:
epriestley closed T6802: "Custom policy" for editing/viewing does not link to details, a subtask of T13411: Improve "Custom Policy" behavior in policy dialogs, as Resolved.
epriestley added a comment to T13411: Improve "Custom Policy" behavior in policy dialogs.
This should be reworked some day (perhaps partly here) into some more cohesive API, perhaps newLink().
epriestley added a comment to T13411: Improve "Custom Policy" behavior in policy dialogs.
One other thing is that PhabricatorApplicationPolicyChangeTransaction->renderApplicationPolicy() has unconventional behaviors which are not very helpful and not consistent with normal CAN_EDIT / CAN_VIEW transactions. This is somewhat perplexing because ModularTransactions has renderPolicy() already, which has better behavior. I think it didn't exist yet when Applications modularized in D17757, and when it was introduced in D19829 I just overlooked the opportunity to update it.