Page MenuHomePhabricator

Remove "Editable By" description fields in Passphrase, Phame, and Spaces
ClosedPublic

Authored by epriestley on Sep 12 2019, 2:06 PM.
Tags
None
Referenced Files
F15516225: D20802.diff
Fri, Apr 18, 5:28 PM
F15484945: D20802.diff
Wed, Apr 9, 9:04 PM
F15466086: D20802.id49598.diff
Thu, Apr 3, 1:24 AM
F15458707: D20802.id49598.diff
Mon, Mar 31, 6:31 AM
F15448423: D20802.id.diff
Fri, Mar 28, 4:47 AM
F15446287: D20802.diff
Thu, Mar 27, 6:12 PM
Unknown Object (File)
Feb 18 2025, 2:24 AM
Unknown Object (File)
Feb 11 2025, 4:13 AM
Subscribers
None

Details

Summary

Ref T13411. These three applications render an "Editable By: <policy>" field in their descriptions.

The pages that these appear on all have "Edit <thing>" actions which either tell you the policy or allow you to discover the policy, and this field is unusual (the vast majority of objects don't have it). I think it largely got copy/pasted or used as space-filler and doesn't offer much of value.

Remove it to simplify/standardize these pages and make changes to how this field works simpler to implement.

Test Plan

Viewed a Credential, Blog, and Space; no longer saw the "Editable By" field.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2019, 4:37 PM
This revision was automatically updated to reflect the committed changes.