Page MenuHomePhabricator

Remove "Editable By" description fields in Passphrase, Phame, and Spaces
ClosedPublic

Authored by epriestley on Sep 12 2019, 2:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 1:46 PM
Unknown Object (File)
Sat, Nov 16, 7:37 PM
Unknown Object (File)
Sat, Nov 9, 3:43 PM
Unknown Object (File)
Fri, Oct 25, 2:01 AM
Unknown Object (File)
Oct 22 2024, 10:22 AM
Unknown Object (File)
Oct 15 2024, 10:06 PM
Unknown Object (File)
Sep 28 2024, 10:05 PM
Unknown Object (File)
Sep 28 2024, 8:04 PM
Subscribers
None

Details

Summary

Ref T13411. These three applications render an "Editable By: <policy>" field in their descriptions.

The pages that these appear on all have "Edit <thing>" actions which either tell you the policy or allow you to discover the policy, and this field is unusual (the vast majority of objects don't have it). I think it largely got copy/pasted or used as space-filler and doesn't offer much of value.

Remove it to simplify/standardize these pages and make changes to how this field works simpler to implement.

Test Plan

Viewed a Credential, Blog, and Space; no longer saw the "Editable By" field.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2019, 4:37 PM
This revision was automatically updated to reflect the committed changes.