Page MenuHomePhabricator

Remove "Editable By" description fields in Passphrase, Phame, and Spaces
ClosedPublic

Authored by epriestley on Sep 12 2019, 2:06 PM.

Details

Summary

Ref T13411. These three applications render an "Editable By: <policy>" field in their descriptions.

The pages that these appear on all have "Edit <thing>" actions which either tell you the policy or allow you to discover the policy, and this field is unusual (the vast majority of objects don't have it). I think it largely got copy/pasted or used as space-filler and doesn't offer much of value.

Remove it to simplify/standardize these pages and make changes to how this field works simpler to implement.

Test Plan

Viewed a Credential, Blog, and Space; no longer saw the "Editable By" field.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 12 2019, 2:06 PM
epriestley requested review of this revision.Sep 12 2019, 2:07 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2019, 4:37 PM
This revision was automatically updated to reflect the committed changes.