Page MenuHomePhabricator

Remove "Editable By" description fields in Passphrase, Phame, and Spaces
ClosedPublic

Authored by epriestley on Sep 12 2019, 2:06 PM.
Tags
None
Referenced Files
F18758761: D20802.id49606.diff
Sun, Oct 5, 11:30 PM
F18734033: D20802.id.diff
Tue, Sep 30, 10:47 PM
F18718887: D20802.diff
Mon, Sep 29, 4:28 PM
F18674668: D20802.id49598.diff
Thu, Sep 25, 4:09 PM
F18570633: D20802.id49606.diff
Sep 10 2025, 4:00 AM
F18570632: D20802.id49598.diff
Sep 10 2025, 4:00 AM
F18567388: D20802.id.diff
Sep 9 2025, 3:44 PM
F18430008: D20802.id.diff
Aug 31 2025, 3:37 AM
Subscribers
None

Details

Summary

Ref T13411. These three applications render an "Editable By: <policy>" field in their descriptions.

The pages that these appear on all have "Edit <thing>" actions which either tell you the policy or allow you to discover the policy, and this field is unusual (the vast majority of objects don't have it). I think it largely got copy/pasted or used as space-filler and doesn't offer much of value.

Remove it to simplify/standardize these pages and make changes to how this field works simpler to implement.

Test Plan

Viewed a Credential, Blog, and Space; no longer saw the "Editable By" field.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2019, 4:37 PM
This revision was automatically updated to reflect the committed changes.