Page MenuHomePhabricator

Remove "Editable By" description fields in Passphrase, Phame, and Spaces
ClosedPublic

Authored by epriestley on Sep 12 2019, 2:06 PM.
Tags
None
Referenced Files
F18100697: D20802.diff
Sat, Aug 9, 12:01 PM
F17712040: D20802.diff
Jul 17 2025, 9:22 AM
Unknown Object (File)
May 8 2025, 10:49 PM
Unknown Object (File)
May 6 2025, 11:48 AM
Unknown Object (File)
Apr 30 2025, 4:42 PM
Unknown Object (File)
Apr 18 2025, 5:28 PM
Unknown Object (File)
Apr 9 2025, 9:04 PM
Unknown Object (File)
Apr 3 2025, 1:24 AM
Subscribers
None

Details

Summary

Ref T13411. These three applications render an "Editable By: <policy>" field in their descriptions.

The pages that these appear on all have "Edit <thing>" actions which either tell you the policy or allow you to discover the policy, and this field is unusual (the vast majority of objects don't have it). I think it largely got copy/pasted or used as space-filler and doesn't offer much of value.

Remove it to simplify/standardize these pages and make changes to how this field works simpler to implement.

Test Plan

Viewed a Credential, Blog, and Space; no longer saw the "Editable By" field.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2019, 4:37 PM
This revision was automatically updated to reflect the committed changes.