Page MenuHomePhabricator

Give policy name rendering explicit "text name", "capability link", and "transaction link" pathways
ClosedPublic

Authored by epriestley on Sep 12 2019, 2:46 PM.

Details

Summary

Ref T13411. This cleans up policy name rendering. We ultimately render into three contexts:

  • Plain text contexts, like bin/policy show.
  • Transaction contexts, where we're showing a policy change. In these cases, we link some policies (like project policies and custom policies) but the links go directly to the relevant object or a minimal explanation of the change. We don't link policies like "All Users".
  • Capability contexts, where we're describing a capability, like "Can Push" or cases in Applicaitons. In these cases, we link all policies to the full policy explanation flow.
Test Plan
  • Used bin/policy show to examine the policy of an object with a project policy, no longer saw HTML.
  • Viewed the transaction logs of Applications (ModularTransactions) and Tasks (not ModularTransactions) with policy edits, including project and custom policies.
  • Clicked "Custom Policy" in both logs, got consistent dialogs.
  • Viewed application detail pages, saw all capabities linked to explanatory capability dialogs. The value of having this dialog is that the user can get a full explanation of special rules even if the policy is something mundane like "All Users".

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 12 2019, 2:46 PM
epriestley requested review of this revision.Sep 12 2019, 2:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2019, 4:39 PM
This revision was automatically updated to reflect the committed changes.