Page MenuHomePhabricator

Give policy name rendering explicit "text name", "capability link", and "transaction link" pathways
ClosedPublic

Authored by epriestley on Sep 12 2019, 2:46 PM.
Tags
None
Referenced Files
F18759415: D20804.id49608.diff
Mon, Oct 6, 3:43 AM
F18749227: D20804.id.diff
Sat, Oct 4, 2:56 AM
F18740439: D20804.diff
Thu, Oct 2, 3:08 AM
F18734035: D20804.id.diff
Tue, Sep 30, 10:47 PM
F18628566: D20804.diff
Tue, Sep 16, 6:37 AM
F18570645: D20804.id49608.diff
Wed, Sep 10, 4:01 AM
F18570642: D20804.id49600.diff
Wed, Sep 10, 4:01 AM
F18567392: D20804.id.diff
Tue, Sep 9, 3:44 PM
Subscribers
None

Details

Summary

Ref T13411. This cleans up policy name rendering. We ultimately render into three contexts:

  • Plain text contexts, like bin/policy show.
  • Transaction contexts, where we're showing a policy change. In these cases, we link some policies (like project policies and custom policies) but the links go directly to the relevant object or a minimal explanation of the change. We don't link policies like "All Users".
  • Capability contexts, where we're describing a capability, like "Can Push" or cases in Applicaitons. In these cases, we link all policies to the full policy explanation flow.
Test Plan
  • Used bin/policy show to examine the policy of an object with a project policy, no longer saw HTML.
  • Viewed the transaction logs of Applications (ModularTransactions) and Tasks (not ModularTransactions) with policy edits, including project and custom policies.
  • Clicked "Custom Policy" in both logs, got consistent dialogs.
  • Viewed application detail pages, saw all capabities linked to explanatory capability dialogs. The value of having this dialog is that the user can get a full explanation of special rules even if the policy is something mundane like "All Users".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable