Page MenuHomePhabricator

Give policy name rendering explicit "text name", "capability link", and "transaction link" pathways
ClosedPublic

Authored by epriestley on Sep 12 2019, 2:46 PM.
Tags
None
Referenced Files
F15470104: D20804.diff
Fri, Apr 4, 7:42 PM
F15451517: D20804.id49600.diff
Fri, Mar 28, 10:30 PM
F15449096: D20804.id49608.diff
Fri, Mar 28, 8:26 AM
F15439841: D20804.id49600.diff
Wed, Mar 26, 9:44 AM
F15438882: D20804.id.diff
Wed, Mar 26, 4:16 AM
F15438536: D20804.diff
Wed, Mar 26, 1:19 AM
F15434526: D20804.diff
Tue, Mar 25, 4:17 AM
F15424790: D20804.id49608.diff
Sun, Mar 23, 12:19 AM
Subscribers
None

Details

Summary

Ref T13411. This cleans up policy name rendering. We ultimately render into three contexts:

  • Plain text contexts, like bin/policy show.
  • Transaction contexts, where we're showing a policy change. In these cases, we link some policies (like project policies and custom policies) but the links go directly to the relevant object or a minimal explanation of the change. We don't link policies like "All Users".
  • Capability contexts, where we're describing a capability, like "Can Push" or cases in Applicaitons. In these cases, we link all policies to the full policy explanation flow.
Test Plan
  • Used bin/policy show to examine the policy of an object with a project policy, no longer saw HTML.
  • Viewed the transaction logs of Applications (ModularTransactions) and Tasks (not ModularTransactions) with policy edits, including project and custom policies.
  • Clicked "Custom Policy" in both logs, got consistent dialogs.
  • Viewed application detail pages, saw all capabities linked to explanatory capability dialogs. The value of having this dialog is that the user can get a full explanation of special rules even if the policy is something mundane like "All Users".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable