Page MenuHomePhabricator

Update rendering of policy edit transactions in Applications
ClosedPublic

Authored by epriestley on Sep 12 2019, 2:03 PM.
Tags
None
Referenced Files
F18198220: D20801.id49597.diff
Sun, Aug 17, 11:26 PM
F18100696: D20801.diff
Sat, Aug 9, 12:00 PM
F18091030: D20801.id.diff
Wed, Aug 6, 6:37 PM
F18083974: D20801.diff
Tue, Aug 5, 12:47 PM
Unknown Object (File)
Jun 30 2025, 12:10 PM
Unknown Object (File)
Jun 27 2025, 1:02 PM
Unknown Object (File)
Jun 5 2025, 3:15 PM
Unknown Object (File)
May 26 2025, 6:34 PM
Subscribers
None

Details

Summary

Ref T13411. Since circa D19829, transactions have rendered policy changes in a modern way, notably making "Custom Policy" clickable to show the policy rules.

Edit transactions in Applications still use a separate, older approach to render policies. This produces policy renderings which don't use modern quoting rules and don't link in a modern way.

Make Applications use the same rendering code that other transactions (like normal edit/view edits) use.

Test Plan

Edited policies in Applications, saw more useful transactions in the log. Clicked "Custom Policy" in the transaction log and got a useful explanation of the policy.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2019, 4:32 PM
This revision was automatically updated to reflect the committed changes.