Page MenuHomePhabricator

Update rendering of policy edit transactions in Applications
ClosedPublic

Authored by epriestley on Sep 12 2019, 2:03 PM.

Details

Summary

Ref T13411. Since circa D19829, transactions have rendered policy changes in a modern way, notably making "Custom Policy" clickable to show the policy rules.

Edit transactions in Applications still use a separate, older approach to render policies. This produces policy renderings which don't use modern quoting rules and don't link in a modern way.

Make Applications use the same rendering code that other transactions (like normal edit/view edits) use.

Test Plan

Edited policies in Applications, saw more useful transactions in the log. Clicked "Custom Policy" in the transaction log and got a useful explanation of the policy.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 12 2019, 2:03 PM
epriestley requested review of this revision.Sep 12 2019, 2:04 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 12 2019, 4:32 PM
This revision was automatically updated to reflect the committed changes.