Page MenuHomePhabricator
Differential D10138

Use standard infrastructure to attach commits to other objects
ClosedPublic
Actions

Authored by epriestley on Aug 4 2014, 4:16 PM.
Tags
None
Referenced Files
F15561177: D10138.id24401.diff
Tue, Apr 29, 6:28 PM
F15550567: D10138.id.diff
Sun, Apr 27, 12:20 PM
F15550059: D10138.id24385.diff
Sun, Apr 27, 9:07 AM
F15549130: D10138.id24401.diff
Sun, Apr 27, 3:58 AM
F15546324: D10138.diff
Sat, Apr 26, 3:01 PM
F15535493: D10138.id24401.diff
Thu, Apr 24, 5:25 AM
F15524710: D10138.diff
Mon, Apr 21, 9:52 AM
F15508921: D10138.id.diff
Wed, Apr 16, 7:20 AM
View All Files
Subscribers
epriestley
joshuaspence
mbishopim3

Details

Reviewers
joshuaspence
mbishopim3
btrahan
Maniphest Tasks
T4896: Move Audit to ApplicationTransactions
Commits
Restricted Diffusion Commit
rPe8d272b0dad1: Use standard infrastructure to attach commits to other objects
Summary

Ref T4896. Now that we have a transaction editor, we can delete a giant block of hacks.

I believe this also resolves the commit/task attachment issues @joshuaspence and @mbishopim3 mentioned.

Test Plan

Attached and detached commits and tasks.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24385.Aug 4 2014, 4:16 PM
epriestley retitled this revision from to Use standard infrastructure to attach commits to other objects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence, mbishopim3.
epriestley added a task: T4896: Move Audit to ApplicationTransactions.
epriestley added subscribers: joshuaspence, mbishopim3.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 4 2014, 4:16 PM
epriestley added a comment.Aug 4 2014, 4:16 PM

Let me know if you still see issues with relationships created after this lands. (It won't fix prior relationships, but new ones should be fixed.)

Harbormaster completed remote builds in B2028: Diff 24385.Aug 4 2014, 4:17 PM
mbishopim3 accepted this revision.Aug 4 2014, 5:11 PM
mbishopim3 edited edge metadata.

I can't strictly speak to everything moved in this diff, but applying relationships does work correctly now so it's functionally fine.

This revision is now accepted and ready to land.Aug 4 2014, 5:11 PM
epriestley closed this revision.Aug 4 2014, 7:04 PM
epriestley updated this revision to Diff 24401.

Closed by commit rPe8d272b0dad1 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
1 line
applications/
audit/
editor/
17 lines
diffusion/
edge/
8 lines
maniphest/
edge/
8 lines
repository/
storage/
19 lines
search/
controller/
88 lines

Diff 24401

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...
View Options

src/applications/diffusion/edge/DiffusionCommitHasTaskEdgeType.php

Loading...
View Options

src/applications/maniphest/edge/ManiphestTaskHasCommitEdgeType.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Loading...
View Options

src/applications/search/controller/PhabricatorSearchAttachController.php

Loading...
Phabricator · Built by Phacility