Page MenuHomePhabricator

Use standard infrastructure to attach commits to other objects
ClosedPublic

Authored by epriestley on Aug 4 2014, 4:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 6:48 AM
Unknown Object (File)
Sun, Mar 10, 11:25 AM
Unknown Object (File)
Sun, Mar 10, 11:25 AM
Unknown Object (File)
Sun, Mar 10, 11:25 AM
Unknown Object (File)
Sun, Mar 3, 2:37 AM
Unknown Object (File)
Feb 3 2024, 12:19 AM
Unknown Object (File)
Feb 3 2024, 12:18 AM
Unknown Object (File)
Feb 3 2024, 12:18 AM

Details

Summary

Ref T4896. Now that we have a transaction editor, we can delete a giant block of hacks.

I believe this also resolves the commit/task attachment issues @joshuaspence and @mbishopim3 mentioned.

Test Plan

Attached and detached commits and tasks.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Use standard infrastructure to attach commits to other objects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added subscribers: joshuaspence, mbishopim3.

Let me know if you still see issues with relationships created after this lands. (It won't fix prior relationships, but new ones should be fixed.)

mbishopim3 edited edge metadata.

I can't strictly speak to everything moved in this diff, but applying relationships does work correctly now so it's functionally fine.

This revision is now accepted and ready to land.Aug 4 2014, 5:11 PM
epriestley updated this revision to Diff 24401.

Closed by commit rPe8d272b0dad1 (authored by @epriestley).