Page MenuHomePhabricator

Write a "resign" audit relationship even if actor has no relationship
ClosedPublic

Authored by epriestley on Aug 4 2014, 3:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 7, 2:45 AM
Unknown Object (File)
Fri, Dec 6, 2:10 AM
Unknown Object (File)
Wed, Dec 4, 9:48 AM
Unknown Object (File)
Wed, Dec 4, 2:37 AM
Unknown Object (File)
Tue, Dec 3, 11:57 PM
Unknown Object (File)
Nov 27 2024, 3:16 PM
Unknown Object (File)
Nov 18 2024, 10:59 PM
Unknown Object (File)
Oct 23 2024, 2:07 PM
Subscribers

Details

Summary

Ref T4896. I got this logic slightly wrong when porting it over: we always want to write this relationship, to allow members of a project with an audit request against a commit to resign and get it out of their queue.

Test Plan
  • Resigned from a commit with an existing relationship.
  • Resigned from a commit with no existing relationship, saw one added.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Write a "resign" audit relationship even if actor has no relationship.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
mbishopim3 edited edge metadata.

Confirmed working now.

This revision is now accepted and ready to land.Aug 4 2014, 5:00 PM
epriestley updated this revision to Diff 24400.

Closed by commit rP725e2fa41055 (authored by @epriestley).