Page MenuHomePhabricator

Write a "resign" audit relationship even if actor has no relationship
ClosedPublic

Authored by epriestley on Aug 4 2014, 3:57 PM.

Details

Summary

Ref T4896. I got this logic slightly wrong when porting it over: we always want to write this relationship, to allow members of a project with an audit request against a commit to resign and get it out of their queue.

Test Plan
  • Resigned from a commit with an existing relationship.
  • Resigned from a commit with no existing relationship, saw one added.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24384.Aug 4 2014, 3:57 PM
epriestley retitled this revision from to Write a "resign" audit relationship even if actor has no relationship.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
mbishopim3 accepted this revision.Aug 4 2014, 5:00 PM
mbishopim3 edited edge metadata.

Confirmed working now.

This revision is now accepted and ready to land.Aug 4 2014, 5:00 PM
epriestley closed this revision.Aug 4 2014, 7:03 PM
epriestley updated this revision to Diff 24400.

Closed by commit rP725e2fa41055 (authored by @epriestley).