Write a "resign" audit relationship even if actor has no relationship
ClosedPublic
Actions

Authored by epriestley on Aug 4 2014, 3:57 PM.

Details

Reviewers

joshuaspence
mbishopim3
btrahan

Maniphest Tasks

T4896: Move Audit to ApplicationTransactions

Commits

Restricted Diffusion Commit
rP725e2fa41055: Write a "resign" audit relationship even if actor has no relationship

Summary

Ref T4896. I got this logic slightly wrong when porting it over: we always want to write this relationship, to allow members of a project with an audit request against a commit to resign and get it out of their queue.

Test Plan

Resigned from a commit with an existing relationship.
Resigned from a commit with no existing relationship, saw one added.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24384.Aug 4 2014, 3:57 PM

epriestley retitled this revision from to Write a "resign" audit relationship even if actor has no relationship.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, joshuaspence, mbishopim3.

epriestley added a task: T4896: Move Audit to ApplicationTransactions.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 4 2014, 3:57 PM

Harbormaster completed remote builds in B2027: Diff 24384.Aug 4 2014, 3:59 PM

Confirmed working now.

This revision is now accepted and ready to land.Aug 4 2014, 5:00 PM

Closed by commit rP725e2fa41055 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

editor/

PhabricatorAuditEditor.php

20 lines

Diff 24400

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Write a "resign" audit relationship even if actor has no relationshipClosedPublicActions