Page MenuHomePhabricator
Differential D11251

Continue after rejecting commits from a commit query
ClosedPublic
Actions

Authored by epriestley on Jan 6 2015, 3:36 PM.
Tags
None
Referenced Files
F15524387: D11251.diff
Mon, Apr 21, 7:43 AM
F15518096: D11251.id27005.diff
Sat, Apr 19, 10:52 AM
F15518029: D11251.id.diff
Sat, Apr 19, 10:17 AM
F15516088: D11251.diff
Fri, Apr 18, 4:02 PM
F15498650: D11251.id27007.diff
Sun, Apr 13, 1:41 PM
F15472945: D11251.id27005.diff
Sat, Apr 5, 6:01 PM
F15463677: D11251.diff
Wed, Apr 2, 2:09 AM
F15447715: D11251.diff
Fri, Mar 28, 1:12 AM
View All Files
Subscribers
epriestley
mbishopim3

Details

Reviewers
mbishopim3
fabe
btrahan
Maniphest Tasks
T6880: "Attempting to access attached data on PhabricatorRepositoryCommit (via getRepository())" error when creating or accessing diffs
Commits
Restricted Diffusion Commit
rPd4f992d2ed09: Continue after rejecting commits from a commit query
Summary

Fixes T6880. If matching commits have no visible/loadable repository, we shouldn't keep going forward in the loop.

Test Plan

Havne't built a repro locally yet so not 100% sure this fixes it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 27005.Jan 6 2015, 3:36 PM
epriestley retitled this revision from to Continue after rejecting commits from a commit query.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: fabe, btrahan.
epriestley added a task: T6880: "Attempting to access attached data on PhabricatorRepositoryCommit (via getRepository())" error when creating or accessing diffs.
Herald added a subscriber: epriestley. · View Herald TranscriptJan 6 2015, 3:36 PM
mbishopim3 accepted this revision.Jan 6 2015, 3:51 PM
mbishopim3 added a reviewer: mbishopim3.
mbishopim3 added a subscriber: mbishopim3.

Confirmed working for our users.

This revision is now accepted and ready to land.Jan 6 2015, 3:51 PM
fabe accepted this revision.Jan 6 2015, 3:55 PM
fabe edited edge metadata.

I've reproduced it locally and this fixes it. Before the patch these were two separate foreaches.

We could still link the commit (like we do with a repo that is not accessible) and make it show "restricted" instead.
With this patch the commits would simply ne be linked at all.

Closed by commit rPd4f992d2ed09: Continue after rejecting commits from a commit query (authored by epriestley, committed by epriestley). · Explain WhyJan 6 2015, 4:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
query/
1 line

Diff 27007

View Options

src/applications/diffusion/query/DiffusionCommitQuery.php

Loading...
Phabricator · Built by Phacility