Page MenuHomePhabricator

Accepted differential revision Herald rule not catching
Closed, DuplicatePublic

Description

We have the following rule in place:

When all of these conditions are met:

  • Accepted Differential revision does not exist

Take these actions every time this rule matches:

  • Trigger an Audit by Auditors

"Auditors" is our code review project and has several senior review members. What's happening is if the diff is created but not accepted, the rule does not fire. The lack of a diff altogether still works for triggering an audit but if a diff does exist at all this rule will never execute. This is a problem for us since users are force-landing diffs that aren't accepted and it misses our audit queue.

Event Timeline

mbishopim3 raised the priority of this task from to Needs Triage.
mbishopim3 updated the task description. (Show Details)
mbishopim3 added a project: Herald.
mbishopim3 added subscribers: mbishopim3, epriestley.