Page MenuHomePhabricator

Support Windows paths for lint results
AbandonedPublic

Authored by mbishopim3 on Aug 3 2017, 4:18 PM.
Tags
None
Referenced Files
F13192111: D18326.diff
Sun, May 12, 5:27 AM
Unknown Object (File)
Tue, May 7, 10:03 AM
Unknown Object (File)
Mon, May 6, 2:52 PM
Unknown Object (File)
Fri, May 3, 12:01 PM
Unknown Object (File)
Thu, Apr 25, 3:29 AM
Unknown Object (File)
Fri, Apr 19, 2:36 AM
Unknown Object (File)
Fri, Apr 19, 2:36 AM
Unknown Object (File)
Fri, Apr 19, 2:36 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

When providing lint results in specific files on Windows, handle slash differences so that Arcanist has the correct references to provide things such as inline comments in Differential.

Test Plan

arc lint and subsequent revision submission on files resident on Windows, note correct display of lint results with links.

Diff Detail

Repository
rARC Arcanist
Branch
win
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18068
Build 24271: arc lint + arc unit

Event Timeline

Get local issues with unit tests corrected

@epriestley are code contributions no longer accepted? We don't consider this something related to a bug report per se.

See Contributing Code.

The barrier for contributions is extremely high. In almost all cases where users write code nowadays, it would save us time if they just reported a bug with reproduction instructions instead, since we almost always need this information anyway and sending a patch without this information just adds more overhead.

This is probably one of those cases. There's no associated task describing what the actual problem is, and from the description alone, I don't really know what problem this solves, how to reproduce the issue, etc. Since I don't know what the actual goal is here, I'm not really sure if this is a reasonable fix or not.

Offhand, I'd guess it probably isn't the best fix we could come up with. One aspect of this change which I'm uneasy about, and which might be a bit of a red flag, is that we're destroying information fairly early in the pipeline. Often, it's better to preserve information for as long as possible and normalize it at the last moment. I'm not sure if that applies here or not, but I'd want to look at ways we might be able to retain the original path information for as long as possible.

See also Planning.