Page MenuHomePhabricator
Create Task
Maniphest T4636

Repository information from `arc which` not making it to Phabricator
Closed, ResolvedPublic
Actions

Description

After this sequence of events:

  • You create a revision associated with an arcanist project.
  • The arcanist project is associated with a repository.
  • You manually edit the revision to remove the repositoryPHID.
  • Herald rules trigger.

...Herald will too ambitiously re-resolve the arcanist project and come up with a nonempty repositoryPHID. This was the correct rule before, but no longer is. This resolution should be happening in Differential and Herald should just trust Differential.

Revisions and Commits

rP Phabricator
D8610rP2547a222d8b1 Guarantee that fields copied from diffs persist on revisions
D8576rP03c6bf0d0916 Make Herald less ambitious about resolving repositories for revisions

Event Timeline

epriestley created this task.Mar 17 2014, 9:15 PM
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added projects: Herald, Differential.
epriestley added subscribers: epriestley, • avive.
avivey added a subscriber: avivey.Mar 17 2014, 10:27 PM
mbishopim3 added a subscriber: mbishopim3.Mar 18 2014, 3:05 PM
epriestley added a comment.Mar 18 2014, 3:06 PM

@mbishopim3 reports that diffs linked via projects aren't getting the right repositoryPHIDs set. I can't immediately reproduce this, but it falls into the same general ballpark of code needing to move to more modern places in the pipeline (it should all be in diff creation, now).

epriestley edited this Maniphest Task.Mar 20 2014, 12:19 PM
epriestley edited this Maniphest Task.Mar 21 2014, 9:40 PM
epriestley closed this task as Resolved.Mar 21 2014, 9:40 PM

Closed by commit rP03c6bf0d0916.

epriestley added a comment.Mar 21 2014, 9:40 PM

@mbishopim3, I'm not 100% sure I got your issue -- let me know if you're still seeing it after this.

mbishopim3 added a comment.Mar 24 2014, 3:01 PM

Unfortunately it doesn't seem to have fixed it, despite our setup and 'arc which' the diffs themselves don't have Repository set.

epriestley renamed this task from Herald is too ambitious when determining repositoryPHID to Repository information from `arc which` not making it to Phabricator.Mar 24 2014, 3:01 PM
epriestley reopened this task as Open.
epriestley added a comment.Mar 24 2014, 3:04 PM

Okay, can you try this?

  • Create a new revision which exhibits the bug, say Dnnn.
  • In the "Revision Update History" table on the web view, identify the Diff ID (in the "ID" column), say mmm
  • Run these queries:

    SELECT id, repositoryPHID FROM phabricator_differential.differential_revision WHERE id = NNN SELECT id, repositoryPHID FROM phabricator_differential.differential_diff WHERE id = NNN

...and show me the results?

epriestley edited this Maniphest Task.Mar 24 2014, 5:50 PM
epriestley edited this Maniphest Task.Mar 25 2014, 9:01 PM
epriestley closed this task as Resolved.Mar 25 2014, 9:01 PM

Closed by commit rP2547a222d8b1.

Phabricator · Built by Phacility