Page MenuHomePhabricator

Transcode the HTML part of incoming email into UTF-8 as well
ClosedPublic

Authored by alexmv on Nov 16 2017, 9:00 AM.

Details

Summary

D1093 did this for just the text/plain part of incoming
email. Most text/html parts choose to either use entity encoding
or are already UTF-8, thus obviating the need to transcode the
HTML part. However, this is not always the case, and leads to dropped
messages, by way of:

EXCEPTION: (Exception) Failed to JSON encode value (#5: Malformed UTF-8 characters, possibly incorrectly encoded): Dictionary value at key "html" is not valid UTF8, and cannot be JSON encoded: [snip HTML part of message content]

Generalize the charset transcoding to not apply to just the text/plain part, but
both text/plain and text/html parts.

Test Plan

Fed in a Windows-1252-encoded text/html part with 0x92
bytes in it; verified that $content only contained valid UTF-8 after
this change.

Diff Detail

Repository
rP Phabricator
Branch
transcode-html-part (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 18836
Build 25390: Run Core Tests
Build 25389: arc lint + arc unit

Event Timeline

alexmv created this revision.Nov 16 2017, 9:00 AM
alexmv requested review of this revision.Nov 16 2017, 9:01 AM
epriestley accepted this revision.Nov 16 2017, 5:50 PM

In theory we should maybe store the raw input and transcode it when using it, but that's a pain to change and probably not ever relevant (except maybe for debugging transcoding issues). I think this is completely reasonable. Thanks!

This revision is now accepted and ready to land.Nov 16 2017, 5:50 PM
alexmv closed this revision.Nov 16 2017, 6:08 PM