Page MenuHomePhabricator

Correctly parse `git status --porcelain=2` output with filenames with spaces
ClosedPublic

Authored by alexmv on Apr 20 2018, 1:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 11:19 PM
Unknown Object (File)
Tue, Nov 19, 2:46 PM
Unknown Object (File)
Mon, Nov 18, 11:47 PM
Unknown Object (File)
Sep 28 2024, 6:37 PM
Unknown Object (File)
Sep 26 2024, 7:54 AM
Unknown Object (File)
Sep 15 2024, 10:50 AM
Unknown Object (File)
Sep 6 2024, 3:14 AM
Unknown Object (File)
Sep 6 2024, 3:14 AM
Subscribers

Details

Summary

Filenames are last in git status --porcelain=2 lines; they
are not escaped in any way, despite the fields being
whitespace-delimited. explode thus happily chops apart filenames
with spaces in them, causing later git operations to operate only on
the filename up to the first space.

Split the lines into the right number of elements -- in all cases,
this is one more than the index we're using, since filenames come last.

Test Plan

Altering a file with a space in its path, and running arc diff -a.

Added tests.

Diff Detail

Repository
rARC Arcanist
Branch
up-whitespace (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20193
Build 27403: Run Core Tests
Build 27402: arc lint + arc unit