Page MenuHomePhabricator

Fix inbound mail handling for messages with no HTML body part
ClosedPublic

Authored by epriestley on Nov 22 2017, 3:45 PM.
Tags
None
Referenced Files
F15473020: D18778.diff
Sat, Apr 5, 6:56 PM
F15471513: D18778.diff
Sat, Apr 5, 5:25 AM
F15446734: D18778.diff
Thu, Mar 27, 7:58 PM
F15443264: D18778.id.diff
Thu, Mar 27, 3:24 AM
F15416600: D18778.id.diff
Thu, Mar 20, 12:22 PM
F15393574: D18778.id.diff
Sat, Mar 15, 10:07 PM
F15382960: D18778.diff
Fri, Mar 14, 3:03 PM
F15368499: D18778.id45065.diff
Wed, Mar 12, 2:31 AM
Subscribers
None
Tokens
"Love" token, awarded by catalindazoot.

Details

Summary

See D18776. See https://discourse.phabricator-community.org/t/cant-create-maniphest-tasks-by-email/754/2.

The change in D18776 to improve handling of non-utf8 HTML parts broke handling of mail with no HTML parts. Partly, this is because MimeMailParser has a "traditional" PHP-style API where the return type is an exciting surprise.

Test Plan
  • Sent a text-only message in Mail.app.
  • Used "Show Raw" to copy it to mail.txt, verifying that the raw message contains ONLY a text body.
  • Ran cat mail.txt | ./scripts/mail/mail_handler.php --trace --process-duplicates.
    • Before patch: error about bad idx() on a non-array.
    • After patch: clean mail processing.
  • Did the same with a message with both HTML and text bodies to make sure I didn't break anything.

Ideally we'd probably get test coverage on this, but it's been touched roughly once a year since 2013 so it'll probably hold.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable