Feed All Stories
May 20 2022
May 20 2022
epriestley committed rPcc44ae32c546: Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl" (authored by epriestley).
Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl"
epriestley updated the task description for T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".
epriestley requested review of D21831: Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl".
May 19 2022
May 19 2022
epriestley committed rP42876de60d28: Generate file attachment transactions for explicit Remarkup attachments on… (authored by epriestley).
Generate file attachment transactions for explicit Remarkup attachments on…
epriestley committed rPfee8297121f0: Remove file attachment edge types, including API access (authored by epriestley).
Remove file attachment edge types, including API access
epriestley committed rPb872640c160a: Remove all "FileHasObject" edge reads and writes (authored by epriestley).
Remove all "FileHasObject" edge reads and writes
epriestley committed rPc25a8fabfc1e: Remove all "ObjectHasFile" edge reads and writes (authored by epriestley).
Remove all "ObjectHasFile" edge reads and writes
epriestley committed rP0329df0fa8d4: Copy file attachment edges to new storage (authored by epriestley).
Copy file attachment edges to new storage
epriestley committed rP4a2d961e7632: Adjust paste content transaction to support earlier file PHID extraction (authored by epriestley).
Adjust paste content transaction to support earlier file PHID extraction
epriestley committed rPd017f3f21021: Double-write file attachment to old "edge" storage and new "attachment" storage (authored by epriestley).
Double-write file attachment to old "edge" storage and new "attachment" storage
epriestley committed rP7fcc0f9ebd91: Remove "PhabricatorFile->detachFromObject()" (authored by epriestley).
Remove "PhabricatorFile->detachFromObject()"
epriestley committed rPcfa42c5e655c: Add database storage for a dedicated file attachment table (authored by epriestley).
Add database storage for a dedicated file attachment table
epriestley committed rP6fea5e5ce7d5: Do not extract file PHIDs from remarkup blocks for attachment (authored by epriestley).
Do not extract file PHIDs from remarkup blocks for attachment
epriestley triaged T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default" as Normal priority.
epriestley abandoned D21829: Generate attachment edges from drag-and-dropped files in stacked comments.
This is likely easier to implement by unifying it more closely with the non-comment pathway, and representing it as metadata on the transaction at this level (rather than as a separate transaction).
epriestley updated the diff for D21818: Copy file attachment edges to new storage.
- Perform this migration entirely in SQL instead.
epriestley committed rPee6e2a396fec: Fix some test suite stragglers with PHP 8.1 compatibility (authored by epriestley).
Fix some test suite stragglers with PHP 8.1 compatibility
epriestley committed rP7693a711a725: Persist remarkup metadata in "VersionedDrafts" and record explicit file uploads (authored by epriestley).
Persist remarkup metadata in "VersionedDrafts" and record explicit file uploads
epriestley committed rP33a0731619e8: Give "RemarkupControl" support for tracking metadata (authored by epriestley).
Give "RemarkupControl" support for tracking metadata
epriestley updated the diff for D21827: Give "RemarkupControl" support for tracking metadata.
- Slightly smaller API, because versioned drafts are not coupled to form inputs.
epriestley requested review of D21827: Give "RemarkupControl" support for tracking metadata.
epriestley closed T13680: Pagination in Conpherence may pass an int to `phutil_nonempty_string()`, throwing an exception, a subtask of T13588: PHP 8 Compatibility, as Resolved.
epriestley closed T13680: Pagination in Conpherence may pass an int to `phutil_nonempty_string()`, throwing an exception as Resolved.
Resolved by D21824.
May 17 2022
May 17 2022
epriestley committed rP147b48b934b3: Fix an exception in cursor pagination of Conpherence threads (authored by epriestley).
Fix an exception in cursor pagination of Conpherence threads
Remove "feed.publish" API
epriestley updated the diff for D21826: Remove "feed.publish" API.
- Include library map update.
epriestley requested review of D21826: Remove "feed.publish" API.
cspeckmim added a comment to T13588: PHP 8 Compatibility.
Thank you!
epriestley triaged T13681: Ancient "feed.publish" API is (at best) long obsolete, and arguably exploitable as Normal priority.
epriestley committed rARC85c953ebe4a6: Fix a PHP 8.1 repository marker issue in Mercurial (authored by epriestley).
Fix a PHP 8.1 repository marker issue in Mercurial
epriestley added a revision to T13588: PHP 8 Compatibility: D21825: Fix a PHP 8.1 repository marker issue in Mercurial.
epriestley requested review of D21825: Fix a PHP 8.1 repository marker issue in Mercurial.
epriestley committed rARC942b54a6977a: Straggling fixes for PhutilURI under PHP 8.1 (authored by epriestley).
Straggling fixes for PhutilURI under PHP 8.1
epriestley requested review of D21824: Fix an exception in cursor pagination of Conpherence threads.
cspeckmim added a comment to T13588: PHP 8 Compatibility.
A user just ran into this exception with Arcanist (current master changeset) while running arc diff (using Mercurial) with PHP 8.1. I haven't looked too in depth but it seems similar to other PHP 8.1 issues.
[2022-05-17 20:49:47] EXCEPTION: (RuntimeException) substr(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261] arcanist(head=master, ref.master=3cc486d5c156) #0 PhutilErrorHandler::handleError(integer, string, string, integer) #1 substr(NULL, integer, integer) called at [<arcanist>/src/repository/api/ArcanistRepositoryAPI.php:807] #2 ArcanistRepositoryAPI::getDisplayHash(NULL) called at [<arcanist>/src/repository/marker/ArcanistRepositoryMarkerQuery.php:67] #3 ArcanistRepositoryMarkerQuery::execute() called at [<arcanist>/src/repository/query/ArcanistRepositoryQuery.php:20] #4 ArcanistRepositoryQuery::executeOne() called at [<arcanist>/src/repository/api/ArcanistMercurialAPI.php:988] #5 ArcanistMercurialAPI::getActiveBookmark() called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:2253] #6 ArcanistDiffWorkflow::buildDiffSpecification() called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:380] #7 ArcanistDiffWorkflow::run() called at [<arcanist>/scripts/arcanist.php:427] <<< [1] (+8,567) <exec> 8,567,426 us
May 16 2022
May 16 2022
May 12 2022
May 12 2022
epriestley requested review of D21823: Remove file attachment edge types, including API access.
epriestley added a revision to T13588: PHP 8 Compatibility: D21822: Straggling fixes for PhutilURI under PHP 8.1.
epriestley requested review of D21822: Straggling fixes for PhutilURI under PHP 8.1.
epriestley requested review of D21821: Fix some test suite stragglers with PHP 8.1 compatibility.
epriestley requested review of D21820: Remove all "FileHasObject" edge reads and writes.
epriestley requested review of D21819: Remove all "ObjectHasFile" edge reads and writes.
epriestley requested review of D21818: Copy file attachment edges to new storage.
epriestley requested review of D21815: Remove "PhabricatorFile->detachFromObject()".
epriestley committed rARC3cc486d5c156: Add "pht_list()", a translation wrapper for lists of items (authored by epriestley).
Add "pht_list()", a translation wrapper for lists of items
epriestley requested review of D21814: Add "pht_list()", a translation wrapper for lists of items.
May 10 2022
May 10 2022
epriestley requested review of D21813: Add database storage for a dedicated file attachment table.
epriestley requested review of D21812: Do not extract file PHIDs from remarkup blocks for attachment.
epriestley added a comment to T13588: PHP 8 Compatibility.
I am pretty sure that this error message does not exist prior to PHP 8.1, and PHP 7.4 can not possibly emit it. See here for some evidence that this is true -- note that the error message is not present in the script output until PHP 8.1:
bleketux added a comment to T13588: PHP 8 Compatibility.
Trying to fresh install using PHP 7.4 or PHP 8.1, have the same result when executing:
- ./bin/config set phd.user root
[2022-05-10 02:01:12] EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261] arcanist(head=master, ref.master=fc5b228db537), phabricator(head=master, ref.master=698ada2470b1) #0 PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phabricator>/src/infrastructure/env/PhabricatorEnv.php:128] #1 PhabricatorEnv::initializeCommonEnvironment(boolean) called at [<phabricator>/src/infrastructure/env/PhabricatorEnv.php:75] #2 PhabricatorEnv::initializeScriptEnvironment(boolean) called at [<phabricator>/scripts/init/lib.php:26] #3 init_phabricator_script(array) called at [<phabricator>/scripts/init/init-setup.php:11] #4 require_once(string) called at [<phabricator>/scripts/setup/manage_config.php:5]
May 9 2022
May 9 2022
There may be additional work here, but presuming this is more or less resolved until evidence to the contrary arises.
epriestley closed T13679: Non-administrators can incorrectly edit default global settings as Resolved.
I believe D21811 covers this completely.
epriestley updated the task description for T13679: Non-administrators can incorrectly edit default global settings.
epriestley committed rP698ada2470b1: Correct overbroad automatic capability grant of global settings objects (authored by epriestley).
Correct overbroad automatic capability grant of global settings objects
epriestley triaged T13679: Non-administrators can incorrectly edit default global settings as Normal priority.
epriestley committed rP01253d533bbc: Prevent embedded remarkup content from cycling when it contains embedded self… (authored by epriestley).
Prevent embedded remarkup content from cycling when it contains embedded self…
epriestley added a comment to D21810: Prevent embedded remarkup content from cycling when it contains embedded self-references.
