Page MenuHomePhabricator
Feed All Stories

Feb 4 2017

lyahdav awarded T5523: Make bulk moves easier on Workboards a Like token.
Feb 4 2017, 1:48 AM · Restricted Project, Workboards
epriestley added a comment to T12203: Remove Panel From Dashboard = UNRECOVERABLE FATAL ERROR.

I can't reproduce this: removing panels from dashboards works fine for me:

Feb 4 2017, 1:44 AM · Dashboards, Bug Report
rphl updated the task description for T12203: Remove Panel From Dashboard = UNRECOVERABLE FATAL ERROR.
Feb 4 2017, 1:42 AM · Dashboards, Bug Report
rphl created T12203: Remove Panel From Dashboard = UNRECOVERABLE FATAL ERROR.
Feb 4 2017, 1:38 AM · Dashboards, Bug Report

Feb 3 2017

chad created T12202: Upgrade Guide: Home Menu Items.
Feb 3 2017, 11:48 PM · Guides, Installing & Upgrading, Profile Menu Item
mpickering added a comment to T11091: Make `arc patch` try the local working copy and staging areas.

In our setup (as an open source project) we often get differentials created with base commits which do not exist in upstream. As a result using arc patch often fails, even worse, in a non-recoverable way as --reject is passed to git apply. In a patch fails to cleanly apply it is hard to continue the work-flow and manually correct the merge conflicts.

Feb 3 2017, 10:40 PM · Haskell.org, Arcanist
mpickering added a project to T11091: Make `arc patch` try the local working copy and staging areas: Haskell.org.
Feb 3 2017, 10:35 PM · Haskell.org, Arcanist
chad added a revision to T12174: Home Menu Errata: Unknown Object (Differential Revision).
Feb 3 2017, 10:22 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12201: Bizarro Diffusion/Differential interaction causes stack trace on "Show Older Changes".

"Bizarro Gremlin" is just an alias for Quicksand

Feb 3 2017, 10:05 PM · Diffusion, Differential, Bug Report
thoughtpolice added a comment to T12201: Bizarro Diffusion/Differential interaction causes stack trace on "Show Older Changes".

i'm bad at search

Feb 3 2017, 10:00 PM · Diffusion, Differential, Bug Report
epriestley merged T12201: Bizarro Diffusion/Differential interaction causes stack trace on "Show Older Changes" into T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.
Feb 3 2017, 9:59 PM · Quicksand, Bug Report
epriestley merged task T12201: Bizarro Diffusion/Differential interaction causes stack trace on "Show Older Changes" into T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.
Feb 3 2017, 9:59 PM · Diffusion, Differential, Bug Report
thoughtpolice renamed T12201: Bizarro Diffusion/Differential interaction causes stack trace on "Show Older Changes" from Bizarro Gremlin on secure.phabricator.com to Bizarro Diffusion/Differential interaction causes stack trace on "Show Older Changes".
Feb 3 2017, 9:59 PM · Diffusion, Differential, Bug Report
thoughtpolice created T12201: Bizarro Diffusion/Differential interaction causes stack trace on "Show Older Changes".
Feb 3 2017, 9:57 PM · Diffusion, Differential, Bug Report
chad added a comment to T12174: Home Menu Errata.

I'm going to write up Diviner now, then Upgrading guide

Feb 3 2017, 9:30 PM · Dashboards (v2), Profile Menu Item
chad updated the task description for T12174: Home Menu Errata.
Feb 3 2017, 9:29 PM · Dashboards (v2), Profile Menu Item
chad added a comment to T12200: Typeahead completion (of any kind) does not work with Persistent Chat on.

🅾 Ⓜ 💎

Feb 3 2017, 9:25 PM · Conpherence (v4), Quicksand, Bug Report
epriestley added a comment to T12200: Typeahead completion (of any kind) does not work with Persistent Chat on.

🙉

Feb 3 2017, 8:44 PM · Conpherence (v4), Quicksand, Bug Report
thoughtpolice created T12200: Typeahead completion (of any kind) does not work with Persistent Chat on.
Feb 3 2017, 8:36 PM · Conpherence (v4), Quicksand, Bug Report
thoughtpolice closed T12195: Implement "new" reCAPTCHA UI as Resolved by committing Restricted Diffusion Commit.
Feb 3 2017, 8:06 PM · Feature Request, Auth
thoughtpolice added a comment to T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts.

Yeah, 7.1.2 RC1 seems to fix the problems. There are like 2 dozen random "uuhh fix off by one error, revert thing that overflowed something, you bastard, fix this too" commits in that commit log, even some affecting stuff like libgd (which you'd think would have been pretty hardened), so it's really impossible to tell what fixed what without it becoming tedious.

Feb 3 2017, 7:59 PM · Bug Report
epriestley added a comment to T10687: jx-tooltip does whatever it feels like.

I think we currently don't really try to handle these cases:

Feb 3 2017, 7:31 PM · PHUI, Bug Report
epriestley added a comment to T10687: jx-tooltip does whatever it feels like.

That tip probably does not fit on screen in any of the orientations: it obviously won't fit to the north or east. If we try to put it to the south, part of it will be offscreen to the right. If we try to put it to the west, part of it will be off the top of the screen (the rectangle we use to detect the size of the tip box is slightly larger than the actual pixel size of the tip because we get weird scrollbar interactions if we use the size of the tip exactly).

Feb 3 2017, 7:28 PM · PHUI, Bug Report
friesenschrauber awarded T7930: Let Calendar provide date services to other applications a Love token.
Feb 3 2017, 7:28 PM · Calendar
epriestley added a comment to T10687: jx-tooltip does whatever it feels like.

My trick is:

Feb 3 2017, 7:25 PM · PHUI, Bug Report
chad added a comment to T10687: jx-tooltip does whatever it feels like.

Yeah I couldn't quite grab a screen

Feb 3 2017, 7:24 PM · PHUI, Bug Report
epriestley added a comment to T10687: jx-tooltip does whatever it feels like.

Here's what I see:

Feb 3 2017, 7:24 PM · PHUI, Bug Report
chad added a comment to T10687: jx-tooltip does whatever it feels like.

Chrome:

  • Go to Workboard
  • Click Fullscreen
  • Hover over Fullscreen - tooltip is elsewhere?
Feb 3 2017, 7:22 PM · PHUI, Bug Report
chad moved T10145: Adding a panel to a dashboard multiple times from Backlog to Planned on the Dashboards (v2) board.
Feb 3 2017, 7:08 PM · Dashboards (v2), Bug Report
chad moved T8033: Inform editor when panels have more restrictive policy than dashboard from Backlog to Planned on the Dashboards (v2) board.
Feb 3 2017, 7:08 PM · Dashboards
chad moved T5307: UX for taking actions with search results from Backlog to Planned on the Dashboards (v2) board.
Feb 3 2017, 7:08 PM · Restricted Project, Dashboards (v2), ApplicationEditor, Design
epriestley added a comment to T12174: Home Menu Errata.

Yeah, I don't think I fixed it. I tried this set of steps at master prior to D17308:

Feb 3 2017, 7:01 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12174: Home Menu Errata.

I'm not sure if I actually fixed @rphl's issue or not. D17308 was just aimed at the existing issue under the theory that we'll see more of it after this ships if we aren't already seeing it, but his report definitely might be a new issue.

Feb 3 2017, 6:55 PM · Dashboards (v2), Profile Menu Item
chad added a comment to T12174: Home Menu Errata.

I thought it might be that same issue, but sounded like it was a new issue and not a pre-existing one.

Feb 3 2017, 6:30 PM · Dashboards (v2), Profile Menu Item
chad added a comment to T12174: Home Menu Errata.

Awesome, thanks for hunting that down.

Feb 3 2017, 6:30 PM · Dashboards (v2), Profile Menu Item
epriestley updated the task description for T12174: Home Menu Errata.
Feb 3 2017, 6:27 PM · Dashboards (v2), Profile Menu Item
epriestley added a revision to T8033: Inform editor when panels have more restrictive policy than dashboard: Unknown Object (Differential Revision).
Feb 3 2017, 5:58 PM · Dashboards
epriestley added a revision to T12174: Home Menu Errata: Unknown Object (Differential Revision).
Feb 3 2017, 5:58 PM · Dashboards (v2), Profile Menu Item
epriestley added a revision to T12174: Home Menu Errata: Unknown Object (Differential Revision).
Feb 3 2017, 5:22 PM · Dashboards (v2), Profile Menu Item
chad closed T11971: Build an Icon Typeahead as Resolved by committing Restricted Diffusion Commit.
Feb 3 2017, 5:19 PM · PHUI
epriestley added a comment to T12197: Audits are no longer triggered using singular "Auditor:".

This should now be resolved at HEAD of master, and should promote to stable later today.

Feb 3 2017, 5:15 PM · Audit, Bug Report
epriestley closed T12197: Audits are no longer triggered using singular "Auditor:" as Resolved by committing Restricted Diffusion Commit.
Feb 3 2017, 5:14 PM · Audit, Bug Report
chad removed a project from T11974: Projects should allow setting of any icon: Contributor Onboarding.
Feb 3 2017, 4:45 PM · Projects
brianespinosa awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Feb 3 2017, 4:02 PM · Workboards (v3), Restricted Project
epriestley renamed T12197: Audits are no longer triggered using singular "Auditor:" from Audits are no longer triggered using Auditor: or Auditors: to Audits are no longer triggered using singular "Auditor:".
Feb 3 2017, 3:01 PM · Audit, Bug Report
cspeckmim added a comment to T12071: Require "E" be defined in variables_order so $_ENV is correctly populated.

My testing from D17296 indicates this would also resolve the original problem described in T9639

Feb 3 2017, 2:58 PM · Infrastructure
hskiba added a comment to T12197: Audits are no longer triggered using singular "Auditor:".

Gotcha... Thanks for the explanation. Initially, I wasn't exactly sure what was going on... I sent an email out telling folks to use "Auditor: ..." in their commit messages, upgraded to clean up what I mentioned here T12181: Bulk Deleting Audits does not remove "Audit Required" from Commit, and then the "Auditor: ..." tag stopped working when our team started using it. Appreciate the fix!

Feb 3 2017, 2:52 PM · Audit, Bug Report
epriestley added a comment to T12197: Audits are no longer triggered using singular "Auditor:".

Thanks! I think this is the timeline of events:

Feb 3 2017, 2:31 PM · Audit, Bug Report
epriestley added a revision to T12197: Audits are no longer triggered using singular "Auditor:": Unknown Object (Differential Revision).
Feb 3 2017, 2:18 PM · Audit, Bug Report
hskiba added a comment to T12197: Audits are no longer triggered using singular "Auditor:".

Ahhh... Before both "Auditor: ..." and "Auditors: ..." worked. Now it appears that only "Auditors: ..." works. I must not have been trying it with "Auditors: ..." at all.

Feb 3 2017, 2:07 PM · Audit, Bug Report
epriestley added a comment to T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts.

Per above, it sounds like upgrading fixed what you were seeing?

Feb 3 2017, 1:23 PM · Bug Report
epriestley renamed T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts from `arc liberate` fails on Phabricator mysteriously with PHP 7.1 to `arc liberate` fails on Phabricator miraculously with PHP 7.1.
Feb 3 2017, 1:15 PM · Bug Report
epriestley edited projects for T12199: only some CSS and JS files inaccessible after switching to https, added: Bug Report (Needs Information); removed Bug Report.

This isn't a bug report we can accept upstream. See Contributing Bug Reports for help. In particular:

Feb 3 2017, 1:14 PM · Bug Report (Needs Information)
hskiba added a comment to T12197: Audits are no longer triggered using singular "Auditor:".

No, not yet... In those examples, I just happened to have Auditors on the first line. Usually, it's not on the first line for us.

Feb 3 2017, 12:55 PM · Audit, Bug Report
constantx created T12199: only some CSS and JS files inaccessible after switching to https.
Feb 3 2017, 12:54 PM · Bug Report (Needs Information)
epriestley added a comment to T12197: Audits are no longer triggered using singular "Auditor:".

Does that explain what you're seeing locally?

Feb 3 2017, 12:32 PM · Audit, Bug Report
epriestley edited projects for T12198: Database seen as uninitialized after upgrade....cannot recover, added: Bug Report (Needs Information); removed Bug Report.

This isn't a bug report we can accept upstream. See Contributing Bug Reports for help. In particular:

Feb 3 2017, 12:31 PM · Bug Report (Needs Information)
epriestley added a comment to T12197: Audits are no longer triggered using singular "Auditor:".

Those commits are not expected to trigger an audit after D17122 / T10312. The first line of commit messages is now always parsed as a title, even if it begins "Auditors: ...", "Tests: ...", "Reviewers: ...", etc.

Feb 3 2017, 12:23 PM · Audit, Bug Report
valentinul renamed T12198: Database seen as uninitialized after upgrade....cannot recover from Database seen as uninitialized after upgrade.... to Database seen as uninitialized after upgrade....cannot recover.
Feb 3 2017, 12:23 PM · Bug Report (Needs Information)
valentinul renamed T12198: Database seen as uninitialized after upgrade....cannot recover from Database seens as uninitialized after upgrade.... to Database seen as uninitialized after upgrade.....
Feb 3 2017, 12:22 PM · Bug Report (Needs Information)
valentinul created T12198: Database seen as uninitialized after upgrade....cannot recover.
Feb 3 2017, 12:22 PM · Bug Report (Needs Information)
hskiba created T12197: Audits are no longer triggered using singular "Auditor:".
Feb 3 2017, 10:52 AM · Audit, Bug Report
alicewirek added a comment to T11611: Shit be bad .

Is there a full description or is it a joke? I need to do my case study on tasks that contain errors. I guess that is some empty task that was deleted by the creator immediately.
Will buy case study anyway, no point in looking for phantoms here.

Feb 3 2017, 10:28 AM · Bug Report
kugel- updated subscribers of T10608: Arc diff failing to generate diff with svn 1.9.3.

@epriestley can you have a look at this, please?

Feb 3 2017, 9:56 AM · Arcanist, Bug Report
kugel- added a comment to T12190: In PHP7, include-time warnings from source files are ignored.

@epriestley can you have a look at this, please?

Feb 3 2017, 9:55 AM · Infrastructure
bcooksley added a comment to T5029: Fill in missing context for low-context diffs against tracked repositories.

I would imagine they're using something along those lines yes. I think we'll probably keep a bunch of people happy if pushing Git refs up were supported.

Feb 3 2017, 7:13 AM · KDE, Restricted Project, Diffusion, Differential
chad added a comment to T5029: Fill in missing context for low-context diffs against tracked repositories.

I'm just curious how people are generating diffs, just command line then cut and paste? I would presume those users would be fine with pushing a branch up for review. Are there other methods we're not considering, like IDEs?

Feb 3 2017, 7:08 AM · KDE, Restricted Project, Diffusion, Differential
bcooksley added a comment to T5029: Fill in missing context for low-context diffs against tracked repositories.

Chances are we're going to get complaints that go either way. Myself, i'd tend to prefer T5000.

Feb 3 2017, 7:06 AM · KDE, Restricted Project, Diffusion, Differential
chad added a comment to T5029: Fill in missing context for low-context diffs against tracked repositories.

You would prefer this over T5000?

Feb 3 2017, 7:01 AM · KDE, Restricted Project, Diffusion, Differential
bcooksley added a project to T5029: Fill in missing context for low-context diffs against tracked repositories: KDE.

We've had some people in KDE kick up some fuss about this.

Feb 3 2017, 6:52 AM · KDE, Restricted Project, Diffusion, Differential
chad added a comment to Q558: cannot import git repo using diffusion (Answer 504).

The best way to get help here is to provide us with all information, every step taken, system, phabricator versions, if you could reproduce it on Phacility, etc. Just giving an error message isn't enough for us to give you a lot of guidance

Feb 3 2017, 6:43 AM
hassaan added a comment to Q558: cannot import git repo using diffusion (Answer 504).

It is a private repository - and I have access to it. I can clone it and push to it. So why would this error be thrown. Diffusion shows the number of commits correctly and the name of the recent commit as well but when I click on the repo it outputs the above error.

Feb 3 2017, 6:31 AM
chad added Q558: cannot import git repo using diffusion (Answer 504).
Feb 3 2017, 6:21 AM
hassaan updated Q558: cannot import git repo using diffusion from to cannot import git repo using diffusion.
Feb 3 2017, 6:15 AM
thoughtpolice added a comment to T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts.

PHP7.1 segfaults about a dozen times a day for me, every day, with little apparent rhyme or reason to the segfaults.

I can only assume I am being punished for not rushing it into production as soon as possible. Perhaps we can deploy PHP 7.2 to production directly from master without waiting for an actual release.

Feb 3 2017, 5:49 AM · Bug Report
epriestley added a comment to T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts.

PHP7.1 segfaults about a dozen times a day for me, every day, with little apparent rhyme or reason to the segfaults.

Feb 3 2017, 5:37 AM · Bug Report
epriestley moved T6409: Link Task Status to Work board Column from Future Work to Backlog on the Workboards board.
Feb 3 2017, 4:52 AM · Workboards
• sajithvk moved T6409: Link Task Status to Work board Column from Backlog to Future Work on the Workboards board.

Request reopen, based on my above comment.

Feb 3 2017, 4:50 AM · Workboards
• sajithvk added a comment to T6409: Link Task Status to Work board Column.

This does not contradict T5474, but compliments it. Both tickets are required to provide seamless operation

Feb 3 2017, 4:48 AM · Workboards
chad added a revision to T5307: UX for taking actions with search results: Unknown Object (Differential Revision).
Feb 3 2017, 4:33 AM · Restricted Project, Dashboards (v2), ApplicationEditor, Design
thoughtpolice added a revision to T12195: Implement "new" reCAPTCHA UI: Unknown Object (Differential Revision).
Feb 3 2017, 4:26 AM · Feature Request, Auth
thoughtpolice added a comment to T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts.

Awwwww yissssssss, looks like PHP 7.1.2 RC1 fixes it! Using the Fedora 25 "PHP 7.1 Remi Testing" repository, 7.1.2 just completely finished a run of arc liberate on Phabricator without problem.

Feb 3 2017, 4:04 AM · Bug Report
thoughtpolice added a comment to T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts.

Yeah, the sury repository is the one maintained by one of the PHP devs. I think if you just do something like apt remove php71* or apt remove php7.1* you can just reinstall all the php5.6 packages and you'll be dandy, at least as far as arc is concerned. They're all in the same repo, just separated by version suffix.

Feb 3 2017, 3:59 AM · Bug Report
chad added a comment to T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts.
chad@phac-dev:/var/www/html/dev/phabricator$ php -v
PHP 7.1.1-1+deb.sury.org~xenial+1 (cli) (built: Jan 20 2017 09:20:20) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2017 Zend Technologies
    with Zend OPcache v7.1.1-1+deb.sury.org~xenial+1, Copyright (c) 1999-2017, by Zend Technologies
Feb 3 2017, 3:52 AM · Bug Report
chad added a comment to T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts.

I updated to test this bug. I'll have to roll back if I need to add a new class.

Feb 3 2017, 3:52 AM · Bug Report
thoughtpolice added a comment to T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts.

Just curious -- did you just notice this, or did you upgrade just to test this bug? If it was the first, that's an interesting data point! (that arc liberate is less common than I expected)

Feb 3 2017, 3:50 AM · Bug Report
chad added a comment to T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts.

hqdefault.jpg (360×480 px, 24 KB)

Feb 3 2017, 3:48 AM · Bug Report
thoughtpolice added a comment to T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts.

a devastating self-own. we've all owned ourselves.

Feb 3 2017, 3:47 AM · Bug Report
chad added a comment to T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts.

well i've ruined my dev environment now...

Feb 3 2017, 3:45 AM · Bug Report
thoughtpolice added a comment to T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts.

Yup, that's the one @chad. I haven't tracked it down any further with strace or anything -- but if you try running that phutil_symbols.php command a billion times, note it doesn't fail every time, or possibly even at all (try like, for x in $(seq 1 1000); do php ... >/dev/null; echo $?; done | grep 1 or something). But if you run arc liberate again, it *will* fail every time, just on a different file, at a different point.

Feb 3 2017, 3:42 AM · Bug Report
thoughtpolice added a comment to T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts.

xhprof isn't needed to reproduce this; it's xhpast that's involved. Maybe. (xhpast is just a simple bison/flex parser/lexer combo so it isn't dependent on PHP internals in any way, and it's what drives the module parsing, etc)

Feb 3 2017, 3:40 AM · Bug Report
chad added a comment to T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts.

like this:

Feb 3 2017, 3:40 AM · Bug Report
Mnkras added a comment to T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts.

T9805?

Feb 3 2017, 3:34 AM · Bug Report
thoughtpolice created T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts.
Feb 3 2017, 3:20 AM · Bug Report
thoughtpolice added a comment to T12195: Implement "new" reCAPTCHA UI.

i like that dog's hat. it's a good hat.

Feb 3 2017, 3:12 AM · Feature Request, Auth
chad added a comment to T12195: Implement "new" reCAPTCHA UI.

tarnation

Feb 3 2017, 3:11 AM · Feature Request, Auth
thoughtpolice created T12195: Implement "new" reCAPTCHA UI.
Feb 3 2017, 3:10 AM · Feature Request, Auth
epriestley added a comment to T12194: Drag-n-drop file upload is broken in HEAD.

We need a neologism for "bad workaround".

Feb 3 2017, 3:07 AM · Files, Bug Report
epriestley added a comment to T12194: Drag-n-drop file upload is broken in HEAD.

(A "workaround" is to not use dashboards, but we'll fix this soon.)

Feb 3 2017, 3:05 AM · Files, Bug Report
thoughtpolice added a comment to T12194: Drag-n-drop file upload is broken in HEAD.

Ah, cool -- thanks!

Feb 3 2017, 3:04 AM · Files, Bug Report