Page MenuHomePhabricator
Feed All Stories

May 13 2016

avivey closed Q386: How to edit repository labels as resolved.
May 13 2016, 3:17 AM · Diffusion
avivey added Q386: How to edit repository labels (Answer 377).
May 13 2016, 3:16 AM
chad added a comment to T10954: Differential keyboard shortcut inline selection reticle is visually unclear (bad z-index?).

I think this is likely a bug.

May 13 2016, 3:06 AM · Inline Comments, Differential, Feature Request
epriestley added a comment to T4292: Implement repository replication.

T10940 should be resolved now, D15903 should resolve lock granularity.

May 13 2016, 12:27 AM · Restricted Project, Diffusion
epriestley merged task T10960: Allow people to quote others at calendar like at maniphest into T9275: Move Calendar to EditEngine.
May 13 2016, 12:19 AM · Calendar, Feature Request
epriestley merged T10960: Allow people to quote others at calendar like at maniphest into T9275: Move Calendar to EditEngine.
May 13 2016, 12:19 AM · ApplicationEditor, Policy, Calendar
epriestley added a comment to T10960: Allow people to quote others at calendar like at maniphest.

I'm going to merge this into T9275, which will solve this automatically.

May 13 2016, 12:19 AM · Calendar, Feature Request
Luke081515.2 created T10960: Allow people to quote others at calendar like at maniphest.
May 13 2016, 12:03 AM · Calendar, Feature Request
epriestley added a revision to T10959: Hard-coded diff line height interacts poorly with large custom font sizes: Unknown Object (Differential Revision).
May 13 2016, 12:03 AM · Differential

May 12 2016

epriestley added a revision to T10959: Hard-coded diff line height interacts poorly with large custom font sizes: Unknown Object (Differential Revision).
May 12 2016, 11:42 PM · Differential
epriestley created T10959: Hard-coded diff line height interacts poorly with large custom font sizes.
May 12 2016, 11:35 PM · Differential
epriestley added a revision to T4292: Implement repository replication: Unknown Object (Differential Revision).
May 12 2016, 11:24 PM · Restricted Project, Diffusion
epriestley closed T10940: Enrolling an existing device in a repository cluster has surprising effects and inconsistent severity as Resolved by committing Restricted Diffusion Commit.
May 12 2016, 10:51 PM · Diffusion, Clusters
Krinkle added a comment to T5698: Github-style Remarkup previews on a checked-in resource.

Tagging Wikimedia - This task would resolve a regression we experienced after having moved from Gerrit/Gitblit to Phabricator Diffusion as primary repo browser. Gitblit, similar to GitHub, rendered .md files as Markdown by default. (Remarkup would be fine, too.)

May 12 2016, 10:40 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup
Krinkle added a project to T5698: Github-style Remarkup previews on a checked-in resource: Wikimedia.
May 12 2016, 10:37 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup
epriestley added a revision to T10940: Enrolling an existing device in a repository cluster has surprising effects and inconsistent severity: Unknown Object (Differential Revision).
May 12 2016, 9:31 PM · Diffusion, Clusters
greggrossmeier added a comment to T9195: Durable column menu should always display.
In T9195#132482, @chad wrote:

There is supposed to be a menu icon there, so there is a bug somewhere. Do you have no Conpherences at all, perhaps?

May 12 2016, 7:35 PM · Conpherence
epriestley moved T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API from The Queue to Paused on the Prioritized board.

Moving this to "Paused" since we're waiting on feedback / deployment / bug reports / things to catch on fire.

May 12 2016, 7:32 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley moved T5187: Make "Upload File" dialog have a vanilla file upload control from Preflight to The Queue on the Prioritized board.
May 12 2016, 7:31 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley moved T10939: Support for OWNERS files from Preflight to The Queue on the Prioritized board.
May 12 2016, 7:31 PM · Prioritized, Restricted Project, Owners
epriestley added a comment to T10694: Improve behavior of context for inline comments in mail.
  • Patches from metamta.differential.inline-patches should be formatted more nicely in HTML mail at HEAD.
  • metamta.differential.unified-comment-context has been removed and we now raise setup guidance about it.
  • The View Revision button is functional locally, but waiting on design once @chad gets back from vacation next week, since my version of it looks a lot like I designed it (D15884).
  • Swapping HTML mail to become the default is ready (D15885) but waiting on the button and maybe a few other designey tweaks we want to consider.
  • There's an hour or so of time across all of that which I haven't tabulated yet, but I'll settle it up once those changes actually land.
May 12 2016, 7:22 PM · Prioritized, Restricted Project, Differential, Mail
epriestley closed T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments as Resolved by committing Restricted Diffusion Commit.
May 12 2016, 7:13 PM · Prioritized, Restricted Project, Remarkup, Mail
epriestley closed T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments, a subtask of T992: Send rich HTML mail bodies without impacting reply handling functionality, as Resolved.
May 12 2016, 7:13 PM · Mail, Differential
epriestley closed T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments, a subtask of T10694: Improve behavior of context for inline comments in mail, as Resolved.
May 12 2016, 7:13 PM · Prioritized, Restricted Project, Differential, Mail
epriestley moved T5000: Using Differential with plain Git, without requiring Arc from Backlog to Preflight on the Prioritized board.
May 12 2016, 6:57 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Differential, Arcanist
epriestley added a project to T5000: Using Differential with plain Git, without requiring Arc: Prioritized.

We're prioritizing the research to estimate how much work this is so we can possibly eventually prioritize it, so this is going into the queue, but don't read too much into it.

May 12 2016, 6:57 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Differential, Arcanist
epriestley added a comment to T10694: Improve behavior of context for inline comments in mail.

@epriestley Thats good to know. Also, will this change include formatting the Change Details section of emails? That one is currently a blob of visually unparseable text even in HTML emails.

May 12 2016, 5:55 PM · Prioritized, Restricted Project, Differential, Mail
epriestley added a revision to T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments: Unknown Object (Differential Revision).
May 12 2016, 5:51 PM · Prioritized, Restricted Project, Remarkup, Mail
epriestley placed T6616: Typeahead uses locale-specific comparison up for grabs.
May 12 2016, 5:31 PM · Typeahead, PHUI
matmarex added a comment to T6616: Typeahead uses locale-specific comparison.

Please unassign me from this task (why can't I do it myself?). My patch was rejected.

May 12 2016, 5:30 PM · Typeahead, PHUI
lawrencet closed Q388: Should Differential notify you on inline comments submitted with no additional actions being taken? as invalid.
May 12 2016, 5:14 PM
lawrencet added a comment to Q388: Should Differential notify you on inline comments submitted with no additional actions being taken?.

I was unable to reproduce on secure.phabricator.com, so I'm going to investigate a little further.

May 12 2016, 5:14 PM
epriestley moved T5187: Make "Upload File" dialog have a vanilla file upload control from Backlog to Preflight on the Prioritized board.
May 12 2016, 4:51 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley added a project to T5187: Make "Upload File" dialog have a vanilla file upload control: Prioritized.
May 12 2016, 4:51 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
brion added a comment to T5187: Make "Upload File" dialog have a vanilla file upload control.

Sure. I'd estimate this is 1-2 hours of work if we develop a patch ourselves and 2-3 hours of work if we work with @matmarex to make his patch suitable for inclusion and maintenance in the upstream. Which would you prefer?

See Paid Prioritization and L34 Phacility Prioritization Service Agreement for specifics, if you haven't run across them yet.

You're behind T10917 and T10939 in the queue (see the Prioritized workboard) and some other things which are wrapping up, so it will probably be about a week before we can pursue this. If that sounds reasonable, we can get this into the queue now and confirm with you before starting work.

May 12 2016, 4:48 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley added a comment to T5187: Make "Upload File" dialog have a vanilla file upload control.

Sure. I'd estimate this is 1-2 hours of work if we develop a patch ourselves and 2-3 hours of work if we work with @matmarex to make his patch suitable for inclusion and maintenance in the upstream. Which would you prefer?

May 12 2016, 4:42 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley moved T10939: Support for OWNERS files from Backlog to Preflight on the Prioritized board.
May 12 2016, 4:37 PM · Prioritized, Restricted Project, Owners
epriestley added a project to T10939: Support for OWNERS files: Prioritized.

(I'm just getting this into the preflight column for communication purposes since there's a slot reserved, we won't start work on this until we have an explicit confirmation.)

May 12 2016, 4:37 PM · Prioritized, Restricted Project, Owners
brion added a comment to T5187: Make "Upload File" dialog have a vanilla file upload control.

@epriestley I'm happy to try to pay you to review the patch if that'll help.

May 12 2016, 4:32 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley added a comment to T5187: Make "Upload File" dialog have a vanilla file upload control.

(If that answer isn't particularly satisfying, maybe see discussion starting here: T7820#172877.)

May 12 2016, 4:31 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley added a comment to T5187: Make "Upload File" dialog have a vanilla file upload control.

We haven't seen much interest in this from outside WMF, so there are probably several hundred tasks ahead of it on our natural roadmap.

May 12 2016, 4:25 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley added a comment to Q388: Should Differential notify you on inline comments submitted with no additional actions being taken?.

Ignore my answer, I misunderstood your question. This is not expected. File a bug with reproduction instructions.

May 12 2016, 4:19 PM
epriestley marked Q388: Should Differential notify you on inline comments submitted with no additional actions being taken? (Answer 376) as hidden.
May 12 2016, 4:18 PM
brion added a comment to T5187: Make "Upload File" dialog have a vanilla file upload control.

This is still a big problem for Wikimedia's Phabricator installation, making it unnecessarily difficult to file or amend bug reports about mobile issues.

May 12 2016, 4:18 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley added Q388: Should Differential notify you on inline comments submitted with no additional actions being taken? (Answer 376).
May 12 2016, 4:17 PM
lawrencet updated the question details for Q388: Should Differential notify you on inline comments submitted with no additional actions being taken?.
May 12 2016, 4:15 PM
lawrencet updated Q388: Should Differential notify you on inline comments submitted with no additional actions being taken? from to Should Differential notify you on inline comments submitted with no additional actions being taken?.
May 12 2016, 4:09 PM
epriestley closed T10958: Dead Link at Diviner as Resolved by committing Restricted Diffusion Commit.
May 12 2016, 3:30 PM · Documentation, Diviner, Bug Report
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 12 2016, 3:29 PM · Diffusion (v3)
kebe renamed T10956: Multiple active edit forms from Customized create forms and one global edit form to Multiple active edit forms.
May 12 2016, 3:28 PM · EditEngine, Feature Request
epriestley added a comment to T10958: Dead Link at Diviner.

Thanks!

May 12 2016, 3:20 PM · Documentation, Diviner, Bug Report
epriestley claimed T10958: Dead Link at Diviner.
May 12 2016, 3:20 PM · Documentation, Diviner, Bug Report
epriestley added a revision to T10958: Dead Link at Diviner: Unknown Object (Differential Revision).
May 12 2016, 3:19 PM · Documentation, Diviner, Bug Report
epriestley added a comment to T4292: Implement repository replication.

T10748 is moving into production, which is the last major new piece here. Remaining cleanup work I plan to do in this phase:

May 12 2016, 3:17 PM · Restricted Project, Diffusion
allixsenos added a comment to T4279: Improve auth/LDAP import tools to assist in linking/merging accounts and migrations across providers.

This SQL query will map all users that don't have an LDAP mapping, allowing them to log in using LDAP as long as their LDAP username matches their Phabricator username.

May 12 2016, 3:12 PM · Auth
epriestley added a comment to T10751: Make Phabricator Highly Available.

I think this is the current state of the world. I'm planning to tackle the three major issues noted below (observed repository versioning, repository lock granularity, device enrollment behavior) and then try to wind down this phase, move all this followup work to a new "make clustering more powerful" sort of task, and then plan where to go from there based on which goals are most important (scalability vs multi-region vs read-only vs hg/svn vs drydock vs whatever crops up as installs actually deploy this stuff).

May 12 2016, 3:12 PM · Restricted Project, Infrastructure, Prioritized
Luke081515.2 updated the task description for T10952: Cannot edit pastes, if you want to keep the content.
May 12 2016, 2:31 PM · Paste, Bug Report
mrjoops added a comment to T10957: When logged in through an external auth provider, user is invited to re-create his account.

OK so they have to make it at step 3, before his first session expires, otherwise I'd have to update it directly in DB.

May 12 2016, 2:25 PM · Auth, Bug Report
Luke081515.2 added a comment to T10923: Diffusion API/URI Errata.

If you hide urls, nothing changes at the other places:

May 12 2016, 2:20 PM · Diffusion (v3)
epriestley closed T10955: Changing tags doesn't seem possible on repositories any more? as Resolved by committing Restricted Diffusion Commit.
May 12 2016, 2:17 PM · Diffusion, Bug Report
Luke081515.2 created T10958: Dead Link at Diviner.
May 12 2016, 2:16 PM · Documentation, Diviner, Bug Report
epriestley closed T10860: After an inconsistent cluster repository write, consider just ignoring the lock, a subtask of T4292: Implement repository replication, as Resolved.
May 12 2016, 2:10 PM · Restricted Project, Diffusion
epriestley closed T10860: After an inconsistent cluster repository write, consider just ignoring the lock as Resolved.

Going any farther than this risks some inconsistency / data loss and we haven't managed to break this yet, so I'm going to consider this sufficiently robust until we see evidence otherwise.

May 12 2016, 2:10 PM · Clusters, Diffusion
epriestley added a comment to T10957: When logged in through an external auth provider, user is invited to re-create his account.

They can link their accounts in Settings → External Accounts.

May 12 2016, 2:09 PM · Auth, Bug Report
mrjoops added a comment to T10957: When logged in through an external auth provider, user is invited to re-create his account.

OK for the security feature, but in my case LDAP is the only auth provider (username/password is disabled), so my users can't link their accounts.

May 12 2016, 2:08 PM · Auth, Bug Report
epriestley added a revision to T10751: Make Phabricator Highly Available: Unknown Object (Differential Revision).
May 12 2016, 1:56 PM · Restricted Project, Infrastructure, Prioritized
epriestley added a revision to T10955: Changing tags doesn't seem possible on repositories any more?: Unknown Object (Differential Revision).
May 12 2016, 1:26 PM · Diffusion, Bug Report
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 12 2016, 1:26 PM · Diffusion (v3)
epriestley added a comment to T10955: Changing tags doesn't seem possible on repositories any more?.

It's on an invisible page <_< >_>

May 12 2016, 1:17 PM · Diffusion, Bug Report
epriestley claimed T10955: Changing tags doesn't seem possible on repositories any more?.
May 12 2016, 1:17 PM · Diffusion, Bug Report
epriestley closed T10957: When logged in through an external auth provider, user is invited to re-create his account as Invalid.

This is expected. This is a security feature, not a bug. Just because you have a Phabricator user account named joe does not mean you have authority over the LDAP user account named joe, and vice versa. In many cases LDAP and Phabricator user account names differ. Users must prove they have control over external accounts by linking them before they can use those external accounts to access Phabricator.

May 12 2016, 1:16 PM · Auth, Bug Report
mrjoops added a comment to T10957: When logged in through an external auth provider, user is invited to re-create his account.

I didn't see anything related in recent changelogs, so I didn't update out instance.
But if you could wait a couple of days, I could try to reproduce.

May 12 2016, 12:27 PM · Auth, Bug Report
chad added a comment to T10957: When logged in through an external auth provider, user is invited to re-create his account.

Is the issue reproducible with an updated version of Phabricator?

May 12 2016, 12:16 PM · Auth, Bug Report
mrjoops created T10957: When logged in through an external auth provider, user is invited to re-create his account.
May 12 2016, 12:06 PM · Auth, Bug Report
kebe updated the task description for T10956: Multiple active edit forms.
May 12 2016, 10:31 AM · EditEngine, Feature Request
kebe updated the task description for T10956: Multiple active edit forms.
May 12 2016, 10:31 AM · EditEngine, Feature Request
kebe created T10956: Multiple active edit forms.
May 12 2016, 10:27 AM · EditEngine, Feature Request
hach-que created T10955: Changing tags doesn't seem possible on repositories any more?.
May 12 2016, 9:35 AM · Diffusion, Bug Report
Chiel92 created T10954: Differential keyboard shortcut inline selection reticle is visually unclear (bad z-index?).
May 12 2016, 9:31 AM · Inline Comments, Differential, Feature Request
Chiel92 created T10953: Show maximal amount of context for the selected change in differential, rather than snapping it at the top of the screen.
May 12 2016, 9:23 AM · Differential, Feature Request
Sam2304 awarded T10145: Adding a panel to a dashboard multiple times a Like token.
May 12 2016, 8:44 AM · Dashboards (v2), Bug Report
OlafAndreas added a watcher for Phrequent: OlafAndreas.
May 12 2016, 7:13 AM
avivey updated the question details for Q387: Cannot clone repository hosted on Phabricator over HTTP.
May 12 2016, 7:00 AM
• sobiepan updated Q387: Cannot clone repository hosted on Phabricator over HTTP from to Cannot clone repository hosted on Phabricator over HTTP.
May 12 2016, 6:50 AM
OCram updated Q386: How to edit repository labels from to How to edit repository labels.
May 12 2016, 5:27 AM · Diffusion
epriestley closed I3 Development of making callsigns optional / flexible.
May 12 2016, 1:31 AM · Diffusion
epriestley added a comment to I3 Development of making callsigns optional / flexible.

Callsigns have been optional for a while now so I'm going to close this. See T4245 for context and followups.

May 12 2016, 1:31 AM · Diffusion
epriestley added a comment to T4245: Make repository URIs slightly prettier.

Callsigns have been optional for some time (roughly since D15305 in February 2016, although there were a trickle of bugs after that).

May 12 2016, 1:11 AM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley renamed T4245: Make repository URIs slightly prettier from Make repository callsigns optional or more flexible to Make repository URIs slightly prettier.
May 12 2016, 1:06 AM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a revision to T10751: Make Phabricator Highly Available: Unknown Object (Differential Revision).
May 12 2016, 12:03 AM · Restricted Project, Infrastructure, Prioritized

May 11 2016

epriestley added a comment to T10751: Make Phabricator Highly Available.

T10748 is wrapping up, and repositories now show cluster status in the new "Storage" panel of the new UI:

May 11 2016, 11:46 PM · Restricted Project, Infrastructure, Prioritized
epriestley updated the task description for T10922: Upgrading: New Repository UI, APIs, and URI management.
May 11 2016, 11:21 PM · Diffusion (v3), Installing & Upgrading
epriestley added a comment to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.

I think this is substantially complete now. There will probably still be a trickle of issues as this gets more use and T10923 has some stuff that didn't get fully addressed here, but everything I've been tracking is in reasonable shape as far as I'm aware.

May 11 2016, 11:10 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
20after4 added a comment to T10926: Make it more likely to see assignee & reporter in task view without having to scroll down.

@epriestley: Thanks for the tips. That field is actually a legacy thing at this point and probably should just be hidden everywhere.

May 11 2016, 11:05 PM · Transactions, Feature Request, Maniphest
Luke081515.2 added a comment to T10952: Cannot edit pastes, if you want to keep the content.

Merci :)

May 11 2016, 10:56 PM · Paste, Bug Report
epriestley closed T10930: Exception in editengine for Paste as Resolved by committing Restricted Diffusion Commit.
May 11 2016, 10:35 PM · ApplicationEditor, Bug Report
epriestley closed T10952: Cannot edit pastes, if you want to keep the content as Resolved by committing Restricted Diffusion Commit.
May 11 2016, 10:35 PM · Paste, Bug Report
epriestley added a revision to T10930: Exception in editengine for Paste: Unknown Object (Differential Revision).
May 11 2016, 10:34 PM · ApplicationEditor, Bug Report
epriestley added a revision to T10952: Cannot edit pastes, if you want to keep the content: Unknown Object (Differential Revision).
May 11 2016, 10:34 PM · Paste, Bug Report
Luke081515.2 created T10952: Cannot edit pastes, if you want to keep the content.
May 11 2016, 9:26 PM · Paste, Bug Report