Page MenuHomePhabricator
Feed All Stories

Feb 7 2016

chad added a comment to T10292: Arcanist does not accept milestones as project tags.

These are still prototypes for now, you should have seen this when you created the Milestone:

Feb 7 2016, 3:12 AM · Projects (v3), Differential, Arcanist, Bug Report
chad merged T10292: Arcanist does not accept milestones as project tags into T10010: Implement Subprojects.
Feb 7 2016, 3:10 AM · Projects (v3)
chad merged task T10292: Arcanist does not accept milestones as project tags into T10010: Implement Subprojects.
Feb 7 2016, 3:10 AM · Projects (v3), Differential, Arcanist, Bug Report
Luke081515.2 renamed T10292: Arcanist does not accept milestones as project tags from Arcanist does not accept milestones to Arcanist does not accept milestones as project tags.
Feb 7 2016, 2:59 AM · Projects (v3), Differential, Arcanist, Bug Report
Luke081515.2 created T10292: Arcanist does not accept milestones as project tags.
Feb 7 2016, 2:58 AM · Projects (v3), Differential, Arcanist, Bug Report
ablekh added a comment to T4482: Document one or two reasonable workflows for Github repositories.

@epriestley I have noticed that, in your first comment above, two links, titled "in this document", are broken (links are located in sections "Branching" and "Merging"). It would be nice to have those links to presumably useful and important documents fixed.

Feb 7 2016, 2:06 AM · Guides, Documentation, GitHub
chad added a comment to T9520: Allow Workboards to show a thumbnail image within each card.

We may have implemented this at HEAD. Kinda bare bones, but pretty!

Feb 7 2016, 1:53 AM · Workboards
ablekh added a comment to T10288: Build a real progress bar.

@chad Yes, I ran across it recently. However, it's not clear to me, whether Phragile offers more comprehensive Agile functionality than the Sprint extension, or it is just a repackaged original extension with a more independent installation.

Feb 7 2016, 1:04 AM · Design, PHUI, Projects (v3)
ablekh added a comment to T10288: Build a real progress bar.

@epriestley I think you're slightly exaggerating the complexity of my suggestion. Anyway, this is my first acquaintance with reporting/charting functionality in Phabricator, so I will take time to read more about it (via the task you've linked and beyond). Since you're online, could you give me a pointer to info (beyond Harbormaster documentation), perhaps an article, which describes an end-to-end process of building a CI implementation without external CI servers, such as Jenkins (of course, if it's possible at the present time)?

Feb 7 2016, 12:59 AM · Design, PHUI, Projects (v3)
chad added a comment to T10288: Build a real progress bar.

They maintain a separate plugin I think for charts I think, Phragile? https://blog.wikimedia.org/2015/12/08/why-we-developed-phragile/

Feb 7 2016, 12:57 AM · Design, PHUI, Projects (v3)
ablekh added a comment to T10288: Build a real progress bar.

@chad Yes, that was my implied suggestion. Thank you for clarification. Perhaps, I need to take another look at the Wikimedia's Sprint extension (I'm trying to minimize dependencies on external Phabricator add-ons).

Feb 7 2016, 12:56 AM · Design, PHUI, Projects (v3)
chad added a comment to T10288: Build a real progress bar.

Maybe I misunderstand the request. It sounded like you want each project to define what a "story" is, meaning any task that lives in multiple projects, would have to implement and track each individual projects "story system", thus making task management significantly more complex (hundreds of fields to manage in each task). We don't have per project based custom fields for similar reasoning, mostly that tasks are "free range" objects on a graph, and projects just are metadata about them, not the other way around.

Feb 7 2016, 12:51 AM · Design, PHUI, Projects (v3)
epriestley added a comment to T10288: Build a real progress bar.

You're basically just asking for a magic chart feature that does whatever you want. We, bound by earthly constraints, can not build that, and the request itself is not specific enough to be helpful in defining product direction. See also T4171.

Feb 7 2016, 12:45 AM · Design, PHUI, Projects (v3)
ablekh added a comment to T10288: Build a real progress bar.

@chad I don't see how this fact affects my suggestions. When calculating progress indicators, this simply means that those indicators should reflect corresponding projections (which tasks belong to which projects).

Feb 7 2016, 12:40 AM · Design, PHUI, Projects (v3)
chad added a comment to T10288: Build a real progress bar.

Projects in Phabricator are just tags, and Tasks can belong to multiple Projects.

Feb 7 2016, 12:35 AM · Design, PHUI, Projects (v3)
epriestley updated the task description for T10010: Implement Subprojects.
Feb 7 2016, 12:33 AM · Projects (v3)
ablekh added a comment to T10288: Build a real progress bar.

I think that there should be a single progress bar per project (sub-project), where what metrics (story points, days, ...) are used to produce the corresponding chart should be user/admin-configurable on an individual project (sub-project) basis. That way, both single-metric and more comprehensive multi-metric charts are possible, based on projects' specifics and users' preferences.

Feb 7 2016, 12:30 AM · Design, PHUI, Projects (v3)
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Feb 7 2016, 12:26 AM · Projects (v3)
epriestley moved T10168: Provide a clearer pathway forward for old projects with invalid hashtags from Future to Far Future on the Projects board.
Feb 7 2016, 12:14 AM · Projects, Bug Report
epriestley renamed T10168: Provide a clearer pathway forward for old projects with invalid hashtags from Projects with hashtags that stopped being valid on Oct 12 no longer work between Dec 27 and Jan 18 to Provide a clearer pathway forward for old projects with invalid hashtags.
Feb 7 2016, 12:14 AM · Projects, Bug Report
epriestley lowered the priority of T10168: Provide a clearer pathway forward for old projects with invalid hashtags from Normal to Wishlist.

Some day we'll provide some kind of tooling or migration approach here, but this seems stable for now.

Feb 7 2016, 12:14 AM · Projects, Bug Report

Feb 6 2016

epriestley added a comment to T10288: Build a real progress bar.

I haven't fully decided yet.

Feb 6 2016, 11:06 PM · Design, PHUI, Projects (v3)
chad added a comment to T10288: Build a real progress bar.

In which case I might show one bar, but color it differently if you're ahead of or behind the projects burndown rate. I don't know, I'd have to research it a little. Were you expecting to put Completion Date as a field on Milestones?

Feb 6 2016, 11:04 PM · Design, PHUI, Projects (v3)
chad added a comment to T10288: Build a real progress bar.

Adding a target date to a Milestone opens up other options for UI, like a mini burndown chart.

Feb 6 2016, 11:02 PM · Design, PHUI, Projects (v3)
epriestley added a comment to T10288: Build a real progress bar.

(Maybe the hybrid bar would be useful in some far-future PM-manager-manager view or whatever.)

Feb 6 2016, 10:58 PM · Design, PHUI, Projects (v3)
epriestley added a comment to T10288: Build a real progress bar.

If we're requiring setup and active management before we show a bar, maybe this bar is better?

Feb 6 2016, 10:57 PM · Design, PHUI, Projects (v3)
chad added a comment to T10288: Build a real progress bar.

Yeah, it doesn't convey anything otherwise, like you note.

Feb 6 2016, 10:45 PM · Design, PHUI, Projects (v3)
epriestley added a comment to T10288: Build a real progress bar.

Ah, so you wouldn't even show this bar until we implement points?

Feb 6 2016, 10:44 PM · Design, PHUI, Projects (v3)
chad added a comment to T10288: Build a real progress bar.

I always expected it to be directly tied to "story points" or whatever someone defines that field to be (hours, points, whatever). And that by default, there is no points in Maniphest unless someone has configured it specifically (or basically no [n] at the top of column). Even then, only on Milestones. This is why I think the number and the noun are important in defining what the bar means. Then the bar itself is just UI polish to the number data.

Feb 6 2016, 10:44 PM · Design, PHUI, Projects (v3)
epriestley added a comment to T10288: Build a real progress bar.

As a general philosophical question, what actionable information are we trying to convey with this element? I think it looks good and is probably worth adding even if it's just a "pretty bauble", and it's nice because it can show something reasonable and immediately comprehensible without any additional configuration/setup, but we're starting to descend the slippery slope of charts and graphs and I'd really like to be armed with strong product rationale as we proceed.

Feb 6 2016, 10:32 PM · Design, PHUI, Projects (v3)
• pmoreau awarded T10288: Build a real progress bar a Love token.
Feb 6 2016, 10:13 PM · Design, PHUI, Projects (v3)
chad updated the task description for T10288: Build a real progress bar.
Feb 6 2016, 9:36 PM · Design, PHUI, Projects (v3)
epriestley updated the task description for T10010: Implement Subprojects.
Feb 6 2016, 8:55 PM · Projects (v3)
epriestley added a comment to T10288: Build a real progress bar.

I'm also 90% sure I'm going to have to build a PHUIX / pure javascript version of this anyway, so the pretty photoshop pixels are probably more important than the specific markup.

Feb 6 2016, 8:54 PM · Design, PHUI, Projects (v3)
epriestley added a comment to T10288: Build a real progress bar.

Minor, but it would be nice support multiple color segments, e.g.:

Feb 6 2016, 8:54 PM · Design, PHUI, Projects (v3)
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Feb 6 2016, 8:51 PM · Projects (v3)
epriestley moved T6502: Policy to define who can move cards in a workboard from v3 to Far Future on the Projects board.
Feb 6 2016, 8:37 PM · Projects, Wikimedia, Policy, Workboards
epriestley lowered the priority of T6502: Policy to define who can move cards in a workboard from Normal to Wishlist.

Given the feedback from @Krenair / @MZMcBride, I'm going to shelve this for the time being since WMF is the major driver for it but it looks like some mixture of contentious/low-priority/hypothetical, and even if consensus/priority does develop from WMF I'd like to wait for EditEngine and make sure the problems survive the new capabilities it introduced.

Feb 6 2016, 8:37 PM · Projects, Wikimedia, Policy, Workboards
epriestley added a comment to T6502: Policy to define who can move cards in a workboard.

(Oh, the WMF task got a similar token so it's presumably an objection to the control.)

Feb 6 2016, 8:22 PM · Projects, Wikimedia, Policy, Workboards
epriestley added a comment to T6502: Policy to define who can move cards in a workboard.

I'm not sure if that thumbs-down is an objection to introducing this policy control or an objection to my hesitance to introduce this policy control.

Feb 6 2016, 8:21 PM · Projects, Wikimedia, Policy, Workboards
MZMcBride added a comment to T6502: Policy to define who can move cards in a workboard.

On the Wikimedia side, looking at https://phabricator.wikimedia.org/T1178, I see almost no support or consensus for this feature. Restricting open editing is in some ways antithetical to Wikimedia's values (we try to be as open as possible) and there are a lot of other issues with Phabricator that are higher priority for us.

Feb 6 2016, 8:19 PM · Projects, Wikimedia, Policy, Workboards
Krenair awarded T6502: Policy to define who can move cards in a workboard a Dislike token.
Feb 6 2016, 7:44 PM · Projects, Wikimedia, Policy, Workboards
epriestley added a comment to T6502: Policy to define who can move cards in a workboard.

Looking deeper, I'm sort of wondering if we actually need this. Are you seeing (or still seeing) issues with this?

Feb 6 2016, 7:24 PM · Projects, Wikimedia, Policy, Workboards
chad awarded T10291: Hide "subprojects" menu item for milestone projects by default a Piece of Eight token.
Feb 6 2016, 7:02 PM · Projects (v3), Feature Request
Luke081515.2 awarded M1458: Homepage 2016 a Love token.
Feb 6 2016, 4:35 PM
chad set the image for Projects (v3) to Unknown Object (File).
Feb 6 2016, 4:25 PM
chad closed mock M1459: "><img src=x><".
Feb 6 2016, 3:40 PM
chad closed T10289: Clarify project type in search typeahead as Resolved.
Feb 6 2016, 3:37 PM · Projects (v3)
• testingthis archived P1938 "><img src=x><".
Feb 6 2016, 2:34 PM
• testingthis created P1938 "><img src=x><".
Feb 6 2016, 2:33 PM
epriestley updated subscribers of T10010: Implement Subprojects.
Feb 6 2016, 2:25 PM · Projects (v3)
epriestley merged task T10291: Hide "subprojects" menu item for milestone projects by default into T10010: Implement Subprojects.
Feb 6 2016, 2:25 PM · Projects (v3), Feature Request
epriestley updated the task description for T10010: Implement Subprojects.
Feb 6 2016, 2:25 PM · Projects (v3)
epriestley added a comment to T10291: Hide "subprojects" menu item for milestone projects by default.

I'm just going to merge this into T10010 and note it explicitly as errata; I'm planning to do this but just haven't built a hide-menu-item feature yet.

Feb 6 2016, 2:24 PM · Projects (v3), Feature Request
epriestley updated the task description for T10010: Implement Subprojects.
Feb 6 2016, 2:24 PM · Projects (v3)
• pmoreau created T10291: Hide "subprojects" menu item for milestone projects by default.
Feb 6 2016, 2:18 PM · Projects (v3), Feature Request
• randomuser created M1459: "><img src=x><".
Feb 6 2016, 1:56 PM
epriestley edited the content of Welcome.
Feb 6 2016, 1:19 PM
epriestley edited the content of Welcome.
Feb 6 2016, 1:19 PM
epriestley edited the content of Changelog.
Feb 6 2016, 1:17 PM
epriestley created 2016 Week 6 (Early February) Changelog.
Feb 6 2016, 1:16 PM
epriestley published Blog Post: Development Notes (2016 Week 6).
Feb 6 2016, 1:16 PM
epriestley claimed T10290: Creating first project/task is broken.
Feb 6 2016, 12:47 PM · Bug Report
epriestley closed T10290: Creating first project/task is broken as Resolved by committing Restricted Diffusion Commit.
Feb 6 2016, 12:47 PM · Bug Report
epriestley added a comment to T10290: Creating first project/task is broken.

Thanks for catching this!

Feb 6 2016, 12:47 PM · Bug Report
avivey added a comment to T10290: Creating first project/task is broken.

That fits what the code does - it looks like it gathers all good options, and that includes a "some" projects, if any.

Feb 6 2016, 7:22 AM · Bug Report
jcowgar added a comment to T10290: Creating first project/task is broken.

Turns out that it's not just if zero projects exist, but if the user attempting to create a project does not belong to any project themselves. i.e. no projects are shown.

Feb 6 2016, 7:11 AM · Bug Report
avivey added a comment to T10290: Creating first project/task is broken.

Looks like it was broken at e1c934ab22d8c0d88ec1ce0d73bc497e563b4acb (Works at 8a9f7609755af5e32c2c287c4b732d213cb680ee).

Feb 6 2016, 7:02 AM · Bug Report
avivey created T10290: Creating first project/task is broken.
Feb 6 2016, 7:00 AM · Bug Report
chad added a comment to T9010: Allow badges to have any Font Awesome icon.

There's a lot of junk in "any icon", maybe 10% of the Font Awesome set is useful. We also don't have a chooser for "any icon", so we'd need to build something as such. I could be wrong but I think since Badges is on EditEngine you could set any icon over Conduit. I don't know if I read Evan's diffs right or not.

Feb 6 2016, 6:35 AM · Badges
chad moved T9006: Allow users to pick which Badges show on Timeline from Backlog to v1 on the Badges board.
Feb 6 2016, 6:00 AM · Badges, Restricted Project
chad renamed Badges (v1) from v2 to v1.
Feb 6 2016, 5:59 AM
chad set the image for Badges (v1) to Unknown Object (File).
Feb 6 2016, 5:59 AM
chad created Badges (v1).
Feb 6 2016, 5:58 AM
chad moved T9006: Allow users to pick which Badges show on Timeline from v1 to Backlog on the Badges board.
Feb 6 2016, 5:55 AM · Badges, Restricted Project
chad moved T9007: Allow Badges to be ordered by quality from v1 to Backlog on the Badges board.
Feb 6 2016, 5:55 AM · Badges (v0)
chad moved T9010: Allow badges to have any Font Awesome icon from Far Future to Backlog on the Badges board.
Feb 6 2016, 5:55 AM · Badges
chad moved T8940: Annotate badges with awarder, date from v0 to v0 on the Badges board.
Feb 6 2016, 5:55 AM · Badges (v0)
chad moved T8996: Move Badge awards to be an actual object, not an edge from v0 to v0 on the Badges board.
Feb 6 2016, 5:55 AM · Badges (v0)
chad moved T8941: Badges don't show in certain Timeline conditions from v0 to v0 on the Badges board.
Feb 6 2016, 5:55 AM · Badges (v0)
chad moved T6526: Implement "Badges" or "Medals", for annotating special users from v0 to v0 on the Badges board.
Feb 6 2016, 5:54 AM · Restricted Project, Badges (v0), People
chad set the image for Badges (v0) to Unknown Object (File).
Feb 6 2016, 5:52 AM
chad created Badges (v0).
Feb 6 2016, 5:52 AM
chad updated the image for Aphront from F146824: profile-project.png to F1064789: fa-briefcase-blue.png.
Feb 6 2016, 5:41 AM
• manas-chaudhari awarded T4863: Allow Workboard Cards to be customized for display a Like token.
Feb 6 2016, 5:26 AM · Projects, Workboards, Wikimedia
• manas-chaudhari awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Feb 6 2016, 5:16 AM · Workboards (v3), Restricted Project
• manas-chaudhari awarded T6027: Way to edit which column a task is in from the task itself a Like token.
Feb 6 2016, 5:03 AM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
michaeljs1990 added a comment to T10282: Unsound test exit status creates false positives.
  • @avivey we have our own library that is loaded in when arc runs. I had an out of date version of our library which caused this to throw an error.
  • The chief complaint is that arc unit for unsound tests exits with a status of one since it's indistinguishable from arc completely failing.
  • A harbormaster build step is reading the exit status to determine if the test was a real failure or just the result of an unsound test not passing.
Feb 6 2016, 4:51 AM · Bug Report
avivey added a comment to T10282: Unsound test exit status creates false positives.

I don't fully understand the issue description:

Feb 6 2016, 4:10 AM · Bug Report
avivey added a comment to T10279: Allow bot users to see email addresses of users.

Basically, an alternative Notification implementation?

Feb 6 2016, 2:53 AM · Feature Request
kemurphy added a comment to T10279: Allow bot users to see email addresses of users.

It's a very simple hook to listen to the Phabricator feed, figure out who is subscribed to the object that is the subject of the feed, and ping them in Slack. The goal was to make it stateless so it could be used as an AWS lambda. It's done wonders for our review response time.

Feb 6 2016, 1:59 AM · Feature Request
chad added a comment to T10279: Allow bot users to see email addresses of users.

I'm genuinely curious what you use the integration for. I am interested in more integrations down the road and knowing what installs are really doing with it is helpful.

Feb 6 2016, 1:55 AM · Feature Request
kemurphy added a comment to T10279: Allow bot users to see email addresses of users.

The plugin approach will probably work fine for us. Thanks @epriestley.

Feb 6 2016, 1:50 AM · Feature Request

Feb 5 2016

20after4 awarded T6502: Policy to define who can move cards in a workboard a Love token.
Feb 5 2016, 11:11 PM · Projects, Wikimedia, Policy, Workboards
20after4 added a comment to T6502: Policy to define who can move cards in a workboard.

This is probably happening tomorrow, unless I am just toying with everyone's emotions.

Feb 5 2016, 11:10 PM · Projects, Wikimedia, Policy, Workboards
CamilleBouliere added a comment to T1139: Internationalize Phabricator.

I've just shared some common strings into french. It's on GitHub : Phabricator French Translation.

Feb 5 2016, 10:57 PM · Localization
epriestley added a comment to T6502: Policy to define who can move cards in a workboard.

This is probably happening tomorrow, unless I am just toying with everyone's emotions.

Feb 5 2016, 10:30 PM · Projects, Wikimedia, Policy, Workboards
epriestley created Blog Post: Clarifying Projects as a General Purpose Tool.
Feb 5 2016, 10:28 PM · Projects
epriestley closed T10279: Allow bot users to see email addresses of users as Wontfix.

Yeah, this feature was a mistake and the data should never have been disclosed. We consider user email addresses private. I don't plan to expose this information again.

Feb 5 2016, 9:55 PM · Feature Request
chad updated subscribers of T10279: Allow bot users to see email addresses of users.

I don't know the history of that field, but reading the previous diffs makes it sound like this was a mistakenly added "feature" in D11791 and "fixed" in D12848. @epriestley could answer those specifics, but my guess is that field won't be re-considered for Conduit. I imagine the solution would be Doorkeeper / Oauth for Slack. In the meantime you can crib notes from those diffs to patch in the functionality you need locally.

Feb 5 2016, 9:49 PM · Feature Request