Page MenuHomePhabricator
Feed All Stories

Feb 8 2016

epriestley added a comment to T10298: exact typeahead for archived projects low priory match.

Here's a workaround:

Feb 8 2016, 4:27 PM · Typeahead, Bug Report
cburroughs created T10298: exact typeahead for archived projects low priory match.
Feb 8 2016, 3:54 PM · Typeahead, Bug Report
ajvorobiev awarded T4863: Allow Workboard Cards to be customized for display a Like token.
Feb 8 2016, 3:22 PM · Projects, Wikimedia, Workboards
chad added a comment to T10297: No queries available on Dashboard exception..

I can't repro on any of these steps. Can you give us more specific details maybe that we're missing. Sounds like Javascript didn't fire or something for you. Can you reproduce on this install?

Feb 8 2016, 3:10 PM · Bug Report (Needs Information), Dashboards
NLDK awarded T5391: Support custom fields in 'Export to Excel' a Like token.
Feb 8 2016, 3:10 PM · Data Exporters
tycho.tatitscheff added a comment to T10297: No queries available on Dashboard exception..

phabricator a45fe337a12f29efdf425086018f1160906f0d0f (Sun, Feb 7)
arcanist 57f6fb59d73994d90cd94143787424ce0fdbf73b (Mon, Jan 25)
phutil f43291e99d36045bc459e5133454c0d8fd8768ea (Thu, Jan 21)

Feb 8 2016, 3:03 PM · Bug Report (Needs Information), Dashboards
• bitglue added a comment to T5155: Evaluate support for AWS IAM Roles in S3 Client.

That's a good point, and certainly makes me feel less bad about putting IAM user credentials in a file on the host.

Feb 8 2016, 2:18 PM · Files
ariel added a comment to T4863: Allow Workboard Cards to be customized for display.

I often want to know when the last comment was on a task and who made it. This is a shortcut for digging through my emails; I want to be able to check boards and see if tasks have activity since I last touched them. Any chance of something like this making it in as an option?

Feb 8 2016, 10:48 AM · Projects, Wikimedia, Workboards
maxie updated Q299: Automatically update Phriction article? from to Automatically update Phriction article?.
Feb 8 2016, 9:51 AM
jcowgar added a comment to T10296: SSLRead() return error -9806 on git clone.

I agree, it's fishing. I've done all I can do and gave up. I converted to using SSH instead, which is probably better anyway.

Feb 8 2016, 2:31 AM · Bug Report (Needs Information), Diffusion
epriestley added a comment to T5155: Evaluate support for AWS IAM Roles in S3 Client.

You can use a policy like this to restrict a key to requests originating from a particular VPC:

Feb 8 2016, 2:22 AM · Files
• bitglue added a comment to T5155: Evaluate support for AWS IAM Roles in S3 Client.

I think you missed the point. The attacker in this instance is an employee, or a contractor, or an ex-employee. If you have static credentials sitting in files on your servers, all your ex-employees probably have them, too. And they can use them until you rotate them, which is pretty much never, in practice.

Feb 8 2016, 2:18 AM · Files
• oysterFAKE created T10297: No queries available on Dashboard exception..
Feb 8 2016, 1:34 AM · Bug Report (Needs Information), Dashboards
• oysterFAKE awarded T4213: Provide custom themes, skinning, or custom CSS a Like token.
Feb 8 2016, 1:23 AM · Design
jcowgar added a comment to T10295: Remove 'Attending' from Calendar Search Results display when empty.

Thanks to you guys for helping through my first commit. Probably took longer to review,c comment, approve than to just do it yourself. Appreciate the hand holding, looking forward to other contributes in the future.

Feb 8 2016, 1:02 AM · Calendar, Feature Request
hach-que added a comment to T5155: Evaluate support for AWS IAM Roles in S3 Client.

Since IAM role credentials are always rotating, anyone who wants to abuse those credentials (possibly to avoid using their own credentials which would get them caught) only has an hour at most. It's pretty easy to see who SSHed into the server in the past hour. Not so easy to see who might have had access to the filesystem, ever.

Feb 8 2016, 12:42 AM · Files
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Feb 8 2016, 12:29 AM
epriestley added a revision to T5240: Dragging items (cards, panels) could be better in Workboards: Unknown Object (Differential Revision).
Feb 8 2016, 12:28 AM · Projects (v3), Workboards

Feb 7 2016

epriestley added a revision to T5240: Dragging items (cards, panels) could be better in Workboards: Unknown Object (Differential Revision).
Feb 7 2016, 11:56 PM · Projects (v3), Workboards
epriestley closed T8434: Accommodate the "Security" workflow as Resolved.
Feb 7 2016, 10:42 PM · Wikimedia, Policy, Prioritized
epriestley added a comment to T8434: Accommodate the "Security" workflow.

I believe we generally have an acceptable way forward here, at least in broad strokes, now so I'm going to close this out since I think it has served its purpose, but feel free to file a followup if things stall or you run into trouble.

Feb 7 2016, 10:42 PM · Wikimedia, Policy, Prioritized
aklapper moved T6502: Policy to define who can move cards in a workboard from In Progress to Backlog on the Wikimedia board.
Feb 7 2016, 10:22 PM · Projects, Wikimedia, Policy, Workboards
epriestley removed a project from T5155: Evaluate support for AWS IAM Roles in S3 Client: libphutil.
Feb 7 2016, 10:20 PM · Files
epriestley moved T6445: Rendering SVG images from Backlog to Far Future on the Files board.
Feb 7 2016, 10:20 PM · Wikimedia, Restricted Project, Files
epriestley removed a project from T6445: Rendering SVG images: Remarkup.
Feb 7 2016, 10:20 PM · Wikimedia, Restricted Project, Files
epriestley triaged T6445: Rendering SVG images as Wishlist priority.

This isn't necessarily "won't ever fix", but the cost to secure SVG sufficiently is enormous and I can't imagine it making sense to pursue until we are a huge organization with as many as 4 or 5 full time engineers.

Feb 7 2016, 10:20 PM · Wikimedia, Restricted Project, Files
epriestley added a comment to T6445: Rendering SVG images.

Looking through the security situation in more detail in response to a recent report via HackerOne, I think it's unlikely that we'll pursue support for this in the upstream. Browsers will execute Javascript and other dangerous actions (external includes, entity expansion) in SVGs, and there is no way to avoid this in a categorical way or otherise delegate security to the browser.

Feb 7 2016, 10:16 PM · Wikimedia, Restricted Project, Files
epriestley closed T10295: Remove 'Attending' from Calendar Search Results display when empty as Resolved.

Resolved by D15207. Thanks!

Feb 7 2016, 6:00 PM · Calendar, Feature Request
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Feb 7 2016, 6:00 PM
jcowgar added a comment to T10296: SSLRead() return error -9806 on git clone.
In T10296#157687, @chad wrote:

You're welcome to spin up a test instance on http://phacility.com/ and reproduce there (our platform - your client).

Feb 7 2016, 5:05 PM · Bug Report (Needs Information), Diffusion
chad added a comment to T10296: SSLRead() return error -9806 on git clone.

You're welcome to spin up a test instance on http://phacility.com/ and reproduce there (our platform - your client).

Feb 7 2016, 4:29 PM · Bug Report (Needs Information), Diffusion
chad edited projects for T10296: SSLRead() return error -9806 on git clone, added: Bug Report (Needs Information); removed Bug Report.
Feb 7 2016, 4:23 PM · Bug Report (Needs Information), Diffusion
jcowgar added a comment to T10296: SSLRead() return error -9806 on git clone.
In T10296#157683, @chad wrote:

You'll want to start debugging your curl / ssl certificates (I don't think this is a Phabricator issue).

Feb 7 2016, 4:17 PM · Bug Report (Needs Information), Diffusion
chad added a comment to T10296: SSLRead() return error -9806 on git clone.

You'll want to start debugging your curl / ssl certificates (I don't think this is a Phabricator issue).

Feb 7 2016, 4:15 PM · Bug Report (Needs Information), Diffusion
jcowgar added a revision to T10295: Remove 'Attending' from Calendar Search Results display when empty: Unknown Object (Differential Revision).
Feb 7 2016, 4:08 PM · Calendar, Feature Request
chad added a comment to T10295: Remove 'Attending' from Calendar Search Results display when empty.

go for it!

Feb 7 2016, 3:13 PM · Calendar, Feature Request
jcowgar added a comment to T10296: SSLRead() return error -9806 on git clone.

I installed compiled and installed git from sources on the server, v2.7.1 and that did not solve the problem:

Feb 7 2016, 1:31 PM · Bug Report (Needs Information), Diffusion
jcowgar renamed T10296: SSLRead() return error -9806 on git clone from SSLRead() return error -9806 to SSLRead() return error -9806 on git clone.
Feb 7 2016, 1:14 PM · Bug Report (Needs Information), Diffusion
jcowgar created T10296: SSLRead() return error -9806 on git clone.
Feb 7 2016, 1:13 PM · Bug Report (Needs Information), Diffusion
jcowgar added a comment to T10295: Remove 'Attending' from Calendar Search Results display when empty.

I'm more than happy to take on this task as my first contribution to Phabricator, but in reading the contributor guide it says all feature requests/bug reports should be first discussed.

Feb 7 2016, 7:49 AM · Calendar, Feature Request
jcowgar created T10295: Remove 'Attending' from Calendar Search Results display when empty.
Feb 7 2016, 7:45 AM · Calendar, Feature Request
hach-que added a comment to T10010: Implement Subprojects.

Yeah, it's just a bit tedious to go back through like 40+ projects in the system and add a link which is probably hard-coded and might break in the future (if the project gets renamed or something?)

Feb 7 2016, 6:09 AM · Projects (v3)
chad added a comment to T10010: Implement Subprojects.

If you haven't played with the new nav, it's pretty configurable. Build buttons to new tasks, phriction pages, harbormaster queries, whatever. It's a bit manual at the moment, but otherwise powerful.

Feb 7 2016, 6:07 AM · Projects (v3)
chad added a comment to T10010: Implement Subprojects.

Oh I guess it was just an icon when it was on the workboard. Those have been removed, you can add it back via "Manage Project" -> "Edit Menu", then build a link menu to the URL. We'll have more tools likely for managing those down the road. Our long term goal is to let you put links, dashboards, milestones, nearly anything on that side menu, configurable per project.

Feb 7 2016, 6:05 AM · Projects (v3)
hach-que added a comment to T10010: Implement Subprojects.

Yeah, there used to be a button on the project page somewhere which linked you to the Maniphest query page with that project prefilled in the "Projects" query field. I used it for doing bulk edits on tasks a lot when cleaning up projects that were no longer active or on the backburner (like bulk removing assignees or bulk changing statuses from whatever they were to Wishlist).

Feb 7 2016, 6:04 AM · Projects (v3)
chad added a comment to T10010: Implement Subprojects.

I'm not sure what you mean by "View all tasks" button. Are you referring to the link in the sidenav?

Feb 7 2016, 6:02 AM · Projects (v3)
hach-que added a comment to T10010: Implement Subprojects.

Ah, I'm using it in conjunction with the bulk editor. The "View All Tasks" button used to take you to the Maniphest query page where you could then use the bulk editor to manipulate tasks.

Feb 7 2016, 5:58 AM · Projects (v3)
chad added a comment to T10010: Implement Subprojects.

pasted_file (205×411 px, 26 KB)

Feb 7 2016, 5:57 AM · Projects (v3)
hach-que added a comment to T10010: Implement Subprojects.

With the new column design, there's no more "View All Tasks" button as far as I can see, which is slowing down my work today quite a bit. I keep having to go to the advanced Maniphest search and query different things there instead of just clicking a tag on a task and then going "View All Tasks" to find tasks like it.

Feb 7 2016, 5:56 AM · Projects (v3)
chad added a comment to T10010: Implement Subprojects.

T10294 talks about showing subprojects on a board, which may be confusing. One path we could take is allowing people to toggle on/off various columns (milestones, subprojects, hidden, backlog) like we do hidden columns today.

Feb 7 2016, 5:39 AM · Projects (v3)
hach-que added a comment to T10294: Expected subprojects to appear in project's workboard.

Fair enough

Feb 7 2016, 5:32 AM · Feature Request
chad added a comment to T10294: Expected subprojects to appear in project's workboard.

Suscinting that to "Bugs > Interns" or "Company > Interns" just doesn't work. @epriestley and I went back and forth on this most of last weekend. :( We arrived at "do what you want".

Feb 7 2016, 5:31 AM · Feature Request
chad added a comment to T10294: Expected subprojects to appear in project's workboard.

Overall, If your tag looks janky, that's what we expect you to solve. There is no UI I can present automatically (that I've found) to present 16 levels of information. So we're leaving it to you to present. We took a very basic route (which you can copy) for Milestones. However if you really want "Company > Org > Team > Backend > Bugs > Interns" to show up on a tag, that's just what it's going to look like.

Feb 7 2016, 5:28 AM · Feature Request
rdfree50 added a watcher for Feature Request: rdfree50.
Feb 7 2016, 5:27 AM
hach-que added a comment to T10294: Expected subprojects to appear in project's workboard.

Yeah I know, I'm just giving feedback in the event that your expectations for how users will see / use it was different.

Feb 7 2016, 5:24 AM · Feature Request
chad added a comment to T10294: Expected subprojects to appear in project's workboard.

it is a prototype.

Feb 7 2016, 5:22 AM · Feature Request
hach-que added a comment to T10294: Expected subprojects to appear in project's workboard.

Yeah that's why I was using sub-projects. But I kind of expected them to have the context of the parent project shown in UIs? Now I'm back to doing this sort of thing in subprojects so that I have the right context in various places, which seems kind of janky:

Feb 7 2016, 5:22 AM · Feature Request
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Feb 7 2016, 5:21 AM · Projects (v3)
chad added a comment to T10294: Expected subprojects to appear in project's workboard.

Milestones are only 1 level, subprojects go... 16?

Feb 7 2016, 5:20 AM · Feature Request
hach-que added a comment to T10294: Expected subprojects to appear in project's workboard.

And knowing I could technically have a task in two subprojects is also somewhat unexpected - I guess I was looking for milestones (without their own end dates) that could be broken down into further milestones.

Feb 7 2016, 5:20 AM · Feature Request
hach-que added a comment to T10294: Expected subprojects to appear in project's workboard.

I think I kind of expected subprojects to act a bit more like milestones than they currently do - for example, the fact that a subproject doesn't have the parent project's name in it when it's shown against tasks isn't ideal ("Protogame Version" on it's own doesn't mean much; what if we have multiple projects with Protogame versions?), and this carries across to tasks as well (searching for "Sixty Seconds" doesn't show the subprojects).

Feb 7 2016, 5:19 AM · Feature Request
hach-que added a comment to T10010: Implement Subprojects.

Once I added a single task to the subproject, it started working again.

Feb 7 2016, 5:16 AM · Projects (v3)
chad added a comment to T10294: Expected subprojects to appear in project's workboard.

I have concerns giving users too much rope (normal column, milestone, subproject) will result in a lot of confused users and bad feelings towards Phabricator. My general feeling moving forward is that more time will be taken to ensure even with lots of rope, the experience never confuses someone to the point of hating the product. We get many requests that certainly seem reasonable, but once they're wild in the field, lead to a very poor experience. I'd rather start with shorter rope and dole it out over time if that makes sense. In this case I think having multiple cards displaying isn't a good user experience, no matter the logical intent.

Feb 7 2016, 5:15 AM · Feature Request
hach-que added a comment to T10010: Implement Subprojects.

I just hit this exception when I had:

Feb 7 2016, 5:13 AM · Projects (v3)
epriestley added a comment to T10294: Expected subprojects to appear in project's workboard.

The problem is that it means a card may appear more than once on a workboard (in multiple subproject columns) which violates a lot of assumptions the code makes and will probably be confusing to users forever. We technically generate these columns today, they're just hidden at the last second to avoid obvious brokenness in the UI.

Feb 7 2016, 5:12 AM · Feature Request
hach-que added a comment to T10294: Expected subprojects to appear in project's workboard.

(Should I repost the task description as a comment on that task so it doesn't get lost?)

Feb 7 2016, 5:10 AM · Feature Request
hach-que added a comment to T10294: Expected subprojects to appear in project's workboard.

Yeah I realise they're prototype features (and I mentioned so in the task filing). I just wanted to document something that caught me off guard if it wasn't already on your radar.

Feb 7 2016, 5:09 AM · Feature Request
chad updated subscribers of T10010: Implement Subprojects.
Feb 7 2016, 5:09 AM · Projects (v3)
chad merged task T10294: Expected subprojects to appear in project's workboard into T10010: Implement Subprojects.
Feb 7 2016, 5:09 AM · Feature Request
chad added a comment to T10294: Expected subprojects to appear in project's workboard.

T10010 is tracking subprojects. It should be labeled in the UI these are currently prototype features.

Feb 7 2016, 5:08 AM · Feature Request
hach-que updated the task description for T10294: Expected subprojects to appear in project's workboard.
Feb 7 2016, 5:01 AM · Feature Request
hach-que created T10294: Expected subprojects to appear in project's workboard.
Feb 7 2016, 4:58 AM · Feature Request
epriestley closed T5475: Maybe make clicking a task on workboards edit it as Resolved.

We have some plans to explore other approaches to "view with comments". I think that's probably the right action overall, and the new edit treatment feels good to me.

Feb 7 2016, 4:53 AM · Workboards
epriestley moved T6066: Presentation Mode for Workboards from Backlog to Far Future on the Workboards board.
Feb 7 2016, 4:49 AM · Workboards, Projects
epriestley lowered the priority of T6066: Presentation Mode for Workboards from Low to Wishlist.
Feb 7 2016, 4:49 AM · Workboards, Projects
epriestley closed T6206: Give UI feedback after a task has been moved as Wontfix.

The dimmed state is pretty obvious to my eye (it has possibly changed since this was originally filed) and we haven't seen feedback from other installs about this being difficult to parse visually. If we did see more feedback in this vein, I'd want to start by making the dimmed state more aggressive.

Feb 7 2016, 4:49 AM · Workboards
hach-que added a comment to T10288: Build a real progress bar.

If we're requiring setup and active management before we show a bar, maybe this bar is better?

(-----X~~~Y          )

The left side of the bar is "Start Date". The right side of the bar is "End Date".

... snip ...

Feb 7 2016, 4:39 AM · Design, PHUI, Projects (v3)
epriestley closed T7844: Workboard printable is incomplete/empty as Resolved by committing Restricted Diffusion Commit.
Feb 7 2016, 4:39 AM · Workboards
epriestley moved T7410: Allow a project's workboard to be disabled so that tagged tasks no longer show meaningless "(Backlog)" from Backlog to Future Work on the Workboards board.
Feb 7 2016, 4:35 AM · Projects, Wikimedia, Workboards
epriestley moved T7844: Workboard printable is incomplete/empty from Backlog to Workboards v2 on the Workboards board.
Feb 7 2016, 4:35 AM · Workboards
epriestley moved T10266: Firefox body scroll fails when dragging tasks from Backlog to Far Future on the Workboards board.
Feb 7 2016, 4:35 AM · Firefox, Projects
epriestley moved T6502: Policy to define who can move cards in a workboard from Workboards v2 to Far Future on the Workboards board.
Feb 7 2016, 4:35 AM · Projects, Wikimedia, Policy, Workboards
epriestley added a revision to T7844: Workboard printable is incomplete/empty: Unknown Object (Differential Revision).
Feb 7 2016, 4:32 AM · Workboards
epriestley removed a project from T9379: Build Phriction v3: Prioritized.
Feb 7 2016, 4:16 AM · Phriction
epriestley removed a project from T8783: Unprototype Nuance (v1): Prioritized.
Feb 7 2016, 4:16 AM · Nuance, Restricted Project
epriestley moved T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential from The Queue to Paused on the Prioritized board.
Feb 7 2016, 4:16 AM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley moved T182: Commit into repository directly from differential from The Queue to Paused on the Prioritized board.
Feb 7 2016, 4:16 AM · Haskell.org, Restricted Project, Differential
epriestley moved T9378: Build Projects v3 from Preflight to The Queue on the Prioritized board.
Feb 7 2016, 4:16 AM · Projects (v3), Prioritized
epriestley moved T8434: Accommodate the "Security" workflow from The Queue to Paused on the Prioritized board.
Feb 7 2016, 4:15 AM · Wikimedia, Policy, Prioritized
epriestley moved T7441: Support OAuth providers in the cluster from The Queue to Paused on the Prioritized board.
Feb 7 2016, 4:15 AM · Auth, Phacility
epriestley added a comment to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).

Yes, in theory -- this is a problem with assigning sub-priorities as a side effect of dragging cards around on a priority-ordered workboard. That code hasn't been touched.

Feb 7 2016, 4:15 AM · Restricted Project, Workboards
tycho.tatitscheff awarded T10293: Plan rest of "CoverImage" feature a Love token.
Feb 7 2016, 4:11 AM · Workboards, Projects (v3)
chad added a comment to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).

Given all the refactoring, is this still relevant?

Feb 7 2016, 4:11 AM · Restricted Project, Workboards
epriestley updated the task description for T10293: Plan rest of "CoverImage" feature.
Feb 7 2016, 3:59 AM · Workboards, Projects (v3)
chad renamed T10293: Plan rest of "CoverImage" feature from Plan rest of "CoverImage" feature. to Plan rest of "CoverImage" feature.
Feb 7 2016, 3:41 AM · Workboards, Projects (v3)
• kuttbaur7 added a watcher for Blessed Reviewers: • kuttbaur7.
Feb 7 2016, 3:36 AM
chad created T10293: Plan rest of "CoverImage" feature.
Feb 7 2016, 3:34 AM · Workboards, Projects (v3)
chad moved T10286: Design a Milestone Tag from Backlog to Active on the Design board.
Feb 7 2016, 3:14 AM · Restricted Project, Design, Projects (v3)
chad moved T10288: Build a real progress bar from Backlog to Active on the Design board.
Feb 7 2016, 3:14 AM · Design, PHUI, Projects (v3)
chad moved T10208: Document something about Design Feedback from Active to Backlog on the Design board.
Feb 7 2016, 3:14 AM · Documentation, Design