Edited the task description to add problem description.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Nov 13 2015
No real consensus here, so not worth pursing any changes in the upstream.
We already match up commits tracked in Phabricator, for example, so if you set up Diffusion to track your Github repository, you'll already get this for free.
Please follow Contributing Feature Requests, we unfortunately don't take feature requests that can't describe a problem.
Please see Requesting Features for how to request features in Phabricator. Specifically we're interested in the core problem you are having day to not, and not anticipated problems.
generally, number of databases should not have impact on unit test performance... but nevertheless, it wouldn't hurt to prune database and maybe check local mysql performance settings? maybe You have something enabled/disabled that slows down mysql itself?
One thing I noticed is that I have a large number of test databases locally.
Here is a profile from running ManiphestTaskTestCase only (and without coverage): https://secure.phabricator.com/xhprof/profile/PHID-FILE-fkx2c4q3wtfn6cetww6s/
See https://secure.phabricator.com/xhprof/profile/PHID-FILE-jfpnkcj4lvtjwojxmttl/, which shows the profile from running arc unit --everything.
Right, I see. I had darkconsole.always-on enabled.
The same behavior happens here as well. Typing watch causes the suggestion to be hidden, then adding d to make watchd results in the suggestion reappearing.
Complete outlier device but; tablets with active styli (pretty much just the galaxy note range I think) use hover and it works really well.
They have to enable it on their account in settings. It's not going to trigger accidentally before then.
I'm not concern ed from a security point of view... I'd just rather not give people functionality that they don't need. Specifically, I'm sure someone will open DarkConsole by mistake and not know how to close it.
It's enabled on this server, I can't think of any issues because of it.
So, hypothetically, you're worried people will go into settings and enable Dark Console by choice and do.... what?
In T7053#144095, @epriestley wrote:This also seems to work properly on this host, although I hit the "daemons are not running" setup warning once, presumably by racing their restart. If this is an issue we can tweak how that warning works, I think.
Yea, im getting the same results as chad, tested on php 5.6, and php7 is super fast.
I think this is more to conform with what everyone else does, I know Google and Apple don't let you re-use tokens even if they are still in the valid timeframe, not sure if there are specific reasons behind that besides the attack you came up with above.
Nov 12 2015
Running on a local MySQL server... I'll try to profile the tests later.
Ah. I guess you're thinking along the lines of adding a drop-down menu or something else as a replacement? That would probably be a big improvement on the current UI for our users of the type described above.
I don't expect help/logout/settings to survive the top nav re-design if we add flags/bookmarking.
As mentioned in T9775, we think this would be a very useful feature for those of us who need to work on multiple projects. Having it tied to the flags application would make it awesomely customizable (and make Flags a much more useful application).
It's your call, of course, though I don't really see how adding tooltips to the top UI bar is more disruptive than all of the other places that you have tooltips - e.g., the edit box in which I'm writing this as well as pretty much everything item the default dashboards. I also note that in almost every other part of the UI where you use icons, Phabricator is pretty exemplary in either having tooltips or an explanatory text next to the icon, so it just seems like an odd omission to me not to have it in the top UI.
To the fancy js-er: It would also be nice to hint/tell the user about the limit right in the box. maybe something like
+-------------------------------------------------------------+--+ |type a username... (max 1)|?| +-------------------------------------------------------------+--+
macbook:phabricator chad$ arc unit --everything libpng warning: iCCP: known incorrect sRGB profile libpng warning: iCCP: known incorrect sRGB profile PASS 377ms PhabricatorLibraryTestCase::testLibraryMap PASS 743ms PhabricatorLibraryTestCase::testEverythingImplemented PASS 1.3s PhabricatorLibraryTestCase::testMethodVisibility PASS 9ms★ DifferentialAdjustmentMapTestCase::testNearestMaps PASS 5ms★ DifferentialAdjustmentMapTestCase::testBasicMaps PASS 4ms★ DifferentialAdjustmentMapTestCase::testInverseMaps PASS 2ms★ DifferentialAdjustmentMapTestCase::testChainMaps PASS 1ms★ DifferentialDiffTestCase::testDetectCopiedOverlaidCode PASS 38ms★ DifferentialDiffTestCase::testDetectSlowCopiedCode PASS 3ms★ DifferentialDiffTestCase::testDetectCopiedCode PASS <1ms★ DifferentialHunkTestCase::testMakeStructuredNewlineAbsent PASS <1ms★ DifferentialHunkTestCase::testMakeStructuredOffset PASS <1ms★ DifferentialHunkTestCase::testMakeStructuredChanges2 PASS <1ms★ DifferentialHunkTestCase::testMakeChanges PASS 1ms★ DifferentialHunkTestCase::testMakeStructuredChanges1 PASS 2ms★ DifferentialHunkTestCase::testMakeStructuredNewlineAdded PASS 1ms★ DifferentialHunkTestCase::testMakeStructuredNewlineRemoved PASS <1ms★ DiffusionURITestCase::testBlobDecodeFail PASS <1ms★ DiffusionURITestCase::testURIGeneration PASS <1ms★ DiffusionURITestCase::testBlobDecode PASS 2ms★ HeraldFieldTestCase::testGetAllFields PASS 2ms★ PhabricatorPHIDTypeTestCase::testGetPHIDTypeApplicationClass PASS <1ms★ PhabricatorPHIDTypeTestCase::testGetAllTypes PASS <1ms★ AlmanacNamesTestCase::testServiceOrDeviceNames PASS <1ms★ AlmanacServiceTypeTestCase::testGetAllServiceTypes PASS <1ms★ AphrontHTTPSinkTestCase::testHTTPSinkResponseSplitting PASS <1ms★ AphrontHTTPSinkTestCase::testHTTPSinkStatusCode PASS <1ms★ AphrontHTTPSinkTestCase::testHTTPSinkBasics PASS <1ms★ AphrontHTTPSinkTestCase::testJSONContentSniff PASS <1ms★ AphrontHTTPSinkTestCase::testHTTPHeaderNames PASS 6ms★ AphrontIsolatedDatabaseConnectionTestCase::testTransactionRollback PASS <1ms★ AphrontIsolatedDatabaseConnectionTestCase::testTransactionStack PASS <1ms★ AphrontIsolatedDatabaseConnectionTestCase::testIsolation PASS <1ms★ AphrontIsolatedDatabaseConnectionTestCase::testInsertGeneratesID PASS <1ms★ AphrontIsolatedDatabaseConnectionTestCase::testDeletePermitted PASS 3ms★ AphrontMySQLDatabaseConnectionTestCase::testConnectionFailures PASS 2ms★ AphrontRedirectResponseTestCase::testLocalRedirectURIs PASS <1ms★ AphrontRequestTestCase::testRequestDataAccess PASS <1ms★ AphrontRequestTestCase::testGetHTTPHeader PASS <1ms★ AphrontRequestTestCase::testHostAttacks PASS <1ms★ AphrontRequestTestCase::testFlattenRequestData PASS 2ms★ CalendarTimeUtilTestCase::testTimestampsStartDay PASS 1ms★ CalendarTimeUtilTestCase::testTimestampsAtMidnight PASS <1ms★ CelerityPhysicalResourcesTestCase::testGetAll PASS <1ms★ CelerityPostprocessorTestCase::testGetAllCelerityPostprocessors PASS 4ms★ CelerityResourceTransformerTestCase::testTransformation PASS 3ms★ ConduitAPIMethodTestCase::testLoadAllConduitMethods PASS <1ms★ ConduitCallTestCase::testConduitPing PASS <1ms★ ConduitCallTestCase::testConduitAuth PASS 157ms ConpherenceRoomTestCase::testAddMessageWithFileAttachments PASS 58ms ConpherenceRoomTestCase::testRoomParticipantDeletion PASS 35ms★ ConpherenceRoomTestCase::testNUserRoomCreate PASS 48ms★ ConpherenceRoomTestCase::testRoomParticipantAddition PASS 16ms★ ConpherenceRoomTestCase::testOneUserRoomCreate PASS 87ms DifferentialChangesetParserTestCase::testDiffChangesets PASS 3ms★ DifferentialCommitMessageParserTestCase::testDifferentialCommitMessageParser PASS <1ms★ DifferentialCommitMessageParserTestCase::testDifferentialCommitMessageParserNormalization PASS <1ms★ DifferentialCustomFieldDependsOnParserTestCase::testParser PASS <1ms★ DifferentialCustomFieldRevertsParserTestCase::testParser PASS <1ms★ DifferentialHunkParserTestCase::testInclusionOfOldFileInNewCommentFromStartWithContext PASS <1ms★ DifferentialHunkParserTestCase::testMultiLineNewComment PASS <1ms★ DifferentialHunkParserTestCase::testOverlapAfterEndOfHunk PASS <1ms★ DifferentialHunkParserTestCase::testInclusionOfOldFileInNewCommentFromStart PASS 2ms★ DifferentialHunkParserTestCase::testMissingContext PASS <1ms★ DifferentialHunkParserTestCase::testOneLineOldComment PASS <1ms★ DifferentialHunkParserTestCase::testOverlapFromStartOfHunk PASS <1ms★ DifferentialHunkParserTestCase::testMultiLineOldComment PASS <1ms★ DifferentialHunkParserTestCase::testOneLineNewComment PASS <1ms★ DifferentialHunkParserTestCase::testInclusionOfNewFileInOldCommentFromStartWithContext PASS <1ms★ DifferentialHunkParserTestCase::testCannotFindContext PASS <1ms★ DifferentialHunkParserTestCase::testNoNewlineAtEndOfFile PASS <1ms★ DifferentialHunkParserTestCase::testInclusionOfNewFileInOldCommentFromStart PASS 145ms DifferentialParseRenderTestCase::testParseRender PASS <1ms★ DiffusionCommitRemarkupRuleTestCase::testProjectObjectRemarkup PASS <1ms★ DiffusionGitBranchTestCase::testRemoteBranchParser PASS <1ms★ DiffusionGitFileContentQueryTestCase::testAuthorName PASS <1ms★ DiffusionLowLevelMercurialPathsQueryTests::testCommandByVersion PASS <1ms★ DiffusionMercurialWireProtocolTests::testFilteringBundle2Capability PASS 3ms★ DiffusionMercurialWireSSHTestCase::testMercurialClientWireProtocolParser PASS <1ms★ DiffusionPathQueryTestCase::testExpandEdgeCases PASS <1ms★ DiffusionPathQueryTestCase::testParentEdgeCases PASS <1ms★ DiffusionSubversionWireProtocolTestCase::testSubversionWireProtocolParser PASS <1ms★ DiffusionSubversionWireProtocolTestCase::testSubversionWireProtocolPartialFrame PASS <1ms★ DoorkeeperBridgeJIRATestCase::testJIRABridgeRestAPIURIConversion PASS <1ms★ DrydockBlueprintImplementationTestCase::testGetAllBlueprintImplementations PASS 102ms HarbormasterAutotargetsTestCase::testGenerateHarbormasterAutotargets PASS <1ms★ HarbormasterBuildStepImplementationTestCase::testGetImplementations PASS <1ms★ HeraldRuleTestCase::testHeraldRuleExecutionOrder PASS 1ms★ HeraldTranscriptTestCase::testTranscriptTruncation PASS <1ms★ LiskChunkTestCase::testSQLChunking PASS <1ms★ LiskDAOTestCase::testCheckProperty PASS 2ms★ LiskFixtureTestCase::testTransactionalIsolation1of2 PASS 5ms★ LiskFixtureTestCase::testReadableTransactions PASS 1ms★ LiskFixtureTestCase::testTransactionalIsolation2of2 PASS 2ms★ LiskFixtureTestCase::testFixturesBasicallyWork PASS 6ms★ LiskFixtureTestCase::testGarbageLoadCalls PASS 12ms★ LiskFixtureTestCase::testCounters PASS 3ms★ LiskFixtureTestCase::testNonmutableColumns PASS <1ms★ LiskIsolationTestCase::testEphemeral PASS <1ms★ LiskIsolationTestCase::testMagicMethods PASS <1ms★ LiskIsolationTestCase::testIsolatedWrites PASS <1ms★ LiskIsolationTestCase::testIsolationContainment PASS 1ms★ ManiphestCustomFieldStatusParserTestCase::testParser PASS <1ms★ ManiphestExcelFormatTestCase::testLoadAllFormats PASS 108ms ManiphestTaskStatusTestCase::testManiphestStatusConfigValidation PASS <1ms★ ManiphestTaskStatusTestCase::testManiphestStatusConstants PASS 227ms ManiphestTaskTestCase::testTaskReordering PASS 150ms ManiphestTaskTestCase::testTaskAdjacentBlocks PASS 1ms★ MetaMTAEmailTransactionCommandTestCase::testGetAllTypes PASS <1ms★ NuanceSourceDefinitionTestCase::testGetAllTypes PASS <1ms★ PHUIListViewTestCase::testAppendAfter PASS <1ms★ PHUIListViewTestCase::testAppend PASS <1ms★ PHUIListViewTestCase::testAppendLabel PASS <1ms★ PHUIListViewTestCase::testAppendBefore PASS <1ms★ PassphraseCredentialTypeTestCase::testGetAllTypes PASS 181ms PhabricatorAccessControlTestCase::testControllerAccessControls PASS <1ms★ PhabricatorAphrontViewTestCase::testHasChildren PASS <1ms★ PhabricatorApplicationConfigurationPanelTestCase::testLoadAllPanels PASS 1ms★ PhabricatorApplicationSearchEngineTestCase::testGetAllEngines PASS <1ms★ PhabricatorApplicationTestCase::testGetAllApplications PASS <1ms★ PhabricatorAuthFactorTestCase::testGetAllFactors PASS 8ms★ PhabricatorAuthInviteTestCase::testInvalidInvite PASS 438ms PhabricatorAuthInviteTestCase::testInviteWithKnownEmail PASS 19ms★ PhabricatorAuthInviteTestCase::testDuplicateInvite PASS 22ms★ PhabricatorAuthInviteTestCase::testInviteWithNewEmail PASS <1ms★ PhabricatorCachesTestCase::testRequestCache PASS 2ms★ PhabricatorCalendarHolidayTestCase::testNthBusinessDay PASS 188ms PhabricatorCelerityTestCase::testCelerityMaps PASS 6ms★ PhabricatorConduitTestCase::testConduitMethods PASS 9ms★ PhabricatorEdgeTestCase::testCycleDetection PASS <1ms★ PhabricatorEdgeTypeTestCase::testGetAllTypes PASS <1ms★ PhabricatorEnvTestCase::testOverrideOrder PASS <1ms★ PhabricatorEnvTestCase::testRemoteURIForLink PASS <1ms★ PhabricatorEnvTestCase::testDictionarySource PASS <1ms★ PhabricatorEnvTestCase::testStackSource PASS <1ms★ PhabricatorEnvTestCase::testOverrides PASS <1ms★ PhabricatorEnvTestCase::testLocalURIForLink PASS 6ms★ PhabricatorEnvTestCase::testRemoteURIForFetch PASS <1ms★ PhabricatorEnvTestCase::testGetEnvExceptions PASS <1ms★ PhabricatorFactEngineTestCase::testLoadAllEngines PASS <1ms★ PhabricatorFileStorageEngineTestCase::testLoadAllEngines PASS 46ms★ PhabricatorFileTestCase::testFileVisibility PASS 9ms★ PhabricatorFileTestCase::testFileStorageDelete PASS 5ms★ PhabricatorFileTestCase::testFileStorageReadWrite PASS 8ms★ PhabricatorFileTestCase::testFileStorageUploadDifferentFiles PASS 37ms★ PhabricatorFileTestCase::testFileTransformDelete PASS 6ms★ PhabricatorFileTestCase::testFileStorageUploadSameFile PASS 5ms★ PhabricatorFileTestCase::testReadWriteTtlFiles PASS 10ms★ PhabricatorFileTestCase::testFileStorageDeleteSharedHandle PASS <1ms★ PhabricatorFileTransformTestCase::testGetAllTransforms PASS 14ms★ PhabricatorHandlePoolTestCase::testHandlePools PASS <1ms★ PhabricatorHashTestCase::testHashForIndex PASS 1ms★ PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries PASS <1ms★ PhabricatorInfrastructureTestCase::testApplicationsInstalled PASS <1ms★ PhabricatorIteratedMD5PasswordHasherTestCase::testHasher PASS <1ms★ PhabricatorLocalTimeTestCase::testLocalTimeFormatting PASS <1ms★ PhabricatorLocaleScopeGuardTestCase::testLocaleScopeGuard PASS <1ms★ PhabricatorMailReceiverTestCase::testAddressSimilarity PASS <1ms★ PhabricatorMetaMTAEmailBodyParserTestCase::testFalsePositiveForOnWrote PASS <1ms★ PhabricatorMetaMTAEmailBodyParserTestCase::testQuotedTextStripping PASS 4ms★ PhabricatorMetaMTAEmailBodyParserTestCase::testEmailBodyCommandParsing PASS <1ms★ PhabricatorMetaMTAMailBodyTestCase::testBodyRender PASS <1ms★ PhabricatorMetaMTAMailBodyTestCase::testBodyRenderNoHerald PASS 30ms★ PhabricatorMetaMTAMailTestCase::testRecipients PASS 13ms★ PhabricatorMetaMTAMailTestCase::testThreadIDHeaders PASS 24ms★ PhabricatorMetaMTAMailTestCase::testMailSendFailures PASS 3ms★ PhabricatorMetaMTAReceivedMailTestCase::testDropSelfMail PASS 13ms★ PhabricatorMetaMTAReceivedMailTestCase::testDropUnknownSenderMail PASS 21ms★ PhabricatorMetaMTAReceivedMailTestCase::testDropDisabledSenderMail PASS 6ms★ PhabricatorMetaMTAReceivedMailTestCase::testDropUnreceivableMail PASS 6ms★ PhabricatorMetaMTAReceivedMailTestCase::testDropDuplicateMail PASS 2ms★ PhabricatorOAuthServerTestCase::testValidateSecondaryRedirectURI PASS <1ms★ PhabricatorOAuthServerTestCase::testValidateRedirectURI PASS 15ms★ PhabricatorObjectListQueryTestCase::testObjectListQuery PASS 58ms PhabricatorObjectMailReceiverTestCase::testDropInvalidObjectMail PASS 62ms PhabricatorObjectMailReceiverTestCase::testDropUnconfiguredPublicMail PASS 61ms PhabricatorObjectMailReceiverTestCase::testDropHashMismatchMail PASS 58ms PhabricatorObjectMailReceiverTestCase::testDropUserMismatchMail PASS <1ms★ PhabricatorOwnersPackageTestCase::testFindLongestPathsPerPackage PASS <1ms★ PhabricatorPasswordHasherTestCase::testHasherSyntax PASS <1ms★ PhabricatorPasswordHasherTestCase::testGetAllHashers PASS <1ms★ PhabricatorPolicyCapabilityTestCase::testGetCapabilityMap PASS 14ms★ PhabricatorPolicyDataTestCase::testObjectPolicyRuleTaskAuthor PASS 17ms★ PhabricatorPolicyDataTestCase::testCustomPolicyRuleLunarPhase PASS 25ms★ PhabricatorPolicyDataTestCase::testCustomPolicyRuleUser PASS 25ms★ PhabricatorPolicyDataTestCase::testCustomPolicyRuleAdministrators PASS 18ms★ PhabricatorPolicyDataTestCase::testProjectPolicyMembership PASS 15ms★ PhabricatorPolicyDataTestCase::testObjectPolicyRuleThreadMembers PASS 12ms★ PhabricatorPolicyDataTestCase::testObjectPolicyRuleSubscribers PASS <1ms★ PhabricatorPolicyTestCase::testUsersPolicy PASS <1ms★ PhabricatorPolicyTestCase::testOmnipotence PASS <1ms★ PhabricatorPolicyTestCase::testNoOnePolicy PASS <1ms★ PhabricatorPolicyTestCase::testPolicyStrength PASS 2ms★ PhabricatorPolicyTestCase::testExtendedPolicyCycles PASS <1ms★ PhabricatorPolicyTestCase::testMultipleCapabilities PASS <1ms★ PhabricatorPolicyTestCase::testPublicPolicyDisabled PASS <1ms★ PhabricatorPolicyTestCase::testPublicPolicyEnabled PASS <1ms★ PhabricatorPolicyTestCase::testAdminPolicy PASS 2ms★ PhabricatorPolicyTestCase::testExtendedPolicies PASS 8ms★ PhabricatorPolicyTestCase::testAllQueriesBelongToActualApplications PASS 1ms★ PhabricatorPolicyTestCase::testOffsets PASS 2ms★ PhabricatorPolicyTestCase::testRejectInvalidPolicy PASS <1ms★ PhabricatorPolicyTestCase::testLimits PASS <1ms★ PhabricatorPolicyTestCase::testInvalidPolicyVisibleByOmnipotentUser PASS 166ms PhabricatorProjectEditorTestCase::testJoinLeaveProject PASS 37ms★ PhabricatorProjectEditorTestCase::testViewProject PASS 47ms★ PhabricatorProjectEditorTestCase::testEditProject PASS <1ms★ PhabricatorQueryOrderTestCase::testQueryOrderItem PASS <1ms★ PhabricatorQueryOrderTestCase::testQueryOrderVector PASS <1ms★ PhabricatorQueryOrderTestCase::testQueryOrderBadVectors PASS <1ms★ PhabricatorRepositoryTestCase::testSubversionPathInfo PASS <1ms★ PhabricatorRepositoryTestCase::testBranchFilter PASS <1ms★ PhabricatorRepositoryTestCase::testRepositoryURIProtocols PASS <1ms★ PhabricatorRepositoryTestCase::testFilterMercurialDebugOutput PASS <1ms★ PhabricatorRepositoryURINormalizerTestCase::testGitURINormalizer PASS <1ms★ PhabricatorRepositoryURINormalizerTestCase::testSVNURINormalizer PASS 15ms★ PhabricatorRepositoryURITestCase::testURIGeneration PASS <1ms★ PhabricatorSearchEngineTestCase::testLoadAllEngines PASS <1ms★ PhabricatorSetupCheckTestCase::testLoadAllChecks PASS 1ms★ PhabricatorSlugTestCase::testSlugNormalization PASS <1ms★ PhabricatorSlugTestCase::testProjectSlugs PASS <1ms★ PhabricatorSlugTestCase::testSlugDepth PASS <1ms★ PhabricatorSlugTestCase::testSlugAncestry PASS 53ms PhabricatorSpacesTestCase::testSpacesAnnihilation PASS 20ms★ PhabricatorSpacesTestCase::testSpacesUniqueDefaultSpace PASS 35ms★ PhabricatorSpacesTestCase::testSpacesPolicyFiltering PASS 9ms★ PhabricatorSpacesTestCase::testSpacesRequireNames PASS 24ms★ PhabricatorSpacesTestCase::testSpacesSeveralSpaces PASS 1ms★ PhabricatorTOTPAuthFactorTestCase::testTOTPCodeGeneration PASS <1ms★ PhabricatorTimeTestCase::testPhabricatorTimeStack PASS 1ms★ PhabricatorTimeTestCase::testParseLocalTime PASS 3ms★ PhabricatorTriggerClockTestCase::testSubscriptionTriggerClock PASS 1ms★ PhabricatorTriggerClockTestCase::testDailyRoutineTriggerClockDaylightSavings PASS 1ms★ PhabricatorTriggerClockTestCase::testDailyRoutineTriggerClockLeapSecond PASS 2ms★ PhabricatorTriggerClockTestCase::testCDailyRoutineTriggerClockAdjustTimeOfDay PASS <1ms★ PhabricatorTriggerClockTestCase::testNeverTriggerClock PASS <1ms★ PhabricatorTriggerClockTestCase::testOneTimeTriggerClock PASS <1ms★ PhabricatorTrivialTestCase::testAllIsRightWithTheWorld PASS <1ms★ PhabricatorUnitsTestCase::testByteFormatting PASS <1ms★ PhabricatorUnitsTestCase::testByteParsing PASS <1ms★ PhabricatorUnitsTestCase::testDetailedDurationFormatting PASS <1ms★ PhabricatorUserEditorTestCase::testRegistrationEmailDomain PASS 10ms★ PhabricatorUserEditorTestCase::testRegistrationEmailApplicationEmailCollide PASS 7ms★ PhabricatorUserEditorTestCase::testRegistrationEmailOK PASS <1ms★ PhabricatorUserEditorTestCase::testRegistrationEmailInvalid PASS <1ms★ PhabricatorUserEmailTestCase::testEmailValidation PASS <1ms★ PhabricatorUserTestCase::testUsernameValidation PASS <1ms★ PhabricatorWorkerBulkJobTestCase::testGetAllBulkJobTypes PASS 15ms★ PhabricatorWorkerTestCase::testTooManyTaskFailures PASS 9ms★ PhabricatorWorkerTestCase::testLeasedIsOldestFirst PASS 5ms★ PhabricatorWorkerTestCase::testPermanentTaskFailure PASS 4ms★ PhabricatorWorkerTestCase::testLeaseTask PASS 5ms★ PhabricatorWorkerTestCase::testExecuteTask PASS 10ms★ PhabricatorWorkerTestCase::testLeasedIsLowestPriority PASS 8ms★ PhabricatorWorkerTestCase::testNewBeforeLeased PASS 8ms★ PhabricatorWorkerTestCase::testOldestFirst PASS 6ms★ PhabricatorWorkerTestCase::testRequiredLeaseTime PASS 5ms★ PhabricatorWorkerTestCase::testTemporaryTaskFailure PASS 6ms★ PhabricatorWorkerTestCase::testWaitBeforeRetry PASS 5ms★ PhabricatorWorkerTestCase::testMultipleLease PASS 737ms PhabricatorChangeParserTestCase::testSubversionForeignStubsParser PASS 2.4s PhabricatorChangeParserTestCase::testSubversionParser PASS 514ms PhabricatorChangeParserTestCase::testSubversionPartialParser PASS 427ms PhabricatorChangeParserTestCase::testGitParser PASS 2.4s PhabricatorChangeParserTestCase::testMercurialParser PASS 353ms PhabricatorChangeParserTestCase::testSubversionValidRootParser PASS 178ms PhabricatorWorkingCopyDiscoveryTestCase::testGitCommitDiscovery PASS 679ms PhabricatorWorkingCopyDiscoveryTestCase::testMercurialCommitDiscovery PASS 281ms PhabricatorWorkingCopyDiscoveryTestCase::testSubversionCommitDiscovery PASS 79ms PhabricatorWorkingCopyPullTestCase::testGitPullBasic PASS 38ms★ PhabricatorWorkingCopyPullTestCase::testSVNPullBasic PASS 267ms PhabricatorWorkingCopyPullTestCase::testHgPullBasic PASS <1ms★ PhortuneCurrencyTestCase::testInvalidCurrencyFromString PASS <1ms★ PhortuneCurrencyTestCase::testCurrencyFormatBareValue PASS <1ms★ PhortuneCurrencyTestCase::testCurrencyFormatForDisplay PASS <1ms★ PhortuneCurrencyTestCase::testAddCurrency PASS <1ms★ PhortuneCurrencyTestCase::testCurrencyRanges PASS <1ms★ PhortuneCurrencyTestCase::testCurrencyFromString PASS <1ms★ PhortunePaymentProviderTestCase::testGetAllProviders PASS <1ms★ PhrequentTimeBlockTestCase::testEndDeeperStratum PASS <1ms★ PhrequentTimeBlockTestCase::testPreemptingEvents PASS <1ms★ PhrequentTimeBlockTestCase::testTimelineSort PASS <1ms★ PhrequentTimeBlockTestCase::testPopAcrossStrata PASS <1ms★ PhrequentTimeBlockTestCase::testOngoingInterrupted PASS <1ms★ PhrequentTimeBlockTestCase::testSumTimeSlices PASS <1ms★ PhrequentTimeBlockTestCase::testOngoingPreempted PASS <1ms★ PhrequentTimeBlockTestCase::testInstantaneousEvent PASS <1ms★ PhrequentTimeBlockTestCase::testMergeTimeRanges PASS <1ms★ PhrequentTimeBlockTestCase::testOngoing PASS <1ms★ ProjectRemarkupRuleTestCase::testProjectObjectRemarkup PASS <1ms★ QueryFormattingTestCase::testQueryFormatting
where is your database?
I'm just going to merge this into T5867
Phabricator is a tool for productivity, and is expressly designed as such. We'd have major concerns littering the interface with tips for day 1 users when they are disruptive every day after.
(I'm pretty sure this is us, but want to be sure)
Yes, of course. I apologise. We updated to head today.
@mikn The question remains, what version of Phabricator are you on. This install is not kept at HEAD.
The repro case is against this install. :)
Is your server up-to-date? What versions is it running? https://secure.phabricator.com/book/phabcontrib/article/bug_reports/#update-phabricator
T5000 is the task your looking for, though using plain git over arcanist is definitely a step backwards for productivity and code quality. Lint and emitting patches alone saves me 10-15 minutes a day.
For example: At rP9f2fc7f93834a142028ee7385d564120b0eaf58a you specified the reviewers, suscriber, the test plan and summary. It would be great for people, who don't use arcanist normaly, to create a diff by push a commit with informations like this (with a command "Create revision" etc.). A kind of post review: If the review is completed, the branch gets merged (by a user), and it is more confortable then audit, I think, because you can easily add a new patch, and don't need to audit each patch.
What does "create a revision by a specific commit message" mean you to?
What specifically are you trying to accomplish? Your question and follow up explanation are a bit confusing for me to understand.
Sorry, what I mean was that: https://secure.phabricator.com/differential/revision/closedetails/PHID-XACT-DREV-abkyxu2ed6j4nsg/
OS - Arch Linux
Understood.
In T9766#144249, @eadler wrote:A somewhat generic way to do this is to create the notion of a variable such as is_in_deployment and allow Herald rules to check to see if this is set/true/a specific value. If the API to expose the variable is exposed to conduit then also allows for far more interesting workflows (especially when combined with relying on other Herald rules).
Is there a specific security purpose behind this? That is, what attack is this measure aimed at defusing?