Page MenuHomePhabricator
Feed All Stories

Mar 15 2021

epriestley committed rP30d58de1bc22: Expose "affectedPaths" to "differential.revision.search" Conduit API method (authored by epriestley).
Expose "affectedPaths" to "differential.revision.search" Conduit API method
Mar 15 2021, 11:16 PM
epriestley closed D21618: Update "AffectedPath" table when a revision's repository changes.
Mar 15 2021, 11:16 PM
epriestley committed rP6d33ba7dc401: Move Diffusion to "withPaths()" for "Recent Open Revisions", and remove… (authored by epriestley).
Move Diffusion to "withPaths()" for "Recent Open Revisions", and remove…
Mar 15 2021, 11:16 PM
epriestley committed rP01ea84029d88: Update table schema for "AffectedPath" table (authored by epriestley).
Update table schema for "AffectedPath" table
Mar 15 2021, 11:16 PM
epriestley closed D21621: Expose "affectedPaths" to "differential.revision.search" Conduit API method.
Mar 15 2021, 11:16 PM
epriestley closed D21619: Support a "withPaths()" API in DifferentialRevisionQuery, and use it on the revision view.
Mar 15 2021, 11:16 PM
epriestley committed rP38ef910da8ca: Move "Affected Path" index updates to a separate class (authored by epriestley).
Move "Affected Path" index updates to a separate class
Mar 15 2021, 11:16 PM
epriestley closed D21617: Update table schema for "AffectedPath" table.
Mar 15 2021, 11:16 PM
epriestley closed D21620: Move Diffusion to "withPaths()" for "Recent Open Revisions", and remove "withPath()" from DifferentialRevisionQuery.
Mar 15 2021, 11:16 PM
epriestley committed rPe919b4c35a2a: Add a debug view of the "Affected Path" index to Differential (authored by epriestley).
Add a debug view of the "Affected Path" index to Differential
Mar 15 2021, 11:16 PM
epriestley closed D21616: Move "Affected Path" index updates to a separate class.
Mar 15 2021, 11:16 PM
epriestley committed rPe730f55e8857: Retitle "Recently Open Revisions" panel to "Recent Open Revisions" (authored by epriestley).
Retitle "Recently Open Revisions" panel to "Recent Open Revisions"
Mar 15 2021, 11:16 PM
epriestley closed D21615: Add a debug view of the "Affected Path" index to Differential.
Mar 15 2021, 11:16 PM
epriestley committed rPc317d16bdd56: Lift peculiar side effect of path indexing out of indexer (authored by epriestley).
Lift peculiar side effect of path indexing out of indexer
Mar 15 2021, 11:16 PM
epriestley committed rPbcd592cf7e15: Remove support for "paths" parameter in "differential.query" (authored by epriestley).
Remove support for "paths" parameter in "differential.query"
Mar 15 2021, 11:16 PM
epriestley closed D21613: Remove support for "paths" parameter in "differential.query".
Mar 15 2021, 11:16 PM
epriestley closed D21612: Retitle "Recently Open Revisions" panel to "Recent Open Revisions".
Mar 15 2021, 11:16 PM
epriestley closed D21614: Lift peculiar side effect of path indexing out of indexer.
Mar 15 2021, 11:16 PM
epriestley updated the task description for T13639: Allow revisions to be queried by affected path via the API.
Mar 15 2021, 11:13 PM · Conduit, Differential
epriestley updated the task description for T13639: Allow revisions to be queried by affected path via the API.
Mar 15 2021, 11:12 PM · Conduit, Differential
epriestley updated the task description for T13639: Allow revisions to be queried by affected path via the API.
Mar 15 2021, 11:12 PM · Conduit, Differential
epriestley requested review of D21621: Expose "affectedPaths" to "differential.revision.search" Conduit API method.
Mar 15 2021, 11:03 PM
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21621: Expose "affectedPaths" to "differential.revision.search" Conduit API method.
Mar 15 2021, 11:02 PM · Conduit, Differential
epriestley requested review of D21620: Move Diffusion to "withPaths()" for "Recent Open Revisions", and remove "withPath()" from DifferentialRevisionQuery.
Mar 15 2021, 10:58 PM
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21620: Move Diffusion to "withPaths()" for "Recent Open Revisions", and remove "withPath()" from DifferentialRevisionQuery.
Mar 15 2021, 10:57 PM · Conduit, Differential
epriestley requested review of D21619: Support a "withPaths()" API in DifferentialRevisionQuery, and use it on the revision view.
Mar 15 2021, 10:53 PM
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21619: Support a "withPaths()" API in DifferentialRevisionQuery, and use it on the revision view.
Mar 15 2021, 10:52 PM · Conduit, Differential
epriestley requested review of D21618: Update "AffectedPath" table when a revision's repository changes.
Mar 15 2021, 10:48 PM
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21618: Update "AffectedPath" table when a revision's repository changes.
Mar 15 2021, 10:47 PM · Conduit, Differential
epriestley requested review of D21617: Update table schema for "AffectedPath" table.
Mar 15 2021, 10:38 PM
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21617: Update table schema for "AffectedPath" table.
Mar 15 2021, 10:37 PM · Conduit, Differential
epriestley requested review of D21616: Move "Affected Path" index updates to a separate class.
Mar 15 2021, 9:00 PM
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21616: Move "Affected Path" index updates to a separate class.
Mar 15 2021, 8:59 PM · Conduit, Differential
epriestley requested review of D21615: Add a debug view of the "Affected Path" index to Differential.
Mar 15 2021, 8:45 PM
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21615: Add a debug view of the "Affected Path" index to Differential.
Mar 15 2021, 8:44 PM · Conduit, Differential
epriestley added a comment to D21614: Lift peculiar side effect of path indexing out of indexer.

After this change, we always execute this code for any update. This is sort-of a functional change, but likely moot or moot-adjacent in practice. Previously:

Mar 15 2021, 5:53 PM
epriestley requested review of D21614: Lift peculiar side effect of path indexing out of indexer.
Mar 15 2021, 5:51 PM
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21614: Lift peculiar side effect of path indexing out of indexer.
Mar 15 2021, 5:50 PM · Conduit, Differential
epriestley closed T4401: Linking to lines in a diff as Wontfix.

(Internally, see PHI2020.)

Mar 15 2021, 5:30 PM · Differential
epriestley added a comment to T10219: Show suggested lint autofix in Differential web view.

This is relatively ripe for implementation now that inline comments support suggested edits.

Mar 15 2021, 5:15 PM · Lint, Differential
epriestley removed projects from T10219: Show suggested lint autofix in Differential web view: Restricted Project, Feature Request.
Mar 15 2021, 5:15 PM · Lint, Differential
epriestley closed T11608: Make it easier to review stacks of diffs as Wontfix.

This is very old, fairly vague, and doesn't have any clear modern customer interest. I'm open to implementing it, but would like a more clear/modern customer request before pursuing it.

Mar 15 2021, 5:14 PM · Restricted Project, Differential, Feature Request
epriestley moved T7333: Empty commits get same revision as parent from Backlog to Next on the Differential board.
Mar 15 2021, 5:11 PM · Differential
epriestley moved T13105: Plans: Rich presentation and diff rendering pipelines for various file types from Backlog to Next on the Differential board.
Mar 15 2021, 5:11 PM · Plans, Files, Differential, Diffusion
epriestley moved T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions from Backlog to Next on the Differential board.
Mar 15 2021, 5:11 PM · Plans, Differential
epriestley moved T13161: Plans: Improve Differential diff display behaviors from Backlog to Next on the Differential board.
Mar 15 2021, 5:11 PM · Differential, Plans
epriestley moved T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits" from Backlog to Next on the Differential board.
Mar 15 2021, 5:10 PM · Diffusion, Differential
epriestley moved T13425: Support diffs between abstract block lists in the UI from Backlog to Next on the Differential board.
Mar 15 2021, 5:10 PM · Differential
epriestley moved T13513: Make schema changes to inlines to prepare for new inline features from Backlog to Next on the Differential board.
Mar 15 2021, 5:10 PM · Inline Comments, Diffusion, Differential
epriestley moved T13520: Update the diff table of contents for moved files, long paths, etc from Backlog to Next on the Differential board.
Mar 15 2021, 5:09 PM · Differential
epriestley moved T13534: Inline Comment errata after editing persistence from Backlog to Next on the Differential board.
Mar 15 2021, 5:09 PM · Differential
epriestley moved T13515: Differential: Inlines and View Options from Backlog to Next on the Differential board.
Mar 15 2021, 5:09 PM · Differential
epriestley moved T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch from Backlog to Next on the Differential board.
Mar 15 2021, 5:08 PM · Differential
epriestley moved T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting from Backlog to Next on the Differential board.
Mar 15 2021, 5:08 PM · Accessibility, Differential
epriestley moved T13639: Allow revisions to be queried by affected path via the API from Backlog to Next on the Differential board.
Mar 15 2021, 5:07 PM · Conduit, Differential
epriestley requested review of D21613: Remove support for "paths" parameter in "differential.query".
Mar 15 2021, 4:39 PM

Mar 14 2021

epriestley requested review of D21612: Retitle "Recently Open Revisions" panel to "Recent Open Revisions".
Mar 14 2021, 8:03 PM
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21612: Retitle "Recently Open Revisions" panel to "Recent Open Revisions".
Mar 14 2021, 8:02 PM · Conduit, Differential
epriestley added a comment to T13639: Allow revisions to be queried by affected path via the API.

I'm likely to break the paths constraint for frozen API method differential.query. This was added by D2788 as a Facebook-specific patch with no rationale that I can dig up, and the author didn't have any related changes from around that time.

Mar 14 2021, 7:54 PM · Conduit, Differential
epriestley triaged T13639: Allow revisions to be queried by affected path via the API as Wishlist priority.
Mar 14 2021, 7:50 PM · Conduit, Differential

Mar 13 2021

epriestley updated the task description for T13630: Move Phacility provisioning to Piledriver.
Mar 13 2021, 6:48 PM · Almanac, Infrastructure, Phacility
epriestley closed T11013: "Unknown Object" when attempting to create a new Almanac network as Resolved.

This is very old and I can't reproduce it, and haven't seen any other reports.

Mar 13 2021, 6:31 PM · Almanac, Bug Report
epriestley updated the task description for T13630: Move Phacility provisioning to Piledriver.
Mar 13 2021, 6:30 PM · Almanac, Infrastructure, Phacility
epriestley triaged T13638: Investigate "AllowEncodedSlashes" Apache setting as Wishlist priority.
Mar 13 2021, 5:40 PM · Setup
epriestley edited the content of Changelog.
Mar 13 2021, 5:50 AM
epriestley committed rARC5d9e971ab0e0: (stable) Promote 2021 Week 11 (authored by epriestley).
(stable) Promote 2021 Week 11
Mar 13 2021, 5:49 AM
epriestley committed rPe7d3bae2cc3f: (stable) Promote 2021 Week 11 (authored by epriestley).
(stable) Promote 2021 Week 11
Mar 13 2021, 5:49 AM
epriestley created an object: 2021 Week 11 (Mid March).
Mar 13 2021, 5:49 AM

Mar 12 2021

cspeckmim awarded T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers a Like token.
Mar 12 2021, 10:29 PM · Policy, Differential
epriestley added a comment to T13637: PHP Static Method Variable Scope.

I think lint could reasonably emit two warnings about this:

Mar 12 2021, 7:36 PM · Lint, Guides
epriestley triaged T13637: PHP Static Method Variable Scope as Wishlist priority.
Mar 12 2021, 7:32 PM · Lint, Guides
epriestley closed D21611: Correct a mistaken Phurl link in the "missing symbol" exception.
Mar 12 2021, 5:51 PM
epriestley committed rARC7ad4afb9190b: Correct a mistaken Phurl link in the "missing symbol" exception (authored by epriestley).
Correct a mistaken Phurl link in the "missing symbol" exception
Mar 12 2021, 5:51 PM
epriestley requested review of D21611: Correct a mistaken Phurl link in the "missing symbol" exception.
Mar 12 2021, 5:47 PM
epriestley closed T13631: Support an "auditors" attachment for "diffusion.commit.search" as Resolved.

For now, I fixed the explicit misinformation in audit.can-author-close-audit, at least.

Mar 12 2021, 5:27 PM · Diffusion
epriestley committed rPb11c6fcacd8b: Clarify the behavior of "audit.can-author-close-audit" (authored by epriestley).
Clarify the behavior of "audit.can-author-close-audit"
Mar 12 2021, 5:20 PM
epriestley closed D21610: Clarify the behavior of "audit.can-author-close-audit".
Mar 12 2021, 5:20 PM
epriestley requested review of D21610: Clarify the behavior of "audit.can-author-close-audit".
Mar 12 2021, 5:14 PM
epriestley added a revision to T13631: Support an "auditors" attachment for "diffusion.commit.search": D21610: Clarify the behavior of "audit.can-author-close-audit".
Mar 12 2021, 5:13 PM · Diffusion
epriestley committed rP4b529e600928: Fix a followup notification paging error with partial objects (authored by epriestley).
Fix a followup notification paging error with partial objects
Mar 12 2021, 5:09 PM
epriestley closed D21609: Fix a followup notification paging error with partial objects.
Mar 12 2021, 5:09 PM
epriestley requested review of D21609: Fix a followup notification paging error with partial objects.
Mar 12 2021, 5:09 PM
epriestley added a revision to T13623: Notifications may fail to paginate with GROUP BY error: D21609: Fix a followup notification paging error with partial objects.
Mar 12 2021, 5:08 PM · Restricted Project, Notifications

Mar 11 2021

epriestley committed rP32da29b96569: Provide more help around GRANT errors, particularly for missing TEMPORARY TABLE… (authored by epriestley).
Provide more help around GRANT errors, particularly for missing TEMPORARY TABLE…
Mar 11 2021, 10:55 PM
epriestley closed D21608: Provide more help around GRANT errors, particularly for missing TEMPORARY TABLE permission.
Mar 11 2021, 10:55 PM
epriestley closed T13622: Make "bin/storage upgrade" deal with GRANT issues more gracefully as Resolved by committing rP32da29b96569: Provide more help around GRANT errors, particularly for missing TEMPORARY TABLE….
Mar 11 2021, 10:55 PM · Installing & Upgrading, Database
epriestley requested review of D21608: Provide more help around GRANT errors, particularly for missing TEMPORARY TABLE permission.
Mar 11 2021, 10:33 PM
epriestley added a revision to T13622: Make "bin/storage upgrade" deal with GRANT issues more gracefully: D21608: Provide more help around GRANT errors, particularly for missing TEMPORARY TABLE permission.
Mar 11 2021, 10:32 PM · Installing & Upgrading, Database
epriestley added a comment to T13622: Make "bin/storage upgrade" deal with GRANT issues more gracefully.

There are also already a bunch of tailored messages in other context:

Mar 11 2021, 10:30 PM · Installing & Upgrading, Database
epriestley added a comment to T13622: Make "bin/storage upgrade" deal with GRANT issues more gracefully.

I looked into this briefly, but I can't find a simple way to show all the current user's database permissions.

Mar 11 2021, 10:14 PM · Installing & Upgrading, Database
epriestley added a comment to T12919: Healthcheck endpoint for alternate file domain.

Resource (and Phame and Phurl) domains now respond to /status/.

Mar 11 2021, 10:06 PM · Files
epriestley committed rP31c9d4094fa5: Improve routing of "/robots.txt", "/favicon.ico", and "/status/" on Short and… (authored by epriestley).
Improve routing of "/robots.txt", "/favicon.ico", and "/status/" on Short and…
Mar 11 2021, 10:05 PM
epriestley closed D21606: Improve routing of "/robots.txt", "/favicon.ico", "/status/", and 404 on custom Sites.
Mar 11 2021, 10:05 PM
epriestley closed D21607: Improve routing of "/robots.txt", "/favicon.ico", and "/status/" on Short and Blog sites.
Mar 11 2021, 10:05 PM
epriestley committed rP36c6eb966393: Improve routing of "/robots.txt", "/favicon.ico", "/status/", and 404 on custom… (authored by epriestley).
Improve routing of "/robots.txt", "/favicon.ico", "/status/", and 404 on custom…
Mar 11 2021, 10:05 PM
epriestley closed T12919: Healthcheck endpoint for alternate file domain, a subtask of T13636: Some "well-known" resources can't be served from ResourceSite, as Resolved.
Mar 11 2021, 10:05 PM · Infrastructure
epriestley closed T12919: Healthcheck endpoint for alternate file domain as Resolved by committing rP36c6eb966393: Improve routing of "/robots.txt", "/favicon.ico", "/status/", and 404 on custom….
Mar 11 2021, 10:05 PM · Files
epriestley closed T13636: Some "well-known" resources can't be served from ResourceSite as Resolved by committing rP36c6eb966393: Improve routing of "/robots.txt", "/favicon.ico", "/status/", and 404 on custom….
Mar 11 2021, 10:05 PM · Infrastructure
epriestley requested review of D21607: Improve routing of "/robots.txt", "/favicon.ico", and "/status/" on Short and Blog sites.
Mar 11 2021, 10:05 PM
epriestley added a revision to T13636: Some "well-known" resources can't be served from ResourceSite: D21607: Improve routing of "/robots.txt", "/favicon.ico", and "/status/" on Short and Blog sites.
Mar 11 2021, 10:04 PM · Infrastructure