Page MenuHomePhabricator
Differential D21617

Update table schema for "AffectedPath" table
ClosedPublic
Actions

Authored by epriestley on Mar 15 2021, 10:37 PM.
Tags
None
Referenced Files
F18106431: D21617.id51464.diff
Sun, Aug 10, 10:40 PM
F18105814: D21617.id51453.diff
Sun, Aug 10, 7:51 PM
F18102010: D21617.id.diff
Sat, Aug 9, 5:29 PM
F18095849: D21617.diff
Fri, Aug 8, 2:49 AM
F18083661: D21617.id51464.diff
Tue, Aug 5, 11:00 AM
F17945472: D21617.diff
Thu, Jul 31, 12:13 PM
F17712102: D21617.diff
Jul 17 2025, 9:24 AM
F17687362: D21617.diff
Jul 14 2025, 7:16 AM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13639: Allow revisions to be queried by affected path via the API
Commits
rP01ea84029d88: Update table schema for "AffectedPath" table
Summary

Ref T13639. Make schema changes:

  • Make repositoryID nullable, for revisions with no repository.
  • Remove "epoch", which has no readers and no clear use.
  • Change the ordering of the key, since "pathID" has more unique values and no queries ever issue without it.
Test Plan
  • Ran bin/storage upgrade, got a clean schema.
  • Reindexed all revisions with an external script.
  • Reviewed index via debug UI, saw appropriate index for non-repositoy revisions.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 15 2021, 10:37 PM
Owners added a subscriber: Restricted Owners Package.Mar 15 2021, 10:37 PM
Harbormaster completed remote builds in B25261: Diff 51453.Mar 15 2021, 10:38 PM
epriestley requested review of this revision.Mar 15 2021, 10:38 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 15 2021, 11:16 PM
Closed by commit rP01ea84029d88: Update table schema for "AffectedPath" table (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP01ea84029d88: Update table schema for "AffectedPath" table.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
2 lines
src/
applications/
differential/
engine/
7 lines
storage/
8 lines

Diff 51464

View Options

resources/sql/autopatches/20210315.affectedpath.01.epoch.sql

Loading...
View Options

resources/sql/autopatches/20210315.affectedpath.02.repositoryid.sql

Loading...
View Options

src/applications/differential/engine/DifferentialAffectedPathEngine.php

Loading...
View Options

src/applications/differential/storage/DifferentialAffectedPath.php

Loading...
Phabricator · Built by Phacility