Page MenuHomePhabricator

Lift peculiar side effect of path indexing out of indexer
ClosedPublic

Authored by epriestley on Mar 15 2021, 5:50 PM.

Details

Summary

Ref T13639. Updating the affected path table has a peculiar side effect from D19426, which is a simplification of a peculiar side effect from earlier.

Don't condition Owners behavior on path index behavior.

Test Plan

Created a revision.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

After this change, we always execute this code for any update. This is sort-of a functional change, but likely moot or moot-adjacent in practice. Previously:

  • We'd reach this code only if the revision belonged to a repository. However, the reader of these properties checks for a repository anyway so this should be moot.
  • We'd previously reach this code only if the change included changesets, but it's very unusual for a change to not have changesets and there are some other outstanding issues related to empty diffs, so I'll just let that sort out in the wash.
This revision was not accepted when it landed; it landed in state Needs Review.Mar 15 2021, 11:16 PM
This revision was automatically updated to reflect the committed changes.