Page MenuHomePhabricator

Provide more help around GRANT errors, particularly for missing TEMPORARY TABLE permission
ClosedPublic

Authored by epriestley on Mar 11 2021, 10:32 PM.

Details

Summary

Fixes T13622. Figuring out what permissions we have seems difficult, so address this a bit more narrowly:

  • Make the "access denied" error message a bit more helpful.
  • Tailor error handling for the "CREATE TEMPORARY TABLE" statement.
Test Plan
  • Created a new user, granted them "SELECT ON *.*" but not "CREATE TEMPORARY TABLE", ran bin/storage upgrade --force --apply phabricator:20210215.changeset.02.phid-populate.php.
  • Before: fairly opaque error.
  • After: fairly useful error.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Mar 11 2021, 10:32 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 11 2021, 10:55 PM
This revision was automatically updated to reflect the committed changes.