Page MenuHomePhabricator

Some "well-known" resources can't be served from ResourceSite
Closed, ResolvedPublic

Description

See https://discourse.phabricator-community.org/t/robots-txt-triggers-exception-on-alternate-domains/4637.

The ResourceSite doesn't currently route robots.txt, favicon.ico, or /status/. It probably should route at least some of these paths.

It's not entirely clear if we should route /status/, but T12919 wants it.

We should probably route /robots.txt, but perhaps prevent it from accessing anything?

We could route favicon.ico normally.

Event Timeline

We should probably route /robots.txt, but perhaps prevent it from accessing anything?

I'm just disallowing everything on resource domains. I can't come up with any really good use case for indexing resource content, and URIs are all versioned (and/or secret) and unstable anyway.

A related issue is that if you 404 on the ResourceSite, you hit a cookie exception. This isn't ideal.

This leaves some edge cases doing less-than-ideal things:

  • BlogSite (Phame) doesn't route any of this stuff, but none of it seems to do anything "obviously bad".
  • ShortSite (Phurl) is the same deal as BlogSite.

(Or, rather, BlogSite and ShortSite both deal with 404s in a sensible way. They just don't route "/robots.txt", "/favicon.ico", or "/status/".)