Page MenuHomePhabricator
Feed All Stories

Jul 31 2019

epriestley requested review of D20691: Document support for "limit" in tokenizer-based Custom Fields.
Jul 31 2019, 8:03 PM
epriestley added a revision to T13356: Support a "limit" configuration option for tokenizer-based custom fields: D20691: Document support for "limit" in tokenizer-based Custom Fields.
Jul 31 2019, 8:02 PM · Custom Fields
epriestley added a comment to T13356: Support a "limit" configuration option for tokenizer-based custom fields.

This is likely straightforward.

Jul 31 2019, 7:55 PM · Custom Fields
epriestley triaged T13356: Support a "limit" configuration option for tokenizer-based custom fields as Low priority.
Jul 31 2019, 7:51 PM · Custom Fields
epriestley requested review of D20690: Support "date" custom fields in "*.edit" endpoints.
Jul 31 2019, 7:50 PM
epriestley committed rP8e1600ba83fd: (stable) Don't try to emit project board update events if there are no projects… (authored by epriestley).
(stable) Don't try to emit project board update events if there are no projects…
Jul 31 2019, 7:49 PM
epriestley committed rP76cd181bf379: Don't try to emit project board update events if there are no projects to update (authored by epriestley).
Don't try to emit project board update events if there are no projects to update
Jul 31 2019, 7:48 PM
epriestley closed D20689: Don't try to emit project board update events if there are no projects to update.
Jul 31 2019, 7:48 PM
epriestley added a revision to T13355: Support editing "date" custom fields via Conduit: D20690: Support "date" custom fields in "*.edit" endpoints.
Jul 31 2019, 7:48 PM · Custom Fields, Conduit
epriestley requested review of D20689: Don't try to emit project board update events if there are no projects to update.
Jul 31 2019, 7:43 PM
epriestley added a revision to T4900: Workboards updating in real time: D20689: Don't try to emit project board update events if there are no projects to update.
Jul 31 2019, 7:42 PM · Workboards (v3), User Delight, Wikimedia
epriestley triaged T13355: Support editing "date" custom fields via Conduit as Low priority.
Jul 31 2019, 7:38 PM · Custom Fields, Conduit
epriestley added a comment to T13248: Support enabling and disabling (and making other adjustments to) custom fields based on object subtypes.

See also PHI1358, which is an actual concrete request for sensible relabeling of "Description" in a subtype.

Jul 31 2019, 7:32 PM · Custom Fields, Maniphest
epriestley committed rPHU8df85007f38e: (stable) Promote 2019 Week 31 (authored by epriestley).
(stable) Promote 2019 Week 31
Jul 31 2019, 7:02 PM
epriestley edited the content of Changelog.
Jul 31 2019, 7:02 PM
epriestley created an object: 2019 Week 31 (July).
Jul 31 2019, 7:01 PM
epriestley committed rP6f6ae61f00a8: (stable) Promote 2019 Week 31 (authored by epriestley).
(stable) Promote 2019 Week 31
Jul 31 2019, 7:00 PM
Krinkle awarded D20688: When users visit a Phame post URI with an old blog ID, canonicalize the URI instead of 404'ing a Orange Medal token.
Jul 31 2019, 6:58 PM
epriestley committed rP47d497aa6045: When users visit a Phame post URI with an old blog ID, canonicalize the URI… (authored by epriestley).
When users visit a Phame post URI with an old blog ID, canonicalize the URI…
Jul 31 2019, 6:44 PM
epriestley closed D20688: When users visit a Phame post URI with an old blog ID, canonicalize the URI instead of 404'ing.
Jul 31 2019, 6:44 PM
epriestley closed T13353: When Phame posts move between blogs, the old URIs 404 instead of canonicalizing as Resolved by committing rP47d497aa6045: When users visit a Phame post URI with an old blog ID, canonicalize the URI….
Jul 31 2019, 6:44 PM · Phame
epriestley closed T13354: Test: Workboards Real-Time Updates!? as Invalid.
Jul 31 2019, 6:43 PM · Workboards
epriestley reopened T13354: Test: Workboards Real-Time Updates!? as "Open".
Jul 31 2019, 6:43 PM · Workboards
epriestley closed T13354: Test: Workboards Real-Time Updates!? as Invalid.
Jul 31 2019, 6:42 PM · Workboards
epriestley renamed T13354: Test: Workboards Real-Time Updates!? from Test: Workboards Real-Time Updates! to Test: Workboards Real-Time Updates!?.
Jul 31 2019, 6:42 PM · Workboards
epriestley moved T13354: Test: Workboards Real-Time Updates!? from Future Work to Backlog on the Workboards board.
Jul 31 2019, 6:42 PM · Workboards
epriestley renamed T13354: Test: Workboards Real-Time Updates!? from Test: Workboards Real-Time Updates to Test: Workboards Real-Time Updates!.
Jul 31 2019, 6:42 PM · Workboards
epriestley created T13354: Test: Workboards Real-Time Updates!?.
Jul 31 2019, 6:42 PM · Workboards
epriestley requested review of D20688: When users visit a Phame post URI with an old blog ID, canonicalize the URI instead of 404'ing.
Jul 31 2019, 6:41 PM
epriestley added a revision to T13353: When Phame posts move between blogs, the old URIs 404 instead of canonicalizing: D20688: When users visit a Phame post URI with an old blog ID, canonicalize the URI instead of 404'ing.
Jul 31 2019, 6:40 PM · Phame
epriestley triaged T13353: When Phame posts move between blogs, the old URIs 404 instead of canonicalizing as Low priority.
Jul 31 2019, 6:33 PM · Phame
epriestley committed rP2ec39afcd12b: Deprecate ancient "slowvote.info" API method (authored by epriestley).
Deprecate ancient "slowvote.info" API method
Jul 31 2019, 6:28 PM
epriestley closed T13350: Ancient "slowvote.info" API method bypasses policy checks as Resolved by committing rP2ec39afcd12b: Deprecate ancient "slowvote.info" API method.
Jul 31 2019, 6:28 PM · Slowvote, Security
epriestley closed D20687: Deprecate ancient "slowvote.info" API method.
Jul 31 2019, 6:28 PM
epriestley requested review of D20687: Deprecate ancient "slowvote.info" API method.
Jul 31 2019, 6:27 PM
epriestley committed rPf92480fb7740: Fix two minor display issues with the Conduit "*.search" API documentation (authored by epriestley).
Fix two minor display issues with the Conduit "*.search" API documentation
Jul 31 2019, 6:27 PM
epriestley closed D20686: Fix two minor display issues with the Conduit "*.search" API documentation.
Jul 31 2019, 6:27 PM
epriestley committed rP0b0ab1bd7cfd: Add a "slowvote.poll.search" API method (authored by epriestley).
Add a "slowvote.poll.search" API method
Jul 31 2019, 6:26 PM
epriestley closed D20685: Add a "slowvote.poll.search" API method.
Jul 31 2019, 6:26 PM
epriestley added a revision to T13350: Ancient "slowvote.info" API method bypasses policy checks: D20687: Deprecate ancient "slowvote.info" API method.
Jul 31 2019, 6:26 PM · Slowvote, Security
epriestley requested review of D20686: Fix two minor display issues with the Conduit "*.search" API documentation.
Jul 31 2019, 6:23 PM
epriestley added a revision to T13350: Ancient "slowvote.info" API method bypasses policy checks: D20686: Fix two minor display issues with the Conduit "*.search" API documentation.
Jul 31 2019, 6:22 PM · Slowvote, Security
epriestley requested review of D20685: Add a "slowvote.poll.search" API method.
Jul 31 2019, 6:18 PM
epriestley added a revision to T13350: Ancient "slowvote.info" API method bypasses policy checks: D20685: Add a "slowvote.poll.search" API method.
Jul 31 2019, 6:17 PM · Slowvote, Security
epriestley updated the task description for T13352: Very large objects may not be distributable via CDN (CloudFront has 20GB object limit).
Jul 31 2019, 12:14 AM · Files, Infrastructure

Jul 30 2019

epriestley triaged T13352: Very large objects may not be distributable via CDN (CloudFront has 20GB object limit) as Low priority.
Jul 30 2019, 11:42 PM · Files, Infrastructure
epriestley triaged T13351: "Settings" objects render very generically in the transaction log as Low priority.
Jul 30 2019, 11:21 PM · User Preferences, Feed
epriestley committed rPd81d0c3ea099: Fix an issue where editing cards on a workboard with implicit column ordering… (authored by epriestley).
Fix an issue where editing cards on a workboard with implicit column ordering…
Jul 30 2019, 8:17 PM
epriestley closed D20681: Fix an issue where editing cards on a workboard with implicit column ordering could reorder cards improperly.
Jul 30 2019, 8:17 PM
epriestley committed rP7d41535010aa: When a task card is edited, emit update events for old boards and parent boards (authored by epriestley).
When a task card is edited, emit update events for old boards and parent boards
Jul 30 2019, 8:16 PM
epriestley closed D20680: When a task card is edited, emit update events for old boards and parent boards.
Jul 30 2019, 8:16 PM
epriestley committed rP7e09da3313fb: Fix policy behavior of "slowvote.info" API method (authored by epriestley).
Fix policy behavior of "slowvote.info" API method
Jul 30 2019, 6:56 PM
epriestley closed D20684: Fix policy behavior of "slowvote.info" API method.
Jul 30 2019, 6:56 PM
epriestley requested review of D20684: Fix policy behavior of "slowvote.info" API method.
Jul 30 2019, 6:55 PM
epriestley added a revision to T13350: Ancient "slowvote.info" API method bypasses policy checks: D20684: Fix policy behavior of "slowvote.info" API method.
Jul 30 2019, 6:53 PM · Slowvote, Security
epriestley triaged T13350: Ancient "slowvote.info" API method bypasses policy checks as Low priority.
Jul 30 2019, 6:46 PM · Slowvote, Security
epriestley added a revision to T7148: Allow users to export their data from Phacility: Unknown Object (Differential Revision).
Jul 30 2019, 6:20 PM · Phacility
epriestley added a revision to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting: Unknown Object (Differential Revision).
Jul 30 2019, 6:20 PM · Ops, Restricted Project, Phacility
epriestley added a revision to T7148: Allow users to export their data from Phacility: Unknown Object (Differential Revision).
Jul 30 2019, 6:18 PM · Phacility
epriestley added a revision to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting: Unknown Object (Differential Revision).
Jul 30 2019, 6:18 PM · Ops, Restricted Project, Phacility

Jul 24 2019

epriestley added a comment to D20681: Fix an issue where editing cards on a workboard with implicit column ordering could reorder cards improperly.

Some recent change has disrupted this...

Jul 24 2019, 6:20 PM
epriestley requested review of D20681: Fix an issue where editing cards on a workboard with implicit column ordering could reorder cards improperly.
Jul 24 2019, 6:15 PM
epriestley added a revision to T4900: Workboards updating in real time: D20681: Fix an issue where editing cards on a workboard with implicit column ordering could reorder cards improperly.
Jul 24 2019, 6:11 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

There's currently a bug (likely related to D20652 or D20654?) where normal edits aren't respecting card order correctly during the redraw. I suspect this is just an order parameter getting lost somewhere.

Jul 24 2019, 5:31 PM · Workboards (v3), User Delight, Wikimedia
epriestley requested review of D20680: When a task card is edited, emit update events for old boards and parent boards.
Jul 24 2019, 5:31 PM
epriestley added a revision to T4900: Workboards updating in real time: D20680: When a task card is edited, emit update events for old boards and parent boards.
Jul 24 2019, 5:29 PM · Workboards (v3), User Delight, Wikimedia
jmeador awarded D20679: Tailor "Restart All Builds" for the complex realities of modern build restart rules a Y So Serious token.
Jul 24 2019, 5:11 PM
epriestley closed T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion as Resolved.

Everything has made it to master now so I suspect we're in good shape here.

Jul 24 2019, 5:04 PM · Auth
epriestley committed rPf6621a5fdcff: Tailor "Restart All Builds" for the complex realities of modern build restart… (authored by epriestley).
Tailor "Restart All Builds" for the complex realities of modern build restart…
Jul 24 2019, 4:26 PM
epriestley closed D20679: Tailor "Restart All Builds" for the complex realities of modern build restart rules.
Jul 24 2019, 4:25 PM
epriestley closed T13348: "Restart All Builds" is misleading in the presence of non-restartable builds as Resolved by committing rPf6621a5fdcff: Tailor "Restart All Builds" for the complex realities of modern build restart….
Jul 24 2019, 4:25 PM · Harbormaster
amckinley accepted D20679: Tailor "Restart All Builds" for the complex realities of modern build restart rules.
Jul 24 2019, 3:43 PM
epriestley requested review of D20679: Tailor "Restart All Builds" for the complex realities of modern build restart rules.
Jul 24 2019, 3:16 PM
epriestley added a revision to T13348: "Restart All Builds" is misleading in the presence of non-restartable builds: D20679: Tailor "Restart All Builds" for the complex realities of modern build restart rules.
Jul 24 2019, 3:14 PM · Harbormaster
epriestley committed rP99c864f5e6fb: Provide a basic detail view for user activity logs (authored by epriestley).
Provide a basic detail view for user activity logs
Jul 24 2019, 2:14 PM
epriestley closed D20674: Provide a basic detail view for user activity logs.
Jul 24 2019, 2:14 PM
epriestley committed rP60db658d52c4: Record account recovery email links in the user activity log and make the mail… (authored by epriestley).
Record account recovery email links in the user activity log and make the mail…
Jul 24 2019, 2:13 PM
epriestley closed D20673: Record account recovery email links in the user activity log and make the mail message reference the log.
Jul 24 2019, 2:13 PM
epriestley committed rP57799bc82bad: Give user log types a tokenizer and datasource instead of a page of checkboxes (authored by epriestley).
Give user log types a tokenizer and datasource instead of a page of checkboxes
Jul 24 2019, 2:11 PM
epriestley closed D20672: Give user log types a tokenizer and datasource instead of a page of checkboxes.
Jul 24 2019, 2:11 PM
epriestley committed rP32dd13d43421: Modularize user activity log message types (authored by epriestley).
Modularize user activity log message types
Jul 24 2019, 2:10 PM
epriestley closed D20671: Modularize user activity log message types.
Jul 24 2019, 2:10 PM
epriestley committed rP6831ed94faf6: Contain fallout from overheating feed queries on user profile pages (authored by epriestley).
Contain fallout from overheating feed queries on user profile pages
Jul 24 2019, 2:09 PM
epriestley closed D20678: Contain fallout from overheating feed queries on user profile pages.
Jul 24 2019, 2:09 PM
epriestley closed T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core as Resolved by committing rP6831ed94faf6: Contain fallout from overheating feed queries on user profile pages.
Jul 24 2019, 2:09 PM · Feed
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

Adjusting log_warnings = 2 in production (to get connection aborts into the error log) is also possibly desirable, although the background level of connection abortions (general network flakiness, server restarts during deploy, wait_timeout on very long-running demons?) may be high enough that this is more noise than signal.

Jul 24 2019, 2:03 PM · Ops, Restricted Project, Phacility
amckinley accepted D20674: Provide a basic detail view for user activity logs.
Jul 24 2019, 2:18 AM
amckinley accepted D20671: Modularize user activity log message types.
Jul 24 2019, 2:17 AM
amckinley accepted D20678: Contain fallout from overheating feed queries on user profile pages.
Jul 24 2019, 2:14 AM

Jul 23 2019

epriestley requested review of D20678: Contain fallout from overheating feed queries on user profile pages.
Jul 23 2019, 11:04 PM
epriestley added a revision to T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core: D20678: Contain fallout from overheating feed queries on user profile pages.
Jul 23 2019, 11:03 PM · Feed
epriestley added a comment to T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core.

To reproduce this easily:

Jul 23 2019, 10:57 PM · Feed
epriestley triaged T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core as Low priority.
Jul 23 2019, 10:47 PM · Feed
epriestley abandoned D20677: Provide import/restore guidance for "max_allowed_packet" and "innodb_log_file_size".

I'm likely going to propose some variation of this change, but focus it on max_allowed_packet and on emphasizing that there are two different copies of this setting with different error/failure behavior.

Jul 23 2019, 1:24 PM
epriestley triaged T13348: "Restart All Builds" is misleading in the presence of non-restartable builds as Normal priority.
Jul 23 2019, 1:18 PM · Harbormaster
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

We could also consider these things:

Jul 23 2019, 1:10 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

So actual actionable stuff here is:

Jul 23 2019, 1:04 PM · Ops, Restricted Project, Phacility
epriestley renamed T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting from During MySQL import, server may "2006 MySQL server has gone away" when row data size is large relative to "innodb_log_file_size" (?) to During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.
Jul 23 2019, 12:59 PM · Ops, Restricted Project, Phacility
artms committed rPcd449254256d: Allow users with no CAN_EDIT permissions to silence projects if they want to (authored by artms).
Allow users with no CAN_EDIT permissions to silence projects if they want to
Jul 23 2019, 10:14 AM
artms closed D20675: Allow users with no CAN_EDIT permissions to silence projects if they want to.
Jul 23 2019, 10:14 AM