Page MenuHomePhabricator
Differential D20685

Add a "slowvote.poll.search" API method
ClosedPublic
Actions

Authored by epriestley on Jul 31 2019, 6:16 PM.

Details

Reviewers
None
Maniphest Tasks
T13350: Ancient "slowvote.info" API method bypasses policy checks
Commits
rP0b0ab1bd7cfd: Add a "slowvote.poll.search" API method
Summary

Ref T13350. Add a modern "*.search" API method for Slowvote so "slowvote.info" can be deprecated with a reasonable replacement.

Test Plan

Used Conduit test console to call method, saw reasonable results.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jul 31 2019, 6:16 PM
Harbormaster completed remote builds in B23199: Diff 49335.Jul 31 2019, 6:18 PM
epriestley requested review of this revision.Jul 31 2019, 6:18 PM
epriestley added a child revision: D20686: Fix two minor display issues with the Conduit "*.search" API documentation.Jul 31 2019, 6:22 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 31 2019, 6:26 PM
Closed by commit rP0b0ab1bd7cfd: Add a "slowvote.poll.search" API method (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP0b0ab1bd7cfd: Add a "slowvote.poll.search" API method.

Revision Contents
Changeset List

Diff 49338

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/slowvote/conduit/SlowvoteSearchConduitAPIMethod.php

Loading...
View Options

src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php

Loading...
View Options

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

Loading...
Phabricator · Built by Phacility