Page MenuHomePhabricator

Fix two minor display issues with the Conduit "*.search" API documentation
ClosedPublic

Authored by epriestley on Jul 31 2019, 6:22 PM.

Details

Summary

Depends on D20685. Ref T13350. Currently:

  • When a SearchEngine parameter is marked as hidden from Conduit, we may still render a table of possible values. Instead, only render the table if the parameter is actually usable.
  • The table header is hard-coded to say 'statuses', which is just a silly mistake. (Most commonly, this table does have statuses constants.)
Test Plan

Viewed the Conduit API documentation for the new "slowvote.poll.search" API method, saw more sensible display behavior.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jul 31 2019, 6:22 PM
epriestley requested review of this revision.Jul 31 2019, 6:23 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 31 2019, 6:27 PM
This revision was automatically updated to reflect the committed changes.