Page MenuHomePhabricator
Create Task
Maniphest T13348

"Restart All Builds" is misleading in the presence of non-restartable builds
Closed, ResolvedPublic
Actions

Description

See PHI1351. After recent changes, build plans may be marked non-restartable.

This also means that Restart All Builds on the Buildable does not restart them. While this behavior is correct, the label and messaging are misleading. Better would be:

  • In the confirmation dialog, show a list of affected builds and clearly mark which ones will restart and which ones will not (and why).
  • Probably, rename the actual action to just "Restart Builds".

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Event Timeline

epriestley triaged this task as Normal priority.Jul 23 2019, 1:18 PM
epriestley created this task.
Herald added a subscriber: amckinley. · View Herald TranscriptJul 23 2019, 1:18 PM
epriestley added a revision: Restricted Differential Revision.Jul 24 2019, 3:14 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Jul 24 2019, 4:25 PM
epriestley claimed this task.
epriestley added a commit: Restricted Diffusion Commit.
Phabricator · Built by Phacility