Page MenuHomePhabricator

Fix policy behavior of "slowvote.info" API method
ClosedPublic

Authored by epriestley on Jul 30 2019, 6:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 21, 6:43 PM
Unknown Object (File)
Mon, Nov 21, 6:43 PM
Unknown Object (File)
Mon, Nov 21, 6:43 PM
Unknown Object (File)
Mon, Nov 21, 11:10 AM
Unknown Object (File)
Thu, Nov 17, 12:44 PM
Unknown Object (File)
Sun, Nov 13, 4:43 PM
Unknown Object (File)
Sun, Nov 13, 4:12 PM
Unknown Object (File)
Sat, Nov 12, 2:07 AM
Subscribers
None

Details

Summary

Ref T13350. This ancient API method is missing modern policy checks.

Test Plan
  • Set visibility of vote X to "Only: epriestley".
  • Called "slowvote.info" as another user.
  • Before: retrieved poll title and author.
  • After: policy error.
  • Called "slowvote.info" on a visible poll, got information before and after.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 30 2019, 6:55 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.