Page MenuHomePhabricator

Fix policy behavior of "slowvote.info" API method
ClosedPublic

Authored by epriestley on Jul 30 2019, 6:53 PM.
Tags
None
Referenced Files
F15469182: D20684.id.diff
Fri, Apr 4, 10:26 AM
F15467328: D20684.diff
Thu, Apr 3, 2:05 PM
F15461863: D20684.diff
Tue, Apr 1, 12:01 PM
F15425131: D20684.diff
Sun, Mar 23, 2:37 AM
F15393634: D20684.diff
Sat, Mar 15, 10:56 PM
Unknown Object (File)
Feb 27 2025, 1:50 PM
Unknown Object (File)
Feb 25 2025, 7:23 AM
Unknown Object (File)
Feb 24 2025, 6:58 AM
Subscribers
None

Details

Summary

Ref T13350. This ancient API method is missing modern policy checks.

Test Plan
  • Set visibility of vote X to "Only: epriestley".
  • Called "slowvote.info" as another user.
  • Before: retrieved poll title and author.
  • After: policy error.
  • Called "slowvote.info" on a visible poll, got information before and after.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jul 30 2019, 6:55 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.