HomePhabricator

Tailor "Restart All Builds" for the complex realities of modern build restart…

Tags
None
Referenced Files
F6636315: Screen Shot 2019-07-24 at 8.11.02 AM.png
Jul 24 2019, 4:25 PM
F6636313: Screen Shot 2019-07-24 at 8.11.41 AM.png
Jul 24 2019, 4:25 PM
F6636314: Screen Shot 2019-07-24 at 8.11.10 AM.png
Jul 24 2019, 4:25 PM
Subscribers
None

Description

Tailor "Restart All Builds" for the complex realities of modern build restart rules

Summary:
Fixes T13348. Currently, the Harbormaster UI shows "Restart All Builds", but it really means "Restart Restartable Builds", which is often fewer than "All" builds (because of autobuilds, permissions, and/or configuration).

Remove the misleading term "All" and make the workflow preview exactly which builds will and will not be affected, and why.

Test Plan:

Screen Shot 2019-07-24 at 8.11.41 AM.png (785×1 px, 162 KB)

Screen Shot 2019-07-24 at 8.11.10 AM.png (762×1 px, 173 KB)

Screen Shot 2019-07-24 at 8.11.02 AM.png (762×1 px, 172 KB)

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13348

Differential Revision: https://secure.phabricator.com/D20679