Page MenuHomePhabricator
Feed All Stories

Jul 17 2019

epriestley moved T12908: Allow verbosity of Aphlict log to be reduced from Backlog to Far Future on the Aphlict board.
Jul 17 2019, 6:28 PM · Aphlict, Feature Request
epriestley added a comment to T4900: Workboards updating in real time.

a logical clock to complement the wall-time clocks

Jul 17 2019, 6:25 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

From D20653:

Jul 17 2019, 6:15 PM · Workboards (v3), User Delight, Wikimedia
epriestley requested review of D20654: Make reloading workboards with "R" respect workboard ordering.
Jul 17 2019, 6:05 PM
epriestley added a revision to T4900: Workboards updating in real time: D20654: Make reloading workboards with "R" respect workboard ordering.
Jul 17 2019, 6:04 PM · Workboards (v3), User Delight, Wikimedia
epriestley requested review of D20653: When updating a workboard with "R", send the client visible set with version numbers.
Jul 17 2019, 5:54 PM
epriestley added a revision to T4900: Workboards updating in real time: D20653: When updating a workboard with "R", send the client visible set with version numbers.
Jul 17 2019, 5:53 PM · Workboards (v3), User Delight, Wikimedia
amckinley accepted D20652: Move "BoardResponseEngine" toward a more comprehensive update model.
Jul 17 2019, 5:53 PM
epriestley requested review of D20652: Move "BoardResponseEngine" toward a more comprehensive update model.
Jul 17 2019, 5:40 PM
epriestley added a revision to T4900: Workboards updating in real time: D20652: Move "BoardResponseEngine" toward a more comprehensive update model.
Jul 17 2019, 5:39 PM · Workboards (v3), User Delight, Wikimedia
epriestley triaged T13342: Support export of "date" and "remarkup" custom fields as Normal priority.
Jul 17 2019, 4:40 PM · Custom Fields, Data Exporters
arielyang edited the content of Organizations Using Phabricator.
Jul 17 2019, 4:36 PM

Jul 16 2019

Krinkle awarded T9044: arc diff eagerly detects git-svn repo, which makes arc-patch hang a Orange Medal token.
Jul 16 2019, 6:44 PM · Restricted Project, Arcanist
Krinkle awarded D20327: In remarkup, strip one leading space from each line in a quoted block if possible a Orange Medal token.
Jul 16 2019, 4:27 PM

Jul 15 2019

amckinley committed rP2f313a0e0d55: Remove "unstable" status and T2784-specific warning message (authored by amckinley).
Remove "unstable" status and T2784-specific warning message
Jul 15 2019, 9:05 PM
amckinley closed D20651: Remove "unstable" status and T2784-specific warning message.
Jul 15 2019, 9:05 PM
epriestley accepted D20651: Remove "unstable" status and T2784-specific warning message.
Jul 15 2019, 9:04 PM
amckinley requested review of D20651: Remove "unstable" status and T2784-specific warning message.
Jul 15 2019, 9:04 PM
epriestley added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

Oh, sorry, I misread which half you were asking about.

Jul 15 2019, 8:53 PM · Restricted Project, Auth, Conduit
amckinley added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

Am I going crazy, or do those methods only handle the "blob fetching" part of this equation? I was looking for examples of the "create a File, do a chunked upload, attach said File to an existing object" flow.

Jul 15 2019, 8:28 PM · Restricted Project, Auth, Conduit
epriestley added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

Yeah, diffusion.rawdiffquery and diffusion.filecontentquery both do this.

Jul 15 2019, 8:18 PM · Restricted Project, Auth, Conduit
amckinley added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

For uploading binary blobs, we'd do the reverse: have the client stream the blob into Files, then call an API method with a reference to the object.

Jul 15 2019, 8:16 PM · Restricted Project, Auth, Conduit
amckinley requested review of D20650: Add Ferret support to Paste.
Jul 15 2019, 7:44 PM
amckinley committed rP7852adb84bbe: Actually enforce auth.lock-config (authored by amckinley).
Actually enforce auth.lock-config
Jul 15 2019, 6:53 PM
amckinley closed T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI, a subtask of T6755: Allow more granular configuration of `security.allow-outbound-http`, as Resolved.
Jul 15 2019, 6:53 PM · Security
amckinley closed T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI as Resolved by committing rP7852adb84bbe: Actually enforce auth.lock-config.
Jul 15 2019, 6:53 PM · Auth, Security
amckinley closed D20645: Actually enforce auth.lock-config.
Jul 15 2019, 6:53 PM
amckinley updated the diff for D20645: Actually enforce auth.lock-config.

Pop a dialog instead of navigating away.

Jul 15 2019, 6:51 PM
amckinley added inline comments to D20645: Actually enforce auth.lock-config.
Jul 15 2019, 6:50 PM
epriestley triaged T13341: Phacility/Phortune invoice email merchant behavior changed circa June 22 as Low priority.
Jul 15 2019, 6:42 PM · Phortune, Phacility
epriestley added inline comments to D20645: Actually enforce auth.lock-config.
Jul 15 2019, 6:41 PM
amckinley added inline comments to D20645: Actually enforce auth.lock-config.
Jul 15 2019, 6:37 PM

Jul 14 2019

epriestley added a comment to T13336: "bin/storage dump" option "--for-replica" might not interact properly with "--no-indexes" and PERSISTENCE_CACHE.

An adjacent issue is that PhabricatorMarkupCache is not currently marked as having cache persistence (PhabricatorConfigTableSchema::PERSISTENCE_CACHE), so the data dumps even when we do not intend to dump data for readthrough caches.

Jul 14 2019, 10:22 PM · Infrastructure
epriestley triaged T13340: "PeopleDatasource" improperly uses "closed" state to sort bot/mailing list results to the bottom of the list as Low priority.
Jul 14 2019, 3:07 PM · Typeahead

Jul 12 2019

20after4 awarded T13322: Allow parent projects to have direct members a Love token.
Jul 12 2019, 6:23 PM · Projects
20after4 accepted rP099919366b12: Fix "add more metadata" fatal in Pholio.

Thanks!

Jul 12 2019, 6:07 PM
epriestley closed T10127: Migrating repository between storage hosts in a cluster as Resolved.

I assume this is being done already in the Phacility cluster on some level when repositories get really large, but I'm not particularly sure how to perform this migration.

Jul 12 2019, 5:11 PM · Clusters, Feature Request
epriestley updated the task description for T13339: Update "diffusion.searchquery" to handle multiple path arguments and various weird cases.
Jul 12 2019, 5:05 PM · Diffusion, Conduit
epriestley added a project to T13339: Update "diffusion.searchquery" to handle multiple path arguments and various weird cases: Diffusion.
Jul 12 2019, 5:04 PM · Diffusion, Conduit
epriestley triaged T13339: Update "diffusion.searchquery" to handle multiple path arguments and various weird cases as Normal priority.
Jul 12 2019, 5:04 PM · Diffusion, Conduit
epriestley triaged T13338: Provide "differential.diff.edit" with an option to create a diff from an uploaded file source as Normal priority.
Jul 12 2019, 4:39 PM · Differential, Conduit
epriestley closed T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings, a subtask of T550: Build an SSH conduit client, as Resolved.
Jul 12 2019, 4:28 PM · Prioritized, Arcanist, Restricted Project, Restricted Project, Conduit
epriestley closed T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings as Resolved.

Deprecate conduit sessions and conduit.connect.
Support direct token-based auth (?token=abdef123) and make this the standard.

Jul 12 2019, 4:28 PM · Restricted Project, Auth, Conduit
epriestley closed T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings, a subtask of T9124: Support uploading build log data via the Harbormaster API, as Resolved.
Jul 12 2019, 4:28 PM · Restricted Project, Harbormaster
epriestley closed T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings, a subtask of T4377: Long-running bots which don't make Conduit calls for 24 hours fail all future calls, as Resolved.
Jul 12 2019, 4:28 PM · Conpherence, Phabot
epriestley closed T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings, a subtask of T7288: configuring certificates for bots is hard/confusing, as Resolved.
Jul 12 2019, 4:28 PM · Documentation
epriestley closed T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings, a subtask of T6633: 'differential.creatediff' exception when repository paths contain SHIFT-JIS characters, as Resolved.
Jul 12 2019, 4:28 PM · Arcanist
epriestley closed T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings, a subtask of T10803: PhabricatorApplicationTransactionPublishWorker task failing due to malformed UTF-8, as Resolved.
Jul 12 2019, 4:28 PM · Bug Report (Needs Information)
epriestley triaged T13337: Resolve structural problems with Conduit API methods related to large input/output sizes and binary data as Low priority.
Jul 12 2019, 4:23 PM · Conduit
epriestley committed rPd2935fd7bdc2: Fix a bad call to "writeInfo()" in "bin/phd stop" with no PHABRICATOR_INSTANCE… (authored by epriestley).
Fix a bad call to "writeInfo()" in "bin/phd stop" with no PHABRICATOR_INSTANCE…
Jul 12 2019, 4:15 PM
epriestley closed D20649: Fix a bad call to "writeInfo()" in "bin/phd stop" with no PHABRICATOR_INSTANCE defined.
Jul 12 2019, 4:15 PM
amckinley accepted D20649: Fix a bad call to "writeInfo()" in "bin/phd stop" with no PHABRICATOR_INSTANCE defined.
Jul 12 2019, 4:14 PM
epriestley triaged T13336: "bin/storage dump" option "--for-replica" might not interact properly with "--no-indexes" and PERSISTENCE_CACHE as Low priority.
Jul 12 2019, 4:02 PM · Infrastructure
epriestley requested review of D20649: Fix a bad call to "writeInfo()" in "bin/phd stop" with no PHABRICATOR_INSTANCE defined.
Jul 12 2019, 3:43 PM

Jul 11 2019

epriestley committed rP41ea204144ab: Update one straggling "CAN_INTERACT" check in comment removal (authored by epriestley).
Update one straggling "CAN_INTERACT" check in comment removal
Jul 11 2019, 11:10 PM
epriestley closed D20648: Update one straggling "CAN_INTERACT" check in comment removal.
Jul 11 2019, 11:09 PM
amckinley accepted D20648: Update one straggling "CAN_INTERACT" check in comment removal.
Jul 11 2019, 10:56 PM
epriestley committed rP099919366b12: Fix "add more metadata" fatal in Pholio (authored by epriestley).
Fix "add more metadata" fatal in Pholio
Jul 11 2019, 10:56 PM
epriestley closed D20647: Fix "add more metadata" fatal in Pholio.
Jul 11 2019, 10:56 PM
epriestley requested review of D20648: Update one straggling "CAN_INTERACT" check in comment removal.
Jul 11 2019, 10:53 PM
epriestley added a comment to rPaacc62463d61: Prevent editing and deleting comments in locked conversations.

Thanks! D20648 should fix that -- it slipped through in D20558.

Jul 11 2019, 10:53 PM
amckinley accepted D20647: Fix "add more metadata" fatal in Pholio.
Jul 11 2019, 10:52 PM
20after4 added inline comments to rPaacc62463d61: Prevent editing and deleting comments in locked conversations.
Jul 11 2019, 10:46 PM
20after4 added a comment to rPaacc62463d61: Prevent editing and deleting comments in locked conversations.

@epriestley: Try removing a comment, it throws an exception

Jul 11 2019, 10:45 PM
epriestley added a comment to T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.

D20647 should fix this. It isn't very satisfying as a general resolution.

Jul 11 2019, 9:50 PM · Javelin
epriestley renamed T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way from Exception "Attempting to add more metadata after metadata has been locked" when trying to view a specific Pholio mockup to Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.
Jul 11 2019, 9:41 PM · Javelin
epriestley requested review of D20647: Fix "add more metadata" fatal in Pholio.
Jul 11 2019, 9:41 PM
epriestley added a revision to T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way: D20647: Fix "add more metadata" fatal in Pholio.
Jul 11 2019, 9:40 PM · Javelin
epriestley added a comment to rPaacc62463d61: Prevent editing and deleting comments in locked conversations.

What are you seeing in particular?

Jul 11 2019, 8:51 PM
20after4 added a comment to rPaacc62463d61: Prevent editing and deleting comments in locked conversations.

Apparently commits don't support CAN_INTERACT capability?

Jul 11 2019, 8:49 PM
epriestley accepted D20645: Actually enforce auth.lock-config.
Jul 11 2019, 7:56 PM
epriestley added a comment to T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.

The renderHTMLFooter() method does a bunch of Javascript stuff and isn't actually related to the page footer, but PHUIRemarkupView and renderObjectRefForAnyMedia() were enough of a hint that think I have a reproduction case locally now -- let me figure out what I actually did and this will likely be fairly easy to fix.

Jul 11 2019, 7:53 PM · Javelin
20after4 added a comment to T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.

Could this be related to the custom footer markup? The code in question hasn't changed in a long time but I suspect maybe it's related to changes in the remarkup rendering code that's adding metadata where it didn't previously?

Jul 11 2019, 7:00 PM · Javelin
20after4 added a comment to T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.

I toggled developer mode on for a moment and managed to get a stack trace:

Jul 11 2019, 6:56 PM · Javelin
amckinley updated the test plan for D20645: Actually enforce auth.lock-config.
Jul 11 2019, 6:32 PM
amckinley updated the test plan for D20645: Actually enforce auth.lock-config.
Jul 11 2019, 6:31 PM
amckinley updated the summary of D20645: Actually enforce auth.lock-config.
Jul 11 2019, 6:31 PM
amckinley added inline comments to D20645: Actually enforce auth.lock-config.
Jul 11 2019, 5:15 PM
amckinley updated the diff for D20645: Actually enforce auth.lock-config.
  • Raise "editing while locked" errors in the transaction layer.
  • Changed controllers to catch errors and display them reasonably.
  • Warn users about locked config when editing existing provider:
    Screen Shot 2019-07-11 at 10.09.18 AM.png (386×1 px, 66 KB)
  • When trying to save a provider when the config gets locked during an edit, show reasonable error:
    Screen Shot 2019-07-11 at 10.12.44 AM.png (352×1 px, 50 KB)
Jul 11 2019, 5:14 PM

Jul 10 2019

epriestley triaged T13335: Paragraphs are collapsed incorrectly in quoted blocks in remarkup as Wishlist priority.
Jul 10 2019, 10:11 PM · Remarkup
amckinley committed rP2c435433e0db: Start fleshing out PhabricatorAuthProviderViewController (authored by amckinley).
Start fleshing out PhabricatorAuthProviderViewController
Jul 10 2019, 5:45 PM
amckinley closed D20646: Start fleshing out PhabricatorAuthProviderViewController.
Jul 10 2019, 5:45 PM
epriestley awarded D20646: Start fleshing out PhabricatorAuthProviderViewController a Pterodactyl token.
Jul 10 2019, 5:34 PM
amckinley updated the diff for D20646: Start fleshing out PhabricatorAuthProviderViewController.

Gate auto-login and trust emails.

Jul 10 2019, 5:31 PM
epriestley accepted D20646: Start fleshing out PhabricatorAuthProviderViewController.

We currently have a problem where some of these settings don't make sense or aren't actually used but can be viewed/edited, and this makes it slightly worse.

Jul 10 2019, 5:09 PM
amckinley requested review of D20646: Start fleshing out PhabricatorAuthProviderViewController.
Jul 10 2019, 4:30 PM
amckinley planned changes to D20645: Actually enforce auth.lock-config.
Jul 10 2019, 4:29 PM
epriestley added a comment to D20645: Actually enforce auth.lock-config.

I'd like to make the "view" page more useful (/auth/config/view/X/) which will probably solve that (by showing the non-secret configuration parameters before you hit the edit screen). That page is somewhat recent and just hasn't really been built out yet.

Jul 10 2019, 3:26 PM
amckinley added a comment to D20645: Actually enforce auth.lock-config.

I was also looking for a way to still render the form, except with all the fields grayed out, since it isn't terribly user-friendly to make someone unlock the config just to see what it already says. This seems tricky though, since there's no AphrontFormView->getChildren() method I can iterate over to call setDisable(true) on.

Jul 10 2019, 3:16 PM
epriestley added a comment to D20645: Actually enforce auth.lock-config.

I think some variation of this probably remains desirable no matter what, since we want to roadblock users before they start doing edits, not only once they reach the transaction layer -- not for correctness, but just for usability, so they don't fill out a form and then learn that their changes can't be saved.

Jul 10 2019, 3:15 PM
epriestley added a comment to D20645: Actually enforce auth.lock-config.

Maybe implement PhabricatorAuthProviderConfigEditor->validateTransaction()?

Jul 10 2019, 3:10 PM
amckinley requested review of D20645: Actually enforce auth.lock-config.
Jul 10 2019, 3:07 PM
amckinley added a revision to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI: D20645: Actually enforce auth.lock-config.
Jul 10 2019, 3:05 PM · Auth, Security
epriestley triaged T13334: The "Read-Only" URI repository setting may vary misleadingly across display variations of the same URI as Low priority.
Jul 10 2019, 3:05 PM · Diffusion
epriestley triaged T13333: The "Cancel" button in the "New Repository URI" workflow returns users to "/diffusion/", not the URI management page as Low priority.
Jul 10 2019, 2:50 PM · Diffusion

Jul 9 2019

amckinley created P2119 (An Untitled Masterwork).
Jul 9 2019, 6:51 PM
amckinley created P2118 (An Untitled Masterwork).
Jul 9 2019, 6:45 PM
andytruong created P2117 Test.
Jul 9 2019, 10:40 AM
amckinley awarded D20644: Improve coverage of remarkup "<table>" rule and fix some bad method calls a Baby Tequila token.
Jul 9 2019, 12:42 AM

Jul 8 2019

epriestley committed rPHUb49ed9be94a8: (stable) Improve coverage of remarkup "<table>" rule and fix some bad method… (authored by epriestley).
(stable) Improve coverage of remarkup "<table>" rule and fix some bad method…
Jul 8 2019, 11:57 PM