Page MenuHomePhabricator
Feed All Stories

Apr 3 2018

epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 4:56 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 4:42 PM · Plans, Differential
epriestley added a comment to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.

Some states:

Apr 3 2018, 4:38 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 4:28 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 3:56 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 3:47 PM · Plans, Differential
epriestley added a comment to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.
  • shouldBroadcast() has been removed; getShouldBroadcast() now means the same thing.
Apr 3 2018, 3:38 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 3:23 PM · Plans, Differential
epriestley added a comment to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.
  • getHasBroadcast(), setHasBroadcast(), and PROPERTY_HAS_BROADCAST are now getShouldBroadcast(), etc.
Apr 3 2018, 3:11 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 3:11 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 2:31 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 1:48 PM · Plans, Differential
epriestley added a comment to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.
  • Implementing BuildableInterface now requires implementing newBuildableEngine().
  • Implementing BuildableInterface no longer requires implementing getHarbormasterPublishablePHID(). Publishing indirection is now handled by BuildableEngine.
  • PhabricatorTransactions::TYPE_BUILDABLE no longer exists. Instead, applications should implement application-specific modular transactions to report build status information. DiffusionCommitBuildableTransaction may be useful as a template.
Apr 3 2018, 1:47 PM · Plans, Differential
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 1:05 PM · Plans, Differential
tekacs added a comment to T12300: git push --mirror --force does not work on Phacility with repo that has refs/pull.

Duplicate of T8936?

Apr 3 2018, 1:05 PM · Diffusion, Git
tekacs added a comment to T8936: Unable to identify the reftype of 'refs/remotes/origin/master'. Rejecting push..

As with @michaeloa's case above, this is a blocker to porting repos of ours over (from Gitlab EE, in our case) for testing purposes.

Apr 3 2018, 1:03 PM · Diffusion
epriestley added a revision to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions: Unknown Object (Differential Revision).
Apr 3 2018, 11:46 AM · Plans, Differential

Apr 2 2018

epriestley added a revision to T13116: Plans: 2018 Week 14 Bonus Content: Unknown Object (Differential Revision).
Apr 2 2018, 11:05 PM · Plans
epriestley triaged T13116: Plans: 2018 Week 14 Bonus Content as Normal priority.
Apr 2 2018, 11:00 PM · Plans
epriestley triaged T13115: Handle mail bounces inside Phabricator as Low priority.
Apr 2 2018, 10:53 PM · Mail

Apr 1 2018

videojeux4 added a member for Space Test Users: videojeux4.
Apr 1 2018, 10:38 AM

Mar 31 2018

epriestley closed T13114: Plans: 2018 Week 13 Bonus Content as Resolved.
Mar 31 2018, 11:38 AM · Plans
epriestley edited the content of Changelog.
Mar 31 2018, 12:51 AM
epriestley created 2018 Week 13 (Very Late March).
Mar 31 2018, 12:50 AM

Mar 30 2018

epriestley added a revision to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction: Unknown Object (Differential Revision).
Mar 30 2018, 10:57 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

I'd like to analyze data on the $5 tier with an eye to removing it. Anecdotally, this doesn't seem to be doing anything good for us ... It also feels like we have a lot of $5 test instances.

Mar 30 2018, 10:50 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

The UI and allocation logic for shards need tweaking.

Mar 30 2018, 10:26 PM · Plans, Ops, Infrastructure, Phacility
epriestley closed T12830: Disentangle "repoXYZ = dbXYZ" in the Phacility cluster as Resolved by committing Restricted Diffusion Commit.
Mar 30 2018, 10:25 PM · Ops, Phacility
epriestley added a revision to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction: Unknown Object (Differential Revision).
Mar 30 2018, 10:22 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a revision to T12830: Disentangle "repoXYZ = dbXYZ" in the Phacility cluster: Unknown Object (Differential Revision).
Mar 30 2018, 10:22 PM · Ops, Phacility
epriestley updated the task description for T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.
Mar 30 2018, 9:51 PM · Plans, Differential
epriestley updated the task description for T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance.
Mar 30 2018, 9:31 PM · Plans, Diffusion
epriestley updated the task description for T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance.
Mar 30 2018, 9:30 PM · Plans, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Mar 30 2018, 6:15 PM · Plans, Files, Differential, Diffusion
epriestley added a comment to T3626: Detection of language for some file types isn't good.

When this eventually moves forward, it's probably also appropriate to remove the syntax-highlighter.engine config option. I think this has essentially zero use in the wild and we have better modern patterns to approach the problem (without extreme-niche config options) if there are real-world use cases.

Mar 30 2018, 4:49 PM · Customer Impact, Restricted Project, Differential
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Mar 30 2018, 4:48 PM · Plans, Files, Differential, Diffusion
ftdysa closed Q621: What is the correct way to land stacked diffs? as resolved.
Mar 30 2018, 4:44 PM
ftdysa added Q621: What is the correct way to land stacked diffs? (Answer 566).
Mar 30 2018, 4:44 PM
dereckson added a comment to T12785: Arc unit command fails with PHPUnit 6.

I confirm the Maxime Corteel patch to be working with PHPUnit 7.0.1 too.

Mar 30 2018, 4:03 PM · Arcanist, Bug Report
epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 30 2018, 3:45 PM · Plans
epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Restricted Differential Revision.
Mar 30 2018, 3:26 PM · Plans
bgamari added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

GHC recently upgraded its Phabricator installation and has been rather unpleasantly affected by this feature. We have multi-hour CI jobs, which often queue to a day or so of builds. Making contributors wait this long before receiving feedback is turning out to be rather problematic.

Mar 30 2018, 3:20 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley updated the task description for T13114: Plans: 2018 Week 13 Bonus Content.
Mar 30 2018, 2:54 PM · Plans
epriestley updated the task description for T13114: Plans: 2018 Week 13 Bonus Content.
Mar 30 2018, 2:53 PM · Plans
epriestley updated the task description for T13114: Plans: 2018 Week 13 Bonus Content.
Mar 30 2018, 12:01 AM · Plans

Mar 29 2018

epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 29 2018, 9:06 PM · Plans
epriestley added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

Oh, and I found the beast to get a portal to Saqawal's Roost and killed Saqawal and got the boots, but the boots and set in general seem kinda bad so they're sitting in one of my six tabs full of unique items that I will never ever sell or do anything with.

Mar 29 2018, 8:19 PM · Phacility
epriestley added a comment to T13072: Merge Harbormaster BuildCommand into BuildMessage.

D19269 makes Harbormaster objects destructible. I've made Build destroy BuildMessage (which it doesn't receive, so this never destroys anything) but not BuildCommand (which it does receive), so that when this change is made (and it starts receiving BuildMessage instead of BuildCommand) things will just work. Until then, BuildCommand objects are technically left hanging, but destroying builds is exceptionally rare so I'm just assuming that this will probably be fixed before anyone notices.

Mar 29 2018, 7:59 PM · Harbormaster
epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 29 2018, 7:58 PM · Plans
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: Unknown Object (Differential Revision).
Mar 29 2018, 7:58 PM · Harbormaster
epriestley updated the task description for T13114: Plans: 2018 Week 13 Bonus Content.
Mar 29 2018, 6:42 PM · Plans
ahoffer2 added a comment to T12222: Add custom fields to the "Task Action..." menu.

Hey we actually have the same issue-- folks on the team would like to edit "owning team" from within the action menu. The problem with having to edit the task is that the UI for task editing is less discoverable and requires more clicks than the action menu -- folks are used to being able to accomplish what they need from the action menu so it frustrates them when they can't. This isn't a blocking impediment to our workflows or anything but it would be a nice-to-have UI improvement.

Mar 29 2018, 6:34 PM · Maniphest, Feature Request
epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 29 2018, 6:29 PM · Plans
epriestley closed T12759: Creating an Owners package before creating any repositories shows a blank select when adding paths to the package as Resolved.

I think this is sort of less bad/weird now, at least. You get a tokenizer instead, which is still empty, but you're prompted to "Type a repository name..." and the UI isn't this odd empty select thing anymore.

Mar 29 2018, 6:27 PM · Bug Report
jcox awarded T13114: Plans: 2018 Week 13 Bonus Content a Party Time token.
Mar 29 2018, 5:34 PM · Plans
epriestley updated the task description for T13114: Plans: 2018 Week 13 Bonus Content.
Mar 29 2018, 5:04 PM · Plans
epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 29 2018, 4:54 PM · Plans
epriestley updated the task description for T13114: Plans: 2018 Week 13 Bonus Content.
Mar 29 2018, 4:52 PM · Plans
epriestley added a comment to T13114: Plans: 2018 Week 13 Bonus Content.

D19266 adds some additional Support Pact adventure mode content. Some other ideas for improving this mode:

Mar 29 2018, 2:48 PM · Plans
epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 29 2018, 2:39 PM · Plans
epriestley added a revision to T8951: Allow Diffusion repositories to disable "push" Herald Rules to improve support for importing large repositories by pushing them: Unknown Object (Differential Revision).
Mar 29 2018, 2:22 PM · Restricted Project, Diffusion, Herald
epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 29 2018, 2:22 PM · Plans
epriestley added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

I've barely had a chance to play recently but I know everyone is longing for an update so: I made it to level 88 (which I think is the highest level I've reached on any character), and completed all the white maps, and haven't died yet.

Mar 29 2018, 12:51 PM · Phacility
jmeador added a comment to T13114: Plans: 2018 Week 13 Bonus Content.

See PHI496. Multiple users have now reached the maximum level ("Heavy Wizard") on their Support characters, and we're overdue for an expansion pack to add new adventure content.

Mar 29 2018, 8:18 AM · Plans
epriestley updated the task description for T13114: Plans: 2018 Week 13 Bonus Content.
Mar 29 2018, 12:20 AM · Plans

Mar 28 2018

epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 28 2018, 11:21 PM · Plans
epriestley updated the task description for T13114: Plans: 2018 Week 13 Bonus Content.
Mar 28 2018, 11:20 PM · Plans
epriestley updated the task description for T13114: Plans: 2018 Week 13 Bonus Content.
Mar 28 2018, 10:50 PM · Plans
epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 28 2018, 10:24 PM · Plans
epriestley triaged T13114: Plans: 2018 Week 13 Bonus Content as Normal priority.
Mar 28 2018, 10:18 PM · Plans
epriestley closed T13108: Plans: 2018 Week 12 Bonus Content as Resolved.

Much of this survives in T13110 but the rest is resolved.

Mar 28 2018, 10:13 PM · Plans
bhchandra added a comment to T10767: fold empty directories in Browse view.

okay. thanks!

Mar 28 2018, 6:44 PM · Restricted Project, Diffusion, Feature Request
epriestley added a comment to T10767: fold empty directories in Browse view.

See Planning.

Mar 28 2018, 6:43 PM · Restricted Project, Diffusion, Feature Request
bhchandra added a comment to T10767: fold empty directories in Browse view.

Hello @epriestley, could you please provide any update on this task?
Won'tFix or InQueue ?

Mar 28 2018, 6:38 PM · Restricted Project, Diffusion, Feature Request
epriestley closed T12917: Move domain name registration and SSL to AWS as Resolved.

After clicking 17,000 emails I successfully transferred everything to AWS, with some minor caveats:

Mar 28 2018, 5:04 PM · Ops, Phacility
epriestley added a comment to T12917: Move domain name registration and SSL to AWS.

I moved SSL and registration for phurl.io to AWS in T13113 so this is just a transfer issue now.

Mar 28 2018, 3:28 PM · Ops, Phacility
epriestley added a comment to T13113: phurl.io SSL certificate has expired.

oh wow it actually worked 😱

Mar 28 2018, 3:27 PM · Phacility, Ops
epriestley added a comment to T13113: phurl.io SSL certificate has expired.

AWS also supports DNS-based authorization now, which reduces the need for all the MX juggling.

Mar 28 2018, 3:22 PM · Phacility, Ops
epriestley closed T13113: phurl.io SSL certificate has expired as Resolved.

I was able to MX phurl.io and get an SSL authorization link working. I moved phurl.io SSL to AWS ACM so this (certificate expiration) shouldn't happen again.

Mar 28 2018, 3:19 PM · Phacility, Ops
epriestley added projects to T13113: phurl.io SSL certificate has expired: Ops, Phacility.
Mar 28 2018, 3:01 PM · Phacility, Ops
epriestley added a comment to T13113: phurl.io SSL certificate has expired.

(See also T7125, but this particular problem has conceptually been solved for every domain except phurl.io by using AWS certificates.)

Mar 28 2018, 2:53 PM · Phacility, Ops
epriestley added a comment to T13113: phurl.io SSL certificate has expired.

See also T12917 and a brief mention in T13062.

Mar 28 2018, 2:53 PM · Phacility, Ops
WTreutterer added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

Changeset rPfb4ce851c4ae: Add a PDF document "rendering" engine allows to view PDFs from the Files application. However, {Fxxx, ...} references to a PDF file in Phriction still only allow to download the file or open a lightbox with only an icon (again with a download link).

Mar 28 2018, 8:08 AM · Plans, Files, Differential, Diffusion

Mar 27 2018

cspeckmim created T13113: phurl.io SSL certificate has expired.
Mar 27 2018, 7:53 PM · Phacility, Ops
NDKilla added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

im leaning towards ethical. someone traded me a 3 ex helmet for 40c worth of regrets. I looked up how much the helm was and demanded they trade me 40c for their helm back xD

Mar 27 2018, 2:52 AM · Phacility

Mar 26 2018

epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Mar 26 2018, 2:23 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Mar 26 2018, 2:20 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Mar 26 2018, 2:16 PM · Plans, Files, Differential, Diffusion

Mar 24 2018

NDKilla added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

the best part of being so unethical

Mar 24 2018, 10:25 PM · Phacility

Mar 23 2018

epriestley edited the content of Changelog.
Mar 23 2018, 9:50 PM
epriestley created 2018 Week 12 (Late March).
Mar 23 2018, 9:49 PM
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Mar 23 2018, 8:49 PM · Plans, Files, Differential, Diffusion
jparise edited the content of Community Resources.
Mar 23 2018, 2:56 PM
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Mar 23 2018, 2:41 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Mar 23 2018, 2:06 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Mar 23 2018, 12:10 PM · Plans, Files, Differential, Diffusion
epriestley updated the task description for T13112: Safari, PDFs, and Content-Security-Policy interact oddly.
Mar 23 2018, 11:50 AM · Safari, Security, Files
epriestley closed T13112: Safari, PDFs, and Content-Security-Policy interact oddly as Resolved.

Actually, it seems like rel="noreferrer" fixes this. This is bizarre so maybe this is a problem with a spooky ghost haunting my computer?

Mar 23 2018, 11:48 AM · Safari, Security, Files
epriestley triaged T13112: Safari, PDFs, and Content-Security-Policy interact oddly as Normal priority.
Mar 23 2018, 11:47 AM · Safari, Security, Files
mydeveloperday added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

I really like this, Remarkup idea, I think there are many text based files that people add to reviews which would be easily transformed to something more readable by being transfer directly to Remarkup, even for example something as simple as CSV,

Mar 23 2018, 11:27 AM · Plans, Files, Differential, Diffusion