Page MenuHomePhabricator

bgamari (Ben Gamari)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Nov 22 2015, 7:03 PM (199 w, 3 d)
Availability
Available

Recent Activity

Apr 24 2018

bgamari added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

@epriestley, can you confirm that the above patch should disable the draft state? I have applied it to GHC's Phabricator deployment yet we are still seeing Differentials opened in draft state.

Apr 24 2018, 5:01 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential

Mar 30 2018

bgamari added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

GHC recently upgraded its Phabricator installation and has been rather unpleasantly affected by this feature. We have multi-hour CI jobs, which often queue to a day or so of builds. Making contributors wait this long before receiving feedback is turning out to be rather problematic.

Mar 30 2018, 3:20 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential

Sep 29 2017

bgamari added a watcher for Security: bgamari.
Sep 29 2017, 4:07 PM

Oct 13 2016

bgamari added a comment to T8238: Formally support side-band change handoff in external repositories.

I agree that there is no sensible technical reason for the broken network policies that prompted my comment and understand your reasons for preferring to punt on a technical solution. Thanks for your thoughtful remarks.

Oct 13 2016, 3:07 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
bgamari added a comment to T8238: Formally support side-band change handoff in external repositories.

Some GHC contributors have had some trouble with the fact that there is no choice in staging area URL. Unfortunately, some users appear to be behind corporate firewalls which block anything but http and https. We use SSH for our staging repository, which is of course problematic for these contributors. There are a few comments above from Nov 2015 which suggest that we aren't the only ones who have this issue.

Oct 13 2016, 1:28 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster

Aug 29 2016

bgamari added a comment to T4369: Phabricator HTTP repository hosting has fairly severe scalability limits.

GHC appears to be running into this limitation. We would prefer to use anonymous HTTP access with our build bots; is there any hope that this will be fixed in the near-term?

Aug 29 2016, 3:16 PM · Diffusion (v3), Restricted Project

Aug 25 2016

bgamari added a comment to T4587: Generate SSH keys for users.

GHC would also find support for importing keys from Github useful; we are currently working on rolling out a Diffusion-hosted staging area for use with Harbormaster but the need for contributors to submit their key to yet another Phab feels like unnecessary friction.

Aug 25 2016, 7:12 PM · Passphrase, Auth

May 21 2016

bgamari added a comment to T5000: Using Differential with plain Git, without requiring Arc.

You'll still need to go there and fill out all the stuff you would have filled out in your commit message. That is, this flow would drop you at the screen right after you copy/paste:

May 21 2016, 7:04 AM · KDE, FreeBSD, Restricted Project, Haskell.org, Differential, Arcanist

Nov 22 2015

bgamari abandoned D14536: Run script-and-regex linter on all files.

Sounds good to me. Thanks again!

Nov 22 2015, 11:24 PM
bgamari edited the content of Community Resources.
Nov 22 2015, 11:24 PM
bgamari added a comment to D14536: Run script-and-regex linter on all files.

The documentation contains this paragraph,

Nov 22 2015, 11:13 PM
bgamari abandoned D14535: Add external-json linter.
Nov 22 2015, 11:09 PM
bgamari added a comment to D14535: Add external-json linter.

This code looks good to me in a technical sense, we just don't want to take over maintaining it. Two minor suggestions:

  • phutil_utf8_strtolower() has better behavior than strtolower() on some utf8 inputs.
  • phutil_json_decode() has better behavior (throws a detailed exception) on invalid JSON than json_decode() (returns false).

Thanks for the review!

Nov 22 2015, 11:05 PM
bgamari added a comment to D14536: Run script-and-regex linter on all files.

Done.

Nov 22 2015, 10:50 PM
bgamari added a comment to T9827: Provide a more structured way of interfacing with external linters.

Fair enough. Thanks for your thoughtful reply.

Nov 22 2015, 10:46 PM · Lint, Arcanist
bgamari updated the diff for D14535: Add external-json linter.

Correct comments

Nov 22 2015, 10:23 PM
bgamari added a comment to T9827: Provide a more structured way of interfacing with external linters.

@epriestley, the amended text should clarify my goals here.

Nov 22 2015, 10:18 PM · Lint, Arcanist
bgamari updated the task description for T9827: Provide a more structured way of interfacing with external linters.
Nov 22 2015, 10:18 PM · Lint, Arcanist
bgamari updated the task description for T9827: Provide a more structured way of interfacing with external linters.
Nov 22 2015, 10:07 PM · Lint, Arcanist
bgamari added a revision to T9827: Provide a more structured way of interfacing with external linters: D14535: Add external-json linter.
Nov 22 2015, 10:06 PM · Lint, Arcanist
bgamari added a task to D14535: Add external-json linter: T9827: Provide a more structured way of interfacing with external linters.
Nov 22 2015, 10:06 PM
bgamari created T9827: Provide a more structured way of interfacing with external linters.
Nov 22 2015, 10:04 PM · Lint, Arcanist
bgamari retitled D14536: Run script-and-regex linter on all files from to Run script-and-regex linter on all files.
Nov 22 2015, 8:05 PM
bgamari retitled D14535: Add external-json linter from to Add external-json linter.
Nov 22 2015, 8:04 PM