Page MenuHomePhabricator
Feed All Stories

Sep 22 2017

epriestley created 2017 Week 38 (Late September).
Sep 22 2017, 6:48 PM
epriestley added a comment to T7148: Allow users to export their data from Phacility.

Modern flow is:

Sep 22 2017, 6:40 PM · Phacility
epriestley closed T12995: When search terms contain CJK characters, default to substring mode as Resolved by committing Restricted Diffusion Commit.
Sep 22 2017, 6:34 PM · Localization, Search
epriestley added a revision to T12995: When search terms contain CJK characters, default to substring mode: Unknown Object (Differential Revision).
Sep 22 2017, 3:15 PM · Localization, Search
epriestley added a revision to T12995: When search terms contain CJK characters, default to substring mode: Unknown Object (Differential Revision).
Sep 22 2017, 2:25 PM · Localization, Search
spawnlt awarded T10354: Remarkup block elements may not contain other block elements (like lists and tables inside tables) a Party Time token.
Sep 22 2017, 10:48 AM · Feature Request, Remarkup
spawnlt awarded T5427: Force a line break in a table cell a Party Time token.
Sep 22 2017, 10:41 AM · Remarkup
mpadourek awarded T6008: Editing files and contributing changes via web a Like token.
Sep 22 2017, 8:40 AM · Restricted Project, Wikimedia, Diffusion, Differential
kuba-orlik asked Q638: Workbord columns vs task statuses - when to use which?.
Sep 22 2017, 6:57 AM · Maniphest, Projects

Sep 21 2017

epriestley created T12995: When search terms contain CJK characters, default to substring mode.
Sep 21 2017, 12:05 PM · Localization, Search

Sep 20 2017

epriestley added a comment to T12993: Datasource queries with many "JOIN ... LIKE" can have explosive complexity.

Some followup SHOW INDEXES from the case in PHI47 provided output which didn't have any evidence of key cardinality issues, so it seems less likely that this is a cardinality problem.

Sep 20 2017, 7:43 PM · Infrastructure, Typeahead, Search
epriestley created T12994: Add a setup warning if MYSQLI_ASYNC is not defined (support for MySQLi async).
Sep 20 2017, 7:28 PM · Database, Infrastructure
epriestley created T12993: Datasource queries with many "JOIN ... LIKE" can have explosive complexity.
Sep 20 2017, 7:22 PM · Infrastructure, Typeahead, Search
amckinley created T12991: Enable notifications for admin.phacility.com.
Sep 20 2017, 6:27 PM

Sep 19 2017

franjesus added a comment to T9548: Support Mercurial's bundle2 wire protocol.

https://www.mercurial-scm.org/repo/hg/file/default/contrib/phabricator.py is a Mercurial extension that allows you to send a series of changesets to Phabricator by calling Conduit APIs directly. The extension is currently tailored for the use cases of the Mercurial project itself, isn't distributed with Mercurial, and may require Mercurial 4.3. And it obviously bypasses Phabricator's built-in Mercurial server. But if you are willing to live with the caveats, you may find it a suitable workaround.

Sep 19 2017, 11:26 AM · Diffusion, Mercurial
clemvangelis awarded T9492: Make WorkingCopy resources more powerful and flexible a Like token.
Sep 19 2017, 8:31 AM · Restricted Project, Drydock

Sep 18 2017

epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Sep 18 2017, 11:01 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

An unusual case here is Herald rules which take the "Send me an email" action, and act "only the first time". Their current behavior will be to activate when the draft is created, have their mail killed later in the pipeline when the Editor declines to generate any, and then never fire again.

Sep 18 2017, 9:56 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Sep 18 2017, 9:48 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Sep 18 2017, 9:17 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley closed T12987: `key_position` on CursorPosition needs to be guaranteed by migrations as Resolved.
Sep 18 2017, 9:04 PM · Diffusion
epriestley added a comment to T12987: `key_position` on CursorPosition needs to be guaranteed by migrations.

I deployed this to secure without issue, so it looks like LOCK TABLES ... is promising as a general tool for migrations.

Sep 18 2017, 9:04 PM · Diffusion
epriestley closed T12986: bin/differential migrate-hunk has a compression bug as Resolved by committing Restricted Diffusion Commit.
Sep 18 2017, 9:00 PM · Differential
epriestley created T12990: Support pact language around Autopay is misleading at best.
Sep 18 2017, 8:51 PM · Phacility, Support
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Sep 18 2017, 7:57 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T12986: bin/differential migrate-hunk has a compression bug: Unknown Object (Differential Revision).
Sep 18 2017, 7:27 PM · Differential
epriestley added a revision to T12987: `key_position` on CursorPosition needs to be guaranteed by migrations: Unknown Object (Differential Revision).
Sep 18 2017, 6:52 PM · Diffusion
epriestley added a comment to T12989: Phacility Deployment: 2017 Week 38.

We actually already have bin/remote stop, I just run it so rarely that I forgot about it.

Sep 18 2017, 4:41 PM · Ops, Phacility
epriestley updated the task description for T12989: Phacility Deployment: 2017 Week 38.
Sep 18 2017, 4:40 PM · Ops, Phacility
epriestley closed T12978: Phacility Cluster Maintenance: 2017 Week 37 as Resolved.

Next chapter: T12989: Phacility Deployment: 2017 Week 38

Sep 18 2017, 4:33 PM · Ops, Phacility
epriestley created T12989: Phacility Deployment: 2017 Week 38.
Sep 18 2017, 4:32 PM · Ops, Phacility
epriestley created T12988: Remove flag "--master" from bin/remote.
Sep 18 2017, 4:28 PM · Ops, Phacility
epriestley created T12987: `key_position` on CursorPosition needs to be guaranteed by migrations.
Sep 18 2017, 4:26 PM · Diffusion
epriestley created T12986: bin/differential migrate-hunk has a compression bug.
Sep 18 2017, 4:24 PM · Differential
joshuaspence added a revision to T4334: Support PHP5.4+ syntax in XHPAST: Unknown Object (Differential Revision).
Sep 18 2017, 11:07 AM · XHPAST

Sep 16 2017

epriestley closed T12983: Replace vault001 with an "ELB-VPC" load balancer as Resolved.

vault002 is dead. Long live lb001.

Sep 16 2017, 7:10 PM · Phacility, Ops
epriestley closed T12983: Replace vault001 with an "ELB-VPC" load balancer, a subtask of T12978: Phacility Cluster Maintenance: 2017 Week 37, as Resolved.
Sep 16 2017, 7:10 PM · Ops, Phacility
epriestley added subtasks for T12978: Phacility Cluster Maintenance: 2017 Week 37: T12983: Replace vault001 with an "ELB-VPC" load balancer, Unknown Object (Maniphest Task).
Sep 16 2017, 4:29 PM · Ops, Phacility
epriestley added a parent task for T12983: Replace vault001 with an "ELB-VPC" load balancer: T12978: Phacility Cluster Maintenance: 2017 Week 37.
Sep 16 2017, 4:29 PM · Phacility, Ops
epriestley updated the task description for T12978: Phacility Cluster Maintenance: 2017 Week 37.
Sep 16 2017, 4:28 PM · Ops, Phacility

Sep 15 2017

epriestley added a comment to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs.

This is now deployed on this server, we'll see how it holds up. It won't promote to stable until next week, and I'd discourage anyone from picking it up right away.

Sep 15 2017, 5:45 PM · Customer Impact, Diffusion, Bug Report
btrahan changed the status of T4382: Pholio inline comment "not submitted yet" message: add title to explain the message from Duplicate to Resolved by committing Restricted Diffusion Commit.
Sep 15 2017, 5:28 PM · Pholio
epriestley closed T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size as Resolved.

This has promoted to stable. See T12974 for upgrade guidance. See T12985 for one followup change. This may still have some bugs (or it may scale very differently on real-world workloads and need substantial additional work) but I think we can handle those separately.

Sep 15 2017, 5:16 PM · Restricted Project, Search
epriestley closed T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size, a subtask of T12974: Upgrading: "Ferret" Fulltext Engine, as Resolved.
Sep 15 2017, 5:16 PM · Installing & Upgrading, Search
epriestley added a subtask for T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud): T12985: Convert Conpherence fulltext search to the Ferret engine.
Sep 15 2017, 5:14 PM
epriestley added a parent task for T12985: Convert Conpherence fulltext search to the Ferret engine: T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud).
Sep 15 2017, 5:14 PM · Search, Conpherence
epriestley created T12985: Convert Conpherence fulltext search to the Ferret engine.
Sep 15 2017, 5:14 PM · Search, Conpherence
epriestley edited the content of Changelog.
Sep 15 2017, 5:08 PM
epriestley created 2017 Week 37 (Mid September).
Sep 15 2017, 5:07 PM
epriestley added a comment to T12983: Replace vault001 with an "ELB-VPC" load balancer.

Swap DNS.

Sep 15 2017, 4:40 PM · Phacility, Ops
epriestley added a comment to T12983: Replace vault001 with an "ELB-VPC" load balancer.
  • I opened up 22 -> 2223 on lb001.
  • I allowed external 22 in the security group.
  • I hard-coded my hostfile and cloned successfully:
Sep 15 2017, 4:38 PM · Phacility, Ops
epriestley updated subscribers of T12983: Replace vault001 with an "ELB-VPC" load balancer.

I'm going to take a stab at this now since I think it's non-disruptive and straightforward.

Sep 15 2017, 4:26 PM · Phacility, Ops
epriestley added a revision to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs: Unknown Object (Differential Revision).
Sep 15 2017, 4:24 PM · Customer Impact, Diffusion, Bug Report
epriestley added a revision to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs: Unknown Object (Differential Revision).
Sep 15 2017, 4:20 PM · Customer Impact, Diffusion, Bug Report
pouyana added a comment to T12856: Evaluate various "infrastructure-as-code" products.

We use Almanac + Passphrase + Ansible + (Dynamic inventory client) for this.

Sep 15 2017, 3:38 PM · Ops, Phacility
epriestley added a revision to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs: Unknown Object (Differential Revision).
Sep 15 2017, 3:36 PM · Customer Impact, Diffusion, Bug Report
epriestley added a revision to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs: Unknown Object (Differential Revision).
Sep 15 2017, 3:28 PM · Customer Impact, Diffusion, Bug Report

Sep 14 2017

alexmv edited P2074 Masterwork From Distant Lands.
Sep 14 2017, 10:17 PM
alexmv edited P2073 Masterwork From Distant Lands.
Sep 14 2017, 10:13 PM
epriestley added a comment to T12414: Implement Almanac edit endpoints in Conduit.

It's also possible to write a custom instances.do-exactly-what-we-need sort of endpoint and generalize later if that seems like a more promising approach.

Sep 14 2017, 10:09 PM · Conduit, Almanac, Ops, Phacility
epriestley added a comment to T12414: Implement Almanac edit endpoints in Conduit.

The other shadow lurking in the water here -- which I think we can mostly avoid -- is that Almanac is mostly a-bit-bare-bones-but-overall-pretty-functional, except that the way properties on Bindings and Services are specified and edited is complete garbage. You more or less just have to magically know which properties are valid, and there's no real support for defaults or nice UI controls or hints about what you can set or suggestions that you're making stuff up and probably typo'd something.

Sep 14 2017, 9:55 PM · Conduit, Almanac, Ops, Phacility
epriestley added a comment to T12414: Implement Almanac edit endpoints in Conduit.

The "most right" way in terms of consistency is to fully convert Binding to EditEngine, then implement almanac.binding.edit which can create/edit bindings. When creating a binding, it would require transactions specifying the service and interface. PhamePostBlogTransaction is sort of an example of this: when you create a new post with phame.post.edit, you must specify a blog transaction.

Sep 14 2017, 9:49 PM · Conduit, Almanac, Ops, Phacility
amckinley added a comment to T12414: Implement Almanac edit endpoints in Conduit.

What's the best way to add API endpoints for resources like bindings? Call it almanac.create_binding and have it take a service and an interface as arguments?

Sep 14 2017, 8:23 PM · Conduit, Almanac, Ops, Phacility
remusvrm awarded T9821: Allow Harbormaster build plans to run on branch push instead of per-commit a Like token.
Sep 14 2017, 7:59 PM · Restricted Project, Harbormaster
amckinley closed T12981: Explicitly limit lint and unit test names to 255 characters as Resolved by committing Restricted Diffusion Commit.
Sep 14 2017, 6:42 PM · Harbormaster, Conduit
amckinley added a revision to T12981: Explicitly limit lint and unit test names to 255 characters: Unknown Object (Differential Revision).
Sep 14 2017, 6:28 PM · Harbormaster, Conduit
amckinley created P2072 (An Untitled Masterwork).
Sep 14 2017, 6:23 PM
amckinley created P2071 (An Untitled Masterwork).
Sep 14 2017, 6:19 PM
epriestley added a comment to T12984: Support issues don't have hovercards.

Yeah, this is hard coded here:

Sep 14 2017, 5:46 PM · Support
amckinley claimed T12981: Explicitly limit lint and unit test names to 255 characters.
Sep 14 2017, 5:34 PM · Harbormaster, Conduit
amckinley created T12984: Support issues don't have hovercards.
Sep 14 2017, 5:17 PM · Support
epriestley created T12983: Replace vault001 with an "ELB-VPC" load balancer.
Sep 14 2017, 5:07 PM · Phacility, Ops
epriestley added a revision to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs: Unknown Object (Differential Revision).
Sep 14 2017, 12:13 PM · Customer Impact, Diffusion, Bug Report
epriestley added a comment to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs.

In Mercurial, can a branch have some open heads and some closed heads?

Sep 14 2017, 12:03 PM · Customer Impact, Diffusion, Bug Report
avivey added a comment to T9821: Allow Harbormaster build plans to run on branch push instead of per-commit.

(Mentioned in https://discourse.phabricator-community.org/t/run-herald-rule-for-each-push/299)

Sep 14 2017, 11:27 AM · Restricted Project, Harbormaster
epriestley closed T12977: Project "Chad's House" suggests #chad_s_house on this install but that doesn't link as Resolved.

This seems like a legacy data issue that's probably unique to this install. The only way I could reproduce it locally was:

Sep 14 2017, 11:02 AM · Projects
epriestley added hashtags to Chad's House: #chad_s_house, #chads_house.
Sep 14 2017, 11:01 AM
epriestley removed a hashtag from Chad's House: #chad_s_house2.
Sep 14 2017, 10:57 AM
epriestley renamed Chad's House from Chad's House2 to Chad's House.
Sep 14 2017, 10:56 AM
epriestley renamed Chad's House from Chad's House to Chad's House2.
Sep 14 2017, 10:56 AM
epriestley claimed T12977: Project "Chad's House" suggests #chad_s_house on this install but that doesn't link.
Sep 14 2017, 10:56 AM · Projects
epriestley removed a hashtag from Chad's House: #chads_house.
Sep 14 2017, 10:56 AM
epriestley removed a hashtag from Chad's House: #chad_house.
Sep 14 2017, 10:55 AM
epriestley added a hashtag to Chad's House: #chad_house.
Sep 14 2017, 10:55 AM
benwick awarded T12974: Upgrading: "Ferret" Fulltext Engine a Like token.
Sep 14 2017, 6:30 AM · Installing & Upgrading, Search

Sep 13 2017

epriestley added a comment to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs.

See also PHI68.

Sep 13 2017, 10:55 PM · Customer Impact, Diffusion, Bug Report
epriestley added a comment to T12033: Large diffs can still repeatedly fail to insert.

Oh, yes, sorry, looked at the wrong tab.

Sep 13 2017, 10:49 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
alexmv added a comment to T12033: Large diffs can still repeatedly fail to insert.

Do you mean "follow up in PHI55"?

Sep 13 2017, 10:40 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
epriestley added a comment to T12033: Large diffs can still repeatedly fail to insert.

I'm going to presume this is resolved by D18598 -- I updated T11767 with more plans and context for smoothing over the behavior, but I think it will no longer be disastrously bad. I'll follow up in PHI36 PHI55.

Sep 13 2017, 10:34 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
epriestley closed T12979: Sticky notifications no longer appear as Resolved by committing Restricted Diffusion Commit.
Sep 13 2017, 10:32 PM · Notifications
epriestley added a revision to T12979: Sticky notifications no longer appear: Unknown Object (Differential Revision).
Sep 13 2017, 9:59 PM · Notifications
epriestley claimed T12979: Sticky notifications no longer appear.

This is also affecting other persistent sticky notifications, notably "Read-Only Mode" and "High Security Mode". I need "Read-Only" mode for PHI36 so I'll take a look at this.

Sep 13 2017, 9:39 PM · Notifications
epriestley added a revision to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs: Restricted Differential Revision.
Sep 13 2017, 7:21 PM · Customer Impact, Diffusion, Bug Report
epriestley created T12982: In Differential, diff-of-diffs where both diffs added an identical file is misleading.
Sep 13 2017, 3:14 PM · Differential
epriestley added a comment to T12974: Upgrading: "Ferret" Fulltext Engine.

Very intresting update. Now we can search in projects code, as i see? Thanks for this supir dupir project guys)

Sep 13 2017, 2:03 PM · Installing & Upgrading, Search
saggid added a comment to T12974: Upgrading: "Ferret" Fulltext Engine.

Very intresting update. Now we can search in projects code, as i see? Thanks for this supir dupir project guys)

Sep 13 2017, 11:25 AM · Installing & Upgrading, Search
ivo added a comment to T3963: Templates in Phriction.

As for the templates-as-starting-points case: couldn't this be solved by implementing edit engine support for Phriction?

Sep 13 2017, 10:03 AM · Phriction

Sep 12 2017

epriestley updated the task description for T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion.
Sep 12 2017, 10:52 PM · Diffusion (v3), Differential, Mail
epriestley added a revision to T12033: Large diffs can still repeatedly fail to insert: Restricted Differential Revision.
Sep 12 2017, 10:43 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
epriestley added a comment to T12981: Explicitly limit lint and unit test names to 255 characters.

(@amckinley, if you have time to pick this up it's one of the more tackle-able tasks in the support queue.)

Sep 12 2017, 10:09 PM · Harbormaster, Conduit