Page MenuHomePhabricator
Feed All Stories

Nov 5 2016

epriestley added a comment to T11809: Calendar v1 Errata Mark II.

@deric, the code event.dateTo no longer appears anywhere in Phabricator (it was removed prior to the column being removed) so I suspect you did not restart properly and were running cached code (or possibly have custom code you need to update). See Restarting Phabricator.

Nov 5 2016, 3:05 PM · Calendar
deric added a comment to T11809: Calendar v1 Errata Mark II.

The {rP3f2f81a1c8ab6ccb99caa01b7fd12b928ed30eba} commit broke our phabricator setup.

#1054: Unknown column 'event.dateTo' in 'where clause' at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:325]
PHP message: arcanist(head=master, ref.master=fad85844314b), phabricator(head=master, ref.master=bd3233d3ab0c), phutil(head=master, ref.master=e409df2720c2)
...

for fixing seems to be enough:

use phabricator_calendar;
alter table calendar_event add dateTo int unsigned NOT NULL;
alter table calendar_event add dateFrom int unsigned NOT NULL;
Nov 5 2016, 12:05 PM · Calendar
chad merged T11819: View for events a week, month a year in advance into T11816: Calendar: Feedback and Suggestions.
Nov 5 2016, 4:40 AM · Restricted Project, Calendar
chad merged task T11819: View for events a week, month a year in advance into T11816: Calendar: Feedback and Suggestions.
Nov 5 2016, 4:40 AM · Calendar, Feature Request
cspeckmim added a comment to T11801: Calendar: ICS Import Errata.

(Moved from T11816#199040)

Nov 5 2016, 2:02 AM · Bug Report, Calendar
cspeckmim added a comment to T11816: Calendar: Feedback and Suggestions.

Oh shoot I just saw your changelog note about reporting import/export issues on T11801. Sorry. Keep here or migrate comment?

Nov 5 2016, 1:12 AM · Restricted Project, Calendar
cspeckmim added a comment to T11816: Calendar: Feedback and Suggestions.
Nov 5 2016, 1:11 AM · Restricted Project, Calendar
epriestley edited the content of Changelog.
Nov 5 2016, 1:05 AM
epriestley created 2016 Week 45 (Early November).
Nov 5 2016, 1:05 AM
cspeckmim added a comment to T11816: Calendar: Feedback and Suggestions.

In my head all this email RSVP did sound noodley and would need more definition before it could go into a version. I figured I would mention it to see if it was even considered and/or you'd like tasks for use cases/definitions.

Nov 5 2016, 12:24 AM · Restricted Project, Calendar

Nov 4 2016

epriestley added a comment to T11816: Calendar: Feedback and Suggestions.
  • D16803 should fix Applications → Calendar → Edit Policies.
  • D16800 + D16801 should fix fanciful timezones present in ICS files.
  • D16802 should add the ability to select a greater or lesser degree of away-ness for each event.
Nov 4 2016, 11:54 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 4 2016, 11:40 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 4 2016, 11:36 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 4 2016, 10:39 PM · Restricted Project, Calendar
epriestley added a revision to T11816: Calendar: Feedback and Suggestions: Unknown Object (Differential Revision).
Nov 4 2016, 10:30 PM · Restricted Project, Calendar
avivey added a comment to T11816: Calendar: Feedback and Suggestions.

In my company, other then personal calendars, we have a small number of shared (google) calendars, which might be relevant use-cases:

  • Out of Office Calendar: Each person is expected to add their OOO/WFH-ness there, so everybody has a quick-glance view of who's around. The only way to differentiate "available online" or not and who is effected is by actually reading the items, but that's a technicality.
  • Release calendar, where we list dates/times of code freezes, test cycles, deployments, planed external outages, etc.. This one works much better, mostly because it has a lot less events on.
Nov 4 2016, 9:42 PM · Restricted Project, Calendar
avivey added a comment to T11816: Calendar: Feedback and Suggestions.

I think I'd like to see the red dot being more lenient/controlled. For example, if I'm in a meeting, it should probably not show me the same level of "away-ness" as a week's vacation; Similarly, if I put an event on my calendar for "Work-from-home" or "No meetings day", I might be more available than normally.

Nov 4 2016, 9:26 PM · Restricted Project, Calendar
• Gadget0624 awarded T10262: Scramble file secrets when attached objects change their view policies a Burninate token.
Nov 4 2016, 5:59 PM · Restricted Project, Restricted Project, Wikimedia, Files
epriestley closed T11820: Provision and deploy new 007/008 shards in the Phacility cluster as Resolved.

These shards are now in service.

Nov 4 2016, 5:49 PM · Ops, Phacility
epriestley added a comment to T11820: Provision and deploy new 007/008 shards in the Phacility cluster.

Provisioning completed, now deploying.

Nov 4 2016, 5:22 PM · Ops, Phacility
epriestley edited the content of Adding Hardware.
Nov 4 2016, 5:11 PM
epriestley edited the content of Phacility Cluster Devices.
Nov 4 2016, 5:10 PM
epriestley added a comment to T11820: Provision and deploy new 007/008 shards in the Phacility cluster.

Starting this now.

Nov 4 2016, 5:07 PM · Ops, Phacility
epriestley created T11820: Provision and deploy new 007/008 shards in the Phacility cluster.
Nov 4 2016, 4:57 PM · Ops, Phacility
epriestley closed T11812: "Create a Paste" button on welcome page doesn't work as Resolved by committing Restricted Diffusion Commit.
Nov 4 2016, 4:51 PM · Paste, Bug Report
stevex added a comment to T11817: Configuration issue MySQL max allowed packet does not mention preferred value.
Nov 4 2016, 2:02 PM · Setup, Bug Report
stevex added a comment to T11817: Configuration issue MySQL max allowed packet does not mention preferred value.
  1. Why is there a 2 in the middle of all that? https://xkcd.com/1530/
Nov 4 2016, 2:02 PM · Setup, Bug Report
gou1 updated the answer details for Q398: Arc patch fails: EXCEPTION: (ConduitClientException) ERR-INVALID-AUTH: Unknown Error (Answer 395).
Nov 4 2016, 11:35 AM
gou1 updated the answer details for Q398: Arc patch fails: EXCEPTION: (ConduitClientException) ERR-INVALID-AUTH: Unknown Error (Answer 395).
Nov 4 2016, 11:35 AM
cinek created T11819: View for events a week, month a year in advance.
Nov 4 2016, 8:20 AM · Calendar, Feature Request
• Gadget0624 added a watcher for Community: • Gadget0624.
Nov 4 2016, 5:46 AM
• Gadget0624 added a watcher for Bug Report: • Gadget0624.
Nov 4 2016, 5:30 AM
cspeckmim added a comment to T9548: Support Mercurial's bundle2 wire protocol.

As a user of both Phabricator and Mercurial, opening up HTTP isn't an option we want to consider and would instead stick to having the repository hosted elsewhere.

Nov 4 2016, 3:50 AM · Diffusion, Mercurial
cspeckmim added a comment to T11816: Calendar: Feedback and Suggestions.

Ok - it looks like running through the upgrade process to master again likely resolved the schema issues I had~

Nov 4 2016, 3:34 AM · Restricted Project, Calendar
cspeckmim added a comment to T11816: Calendar: Feedback and Suggestions.

I think this would be a new feature request altogether for the calendar events, but it looks like they aren't interoperable with email. I'm guessing this is intentional for the first version or so of calendar so as to not widen the scope of the project as well as from a security standpoint to avoid leaking emails.

Nov 4 2016, 3:30 AM · Restricted Project, Calendar
cspeckmim added a comment to T5391: Support custom fields in 'Export to Excel'.

If it helps anyone, I've been using this extension to allow exporting tasks with custom fields as well as the workboard column. Please read the comment at the top of it for full details:

Nov 4 2016, 3:23 AM · Data Exporters
epriestley added a comment to T11816: Calendar: Feedback and Suggestions.

Yeah, test on master -- there's a ton of stuff fixed there that's still broken on stable.

Nov 4 2016, 3:05 AM · Restricted Project, Calendar
epriestley added a comment to T9548: Support Mercurial's bundle2 wire protocol.

Today, we already decode the SSH wire protocol and figure out what's going on inside it up to the bundle2 stuff -- here's the, uh, "protocol spec":

Nov 4 2016, 2:59 AM · Diffusion, Mercurial
cspeckmim added a comment to T11816: Calendar: Feedback and Suggestions.

For users testing would you prefer we go based of master instead of stable? If so I'll have to figure out why the upgrade stuff wasn't working. However from the same instance above:

Nov 4 2016, 2:43 AM · Restricted Project, Calendar
cspeckmim added a comment to T11816: Calendar: Feedback and Suggestions.

Sorry, not clicking "Config". It was clicking "Edit Policies" after clicking "Config"

Nov 4 2016, 2:31 AM · Restricted Project, Calendar
cspeckmim added a comment to T11816: Calendar: Feedback and Suggestions.

I got this exception after turning on Calendar and clicking "Config" for the application:

Nov 4 2016, 2:31 AM · Restricted Project, Calendar
indygreg added a comment to T9548: Support Mercurial's bundle2 wire protocol.

It should be possible to determine whether an operation is read or write by the command name: a command either performs writes or it doesn't. The only write commands you should see are unbundle and pushkey. While it might be possible for batch to contain pushkey operations, I don't think that's done today (but I'd have to audit the code to be sure). One thing you should be able to rely on is the HTTP method: GET requests should never perform any significant writes (although some cache files may be written to as a result of resolving data, but that shouldn't be important). It should be perfectly valid to treat GET and POST differently. Although if you route requests to different endpoints within the same TCP/HTTP stream, inconsistent state of a read-only mirror from a master could lead to race conditions (e.g. push fails because a mirror is out of sync). If you route by HTTP request method, you should not need to know anything about the Mercurial wire protocol.

Nov 4 2016, 2:23 AM · Diffusion, Mercurial
cspeckmim added a comment to T11817: Configuration issue MySQL max allowed packet does not mention preferred value.

There's also a 6

Nov 4 2016, 2:11 AM · Setup, Bug Report

Nov 3 2016

z.line.aliev added a watcher for Mobile: z.line.aliev.
Nov 3 2016, 9:33 PM
epriestley created T11818: Phacility `notify` tier is pooled, but tries to load database configuration on restart.
Nov 3 2016, 9:04 PM · Aphlict, Ops, Phacility
epriestley closed T11815: Rotate *.phacility.com SSL certificate as Resolved.

I've rotated the certificates on lb, alb, and notify. One minor notify issue that I'll file separately.

Nov 3 2016, 9:00 PM · Phacility, Ops
polybuildr added a comment to T11817: Configuration issue MySQL max allowed packet does not mention preferred value.

Two questions come to mind.

Nov 3 2016, 8:25 PM · Setup, Bug Report
Mnkras added a comment to T11815: Rotate *.phacility.com SSL certificate.

Nov 3 2016, 8:23 PM · Phacility, Ops
epriestley added a comment to T11817: Configuration issue MySQL max allowed packet does not mention preferred value.

As a workaround, the recommended value is 9999999999999999999999999999999999996999999999999999999999929999999999999.

Nov 3 2016, 8:20 PM · Setup, Bug Report
polybuildr created T11817: Configuration issue MySQL max allowed packet does not mention preferred value.
Nov 3 2016, 7:59 PM · Setup, Bug Report
rencris awarded T7930: Let Calendar provide date services to other applications a Love token.
Nov 3 2016, 7:08 PM · Calendar
epriestley moved T11816: Calendar: Feedback and Suggestions from Backlog to Unprototype (v1) on the Calendar board.
Nov 3 2016, 6:55 PM · Restricted Project, Calendar
epriestley added a project to T11816: Calendar: Feedback and Suggestions: Calendar.
Nov 3 2016, 6:55 PM · Restricted Project, Calendar
epriestley created T11816: Calendar: Feedback and Suggestions.
Nov 3 2016, 6:55 PM · Restricted Project, Calendar
epriestley closed T8052: Calendar feed story should include description of event as Wontfix.

I'm just going to WONTFIX this for now since Maniphest and Differential don't show descriptions either and it's not clear to me that event descriptions are significantly more valuable than task/revision/etc descriptions. Open to changing this, but we should either change it everywhere or have some consistent rule for when they do/don't show.

Nov 3 2016, 6:54 PM · Calendar
epriestley created T11815: Rotate *.phacility.com SSL certificate.
Nov 3 2016, 6:29 PM · Phacility, Ops
epriestley edited projects for T11813: "Can't parse an empty diff!" in Differential when ignoring most whitespace changes, added: Bug Report (Needs Information); removed Bug Report.

I can't reproduce this by following the steps provided. Here's what I did:

Nov 3 2016, 6:27 PM · Bug Report (Needs Information)
epriestley added a revision to T11812: "Create a Paste" button on welcome page doesn't work: Unknown Object (Differential Revision).
Nov 3 2016, 6:24 PM · Paste, Bug Report
adam93 added a watcher for Audit: adam93.
Nov 3 2016, 2:58 PM
chad closed T11814: testtt as Spite.
Nov 3 2016, 2:48 PM · Bug Report
• mowgef created T11814: testtt.
Nov 3 2016, 2:41 PM · Bug Report
jmc7tp created T11813: "Can't parse an empty diff!" in Differential when ignoring most whitespace changes.
Nov 3 2016, 1:51 PM · Bug Report (Needs Information)
shandor added a comment to T10881: git diff parsing fails with --submodule=log.

Just encountered this problem on my setup too.

Nov 3 2016, 1:04 PM · Contributor Onboarding, Arcanist, Bug Report
NMeral awarded T9640: Make Phabricator compatible with PHP7 a Like token.
Nov 3 2016, 7:35 AM · Prioritized, Restricted Project, Infrastructure
tjgould created T11812: "Create a Paste" button on welcome page doesn't work.
Nov 3 2016, 2:04 AM · Paste, Bug Report

Nov 2 2016

epriestley updated the task description for T11809: Calendar v1 Errata Mark II.
Nov 2 2016, 11:15 PM · Calendar
epriestley added a revision to T11809: Calendar v1 Errata Mark II: Unknown Object (Differential Revision).
Nov 2 2016, 10:43 PM · Calendar
epriestley renamed T11792: Remove "No Highlighting" mode from Diffusion from line-linking fails silently when user's set to "no highlighting" to Remove "No Highlighting" mode from Diffusion.
Nov 2 2016, 9:04 PM · Diffusion, Bug Report
epriestley updated the task description for T11809: Calendar v1 Errata Mark II.
Nov 2 2016, 9:00 PM · Calendar
epriestley added a revision to T11809: Calendar v1 Errata Mark II: Unknown Object (Differential Revision).
Nov 2 2016, 8:44 PM · Calendar
epriestley added a revision to T11809: Calendar v1 Errata Mark II: Restricted Differential Revision.
Nov 2 2016, 8:12 PM · Calendar
epriestley closed T11808: Calendar has cursor paging issue on import sources as Resolved.

This appears to legitimately be fixed, now.

Nov 2 2016, 7:57 PM · Calendar
epriestley added a revision to T11808: Calendar has cursor paging issue on import sources: Unknown Object (Differential Revision).
Nov 2 2016, 6:34 PM · Calendar
epriestley added a comment to T11808: Calendar has cursor paging issue on import sources.

I finally got this reproducing locally, at least.

Nov 2 2016, 6:19 PM · Calendar
epriestley updated the task description for T11809: Calendar v1 Errata Mark II.
Nov 2 2016, 6:09 PM · Calendar
epriestley added a revision to T11809: Calendar v1 Errata Mark II: Unknown Object (Differential Revision).
Nov 2 2016, 6:06 PM · Calendar
epriestley reopened T11808: Calendar has cursor paging issue on import sources as "Open".

Gah.

Nov 2 2016, 6:03 PM · Calendar
epriestley updated the task description for T11809: Calendar v1 Errata Mark II.
Nov 2 2016, 5:43 PM · Calendar
epriestley updated the task description for T11809: Calendar v1 Errata Mark II.
Nov 2 2016, 5:36 PM · Calendar
epriestley updated the task description for T11809: Calendar v1 Errata Mark II.
Nov 2 2016, 5:33 PM · Calendar
epriestley added a revision to T11809: Calendar v1 Errata Mark II: Unknown Object (Differential Revision).
Nov 2 2016, 5:16 PM · Calendar
epriestley updated the task description for T11809: Calendar v1 Errata Mark II.
Nov 2 2016, 4:57 PM · Calendar
epriestley added a comment to T9848: CustomLinter Fails.

If it is impossible to reproduce this issue without writing custom code, we won't accept a patch for it.

Nov 2 2016, 4:56 PM · Lint
epriestley added a project to T11810: Live log output from harbormaster: Harbormaster.
Nov 2 2016, 4:53 PM · Harbormaster, Feature Request
epriestley added a revision to T11809: Calendar v1 Errata Mark II: Unknown Object (Differential Revision).
Nov 2 2016, 4:53 PM · Calendar
epriestley closed T11811: test as Invalid.
Nov 2 2016, 3:17 PM
plonk created T11810: Live log output from harbormaster.
Nov 2 2016, 2:57 PM · Harbormaster, Feature Request
cspeckmim placed T9886: Add Java linters, checkstyle and PMD up for grabs.
Nov 2 2016, 4:26 AM · Restricted Project, Arcanist, Lint
tjstum added a comment to T9848: CustomLinter Fails.

I know that upstream can't offer support for fixing this, but would you be at all willing to accept a patch that addresses this issue?

Nov 2 2016, 2:26 AM · Lint

Nov 1 2016

epriestley added a revision to T11809: Calendar v1 Errata Mark II: Unknown Object (Differential Revision).
Nov 1 2016, 11:28 PM · Calendar
epriestley added a revision to T11809: Calendar v1 Errata Mark II: Unknown Object (Differential Revision).
Nov 1 2016, 10:52 PM · Calendar
epriestley closed T11808: Calendar has cursor paging issue on import sources as Resolved.

I "fixed" this by deleting the data more aggressively and reloading the import. I couldn't reproduce this locally so I think it was a transient issue with an older import bug.

Nov 1 2016, 10:09 PM · Calendar
epriestley added a comment to T11808: Calendar has cursor paging issue on import sources.

It seems that we're somehow importing events so they end up as their own parents.

Nov 1 2016, 10:03 PM · Calendar
preachermanx awarded T8787: Add support for U2F MFA once browser implementations improve and compatible hardware is more widely available a Like token.
Nov 1 2016, 9:56 PM · Haskell.org, Auth
epriestley updated the task description for T11809: Calendar v1 Errata Mark II.
Nov 1 2016, 9:51 PM · Calendar
epriestley reopened T11808: Calendar has cursor paging issue on import sources as "Open".

That changed the stack trace but didn't fix the issue so I probably need to not cheat.

Nov 1 2016, 9:45 PM · Calendar
epriestley closed T11808: Calendar has cursor paging issue on import sources as Resolved by committing Restricted Diffusion Commit.
Nov 1 2016, 9:40 PM · Calendar
epriestley renamed T11809: Calendar v1 Errata Mark II from Calendar v1 Errata to Calendar v1 Errata Mark II.
Nov 1 2016, 9:31 PM · Calendar
epriestley added a subtask for T7924: Unprototype Calendar (v1): T11809: Calendar v1 Errata Mark II.
Nov 1 2016, 9:31 PM · Restricted Project, Prioritized, Calendar
epriestley added a parent task for T11809: Calendar v1 Errata Mark II: T7924: Unprototype Calendar (v1).
Nov 1 2016, 9:31 PM · Calendar