Page MenuHomePhabricator
Feed All Stories

Nov 1 2016

epriestley created T11809: Calendar v1 Errata Mark II.
Nov 1 2016, 9:30 PM · Calendar
epriestley added a revision to T11808: Calendar has cursor paging issue on import sources: Unknown Object (Differential Revision).
Nov 1 2016, 8:59 PM · Calendar
epriestley added a comment to T11808: Calendar has cursor paging issue on import sources.

I can't reproduce this locally and I'm not really sure what's up (bad/weird import, maybe? But no issues importing the same source locally), so I'm just going to cheat my way through it at least for the moment.

Nov 1 2016, 8:56 PM · Calendar
epriestley added a comment to T11808: Calendar has cursor paging issue on import sources.

Here's the trace:

Nov 1 2016, 8:44 PM · Calendar
epriestley created T11808: Calendar has cursor paging issue on import sources.
Nov 1 2016, 8:43 PM · Calendar
epriestley closed T11805: Use PhutilCalendarDateTime or similar for internal Calendar date-time transactions as Resolved by committing Restricted Diffusion Commit.
Nov 1 2016, 8:36 PM · Calendar
sgrimm added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

I'm specifically interested in the arc diff --try part of this and would want that to be the configurable as the default behavior. For an installation that's using things like CircleCI integration to run tests asynchronously on a build server, it seems very plausible that reviewers will sometimes fail to notice that tests haven't finished running yet, which will lead to people landing broken code.

Nov 1 2016, 8:23 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T11805: Use PhutilCalendarDateTime or similar for internal Calendar date-time transactions: Unknown Object (Differential Revision).
Nov 1 2016, 8:22 PM · Calendar
epriestley added a revision to T11805: Use PhutilCalendarDateTime or similar for internal Calendar date-time transactions: Unknown Object (Differential Revision).
Nov 1 2016, 8:07 PM · Calendar
avivey merged T11807: Aborted status in Harbormaster into T10746: Aborted build in Harbormaster still shows as building in Diffusion.
Nov 1 2016, 6:31 PM · Restricted Project, Harbormaster, Bug Report
avivey merged task T11807: Aborted status in Harbormaster into T10746: Aborted build in Harbormaster still shows as building in Diffusion.
Nov 1 2016, 6:31 PM · Feature Request
epriestley closed T7931: Create Calendar triggers which notify users before meetings, a subtask of T7924: Unprototype Calendar (v1), as Resolved.
Nov 1 2016, 5:47 PM · Restricted Project, Prioritized, Calendar
epriestley closed T7931: Create Calendar triggers which notify users before meetings as Resolved.

These are very much proof-of-concept for now, but should technically work after D16784. Expected behavior now:

Nov 1 2016, 5:47 PM · Calendar
rphl awarded M1466: Phriction v3 a Like token.
Nov 1 2016, 5:45 PM
epriestley added a revision to T7931: Create Calendar triggers which notify users before meetings: Unknown Object (Differential Revision).
Nov 1 2016, 5:40 PM · Calendar
epriestley added a revision to T7931: Create Calendar triggers which notify users before meetings: Unknown Object (Differential Revision).
Nov 1 2016, 4:35 PM · Calendar
adam93 added a comment to T4026: Add relations between commits.

Also interested in this. Our team plans on using the audit tool for code reviews, it be good if when a developer has made any suggested changes and re-committed that the old open audit could be closed/linked to the latest commit rather than having to comment on the old one with a link to the changed copy and just closing the old one manually.

Nov 1 2016, 1:57 PM · Restricted Project, Audit
adam93 awarded T4026: Add relations between commits a Like token.
Nov 1 2016, 1:55 PM · Restricted Project, Audit
rabahmeradi awarded T11807: Aborted status in Harbormaster a Like token.
Nov 1 2016, 12:36 PM · Feature Request
kiptonui created T11807: Aborted status in Harbormaster.
Nov 1 2016, 10:22 AM · Feature Request
flippingtables added a comment to T11785: Clicking on images for lightbox won't load with Persistent Chat enabled.

Could phabricator.base-uri setting affect this? Our install is accessed via http://phab.domain.com:port/.

Nov 1 2016, 8:00 AM · Bug Report, Quicksand, Conpherence (v4)

Oct 31 2016

epriestley closed T11804: Straighten out canceling and editing instanced events in Calendar as Resolved by committing Restricted Diffusion Commit.
Oct 31 2016, 11:38 PM · Calendar
epriestley added a revision to T11804: Straighten out canceling and editing instanced events in Calendar: Unknown Object (Differential Revision).
Oct 31 2016, 10:18 PM · Calendar
chad closed T11806: prueba as Spite.
Oct 31 2016, 9:49 PM · Feature Request
• xanty88 created T11806: prueba.
Oct 31 2016, 9:44 PM · Feature Request
epriestley added a revision to T11804: Straighten out canceling and editing instanced events in Calendar: Unknown Object (Differential Revision).
Oct 31 2016, 9:12 PM · Calendar
epriestley added a revision to T11804: Straighten out canceling and editing instanced events in Calendar: Unknown Object (Differential Revision).
Oct 31 2016, 8:43 PM · Calendar
epriestley added a revision to T11804: Straighten out canceling and editing instanced events in Calendar: Unknown Object (Differential Revision).
Oct 31 2016, 8:40 PM · Calendar
chad added a comment to T11803: Calendar doesn't show last day of period of "All Day Events".

It may surprise us how much people use it.

Oct 31 2016, 7:05 PM · Calendar, Bug Report
epriestley closed T11803: Calendar doesn't show last day of period of "All Day Events" as Resolved.

I guess we're just accepting Calendar bugs in general now since I don't have a ton of known broken stuff left on my radar. I was aware of this one; D16777 should fix it.

Oct 31 2016, 6:56 PM · Calendar, Bug Report
epriestley claimed T7924: Unprototype Calendar (v1).
Oct 31 2016, 6:22 PM · Restricted Project, Prioritized, Calendar
epriestley closed T11326: Improve Calendar v1 Design/UI/UX, a subtask of T7924: Unprototype Calendar (v1), as Resolved.
Oct 31 2016, 6:21 PM · Restricted Project, Prioritized, Calendar
epriestley closed T11326: Improve Calendar v1 Design/UI/UX as Resolved.

I got 12 quest points. Level up!

Oct 31 2016, 6:20 PM · Design, Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Oct 31 2016, 6:20 PM · Design, Calendar
epriestley created T11805: Use PhutilCalendarDateTime or similar for internal Calendar date-time transactions.
Oct 31 2016, 6:20 PM · Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Oct 31 2016, 6:18 PM · Design, Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Unknown Object (Differential Revision).
Oct 31 2016, 6:18 PM · Design, Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Oct 31 2016, 5:51 PM · Design, Calendar
epriestley created T11804: Straighten out canceling and editing instanced events in Calendar.
Oct 31 2016, 5:51 PM · Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Unknown Object (Differential Revision).
Oct 31 2016, 5:14 PM · Design, Calendar
chad added a comment to M1461: Timeline / Remarkup Cleanup.

I plan to start working on new comment/action UI here this week. Probably. Maybe.

Oct 31 2016, 4:31 PM
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Oct 31 2016, 4:14 PM · Design, Calendar
chad added a comment to T11803: Calendar doesn't show last day of period of "All Day Events".

Please be sure to update Phabricator before filing a bug report.

Oct 31 2016, 4:03 PM · Calendar, Bug Report
samr created T11803: Calendar doesn't show last day of period of "All Day Events".
Oct 31 2016, 3:46 PM · Calendar, Bug Report
epriestley closed T11794: OAuth Server Doesn't Handle Client ID and Secret in HTTP Basic Auth as Resolved by committing Restricted Diffusion Commit.
Oct 31 2016, 3:23 PM · OAuthServer, Bug Report
epriestley added a member for Community: wrl.
Oct 31 2016, 3:21 PM
epriestley edited this Badge.
Oct 31 2016, 3:21 PM
adam93 added a comment to T11801: Calendar: ICS Import Errata.

@rabahmeradi So it was, shortly afer reporting! Thanks.

Oct 31 2016, 1:48 PM · Bug Report, Calendar
chad added a comment to T11785: Clicking on images for lightbox won't load with Persistent Chat enabled.
Oct 31 2016, 1:48 PM · Bug Report, Quicksand, Conpherence (v4)
chad added a comment to T11785: Clicking on images for lightbox won't load with Persistent Chat enabled.

Our users can confirm this behavior. With active persistent chat, the Lightbox is not working. If it is disabled, its working as expected.

Oct 31 2016, 1:40 PM · Bug Report, Quicksand, Conpherence (v4)
chad awarded T11801: Calendar: ICS Import Errata a Baby Tequila token.
Oct 31 2016, 1:38 PM · Bug Report, Calendar
rabahmeradi added Q507: Integrate with custom oauth provider (Answer 466).
Oct 31 2016, 12:55 PM
• nashrafeeg updated Q507: Integrate with custom oauth provider from to Integrate with custom oauth provider .
Oct 31 2016, 12:20 PM · Auth
rphl added a comment to T11785: Clicking on images for lightbox won't load with Persistent Chat enabled.

Our users can confirm this behavior. With active persistent chat, the Lightbox is not working. If it is disabled, its working as expected.

Oct 31 2016, 10:52 AM · Bug Report, Quicksand, Conpherence (v4)
rabahmeradi added a comment to T11801: Calendar: ICS Import Errata.

Mentioned in chat but just to keep it logged. Importing an ics file with the following RRULE (RRULE:FREQ=WEEKLY;BYDAY=TH;INTERVAL=2) works as expected opening in Microsoft Outlook, but gives the following error in Phabricator upon import "RRULE INTERVAL "2" is invalid: interval must be an integer."

As @epriestley said in the general chat "We're missing an (int) cast in PhutilRecurrenceRule::newFromRRULE() on INTERVAL and probably COUNT".

Oct 31 2016, 10:40 AM · Bug Report, Calendar
adam93 awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Oct 31 2016, 10:08 AM · Workboards (v3), Restricted Project
adam93 added a comment to T11801: Calendar: ICS Import Errata.

Mentioned in chat but just to keep it logged. Importing an ics file with the following RRULE (RRULE:FREQ=WEEKLY;BYDAY=TH;INTERVAL=2) works as expected opening in Microsoft Outlook, but gives the following error in Phabricator upon import "RRULE INTERVAL "2" is invalid: interval must be an integer."

Oct 31 2016, 9:18 AM · Bug Report, Calendar
cspeckmim added a comment to T9548: Support Mercurial's bundle2 wire protocol.

@indygreg - Thanks for reaching out and discussing a way forward. I am not on the phabricator team but I do have an interest in its integration capabilities with mercurial. At best I might be able to summarize my understanding of some of phabricator's needs based on the history of this task, but I do not feel I could properly represent them on mercurial's mailing-list or wiki. For hosting repositories I believe this task would require needing to know if the mercurial operation is read or write -- the two primary reasons being read/write access control and cluster picking.

Oct 31 2016, 2:20 AM · Diffusion, Mercurial
chad closed T11793: Multi-currency options for Phortune as Wontfix.

Thanks for the suggestion but we have no current plans to un-prototype Phortune. Fork / patch as you need locally.

Oct 31 2016, 12:42 AM · Phortune, Feature Request

Oct 30 2016

epriestley moved T11801: Calendar: ICS Import Errata from Backlog to Unprototype (v1) on the Calendar board.
Oct 30 2016, 5:57 PM · Bug Report, Calendar
epriestley created T11801: Calendar: ICS Import Errata.
Oct 30 2016, 5:56 PM · Bug Report, Calendar
epriestley closed T10747: Import and export ICS from Calendar, a subtask of T7929: Integrate Calendar with external systems, as Resolved.
Oct 30 2016, 5:45 PM · Calendar
epriestley closed T10747: Import and export ICS from Calendar as Resolved.

Duplicate thing filed in T11800.

Oct 30 2016, 5:45 PM · Restricted Project, Prioritized, Calendar
epriestley created T11800: When duplicate events are imported into Calendar, show viewers only the best version.
Oct 30 2016, 5:45 PM · Calendar
epriestley added a comment to T10747: Import and export ICS from Calendar.

I'm going to file the duplicate import thing as a separate task since it probably won't come up for a while and close this out.

Oct 30 2016, 5:43 PM · Restricted Project, Prioritized, Calendar
indygreg added a comment to T9548: Support Mercurial's bundle2 wire protocol.

While I'm hesitant to throw stones here and don't really have any context on bundle2 or the wire protocol in general and there may be plenty of reasons that it works like it does, my general impression is that the Mercurial wire protocol is significantly under-designed, and is now on at least the 3rd and possibly 4th iteration of hacks to try to address the lack of actual protocol design.

Oct 30 2016, 5:10 PM · Diffusion, Mercurial
epriestley added a comment to T10747: Import and export ICS from Calendar.

(Google API integration is covered by T2334 -- you can already interact with Google Calendar via ICS files, but that will add support for using the API instead.)

Oct 30 2016, 4:29 PM · Restricted Project, Prioritized, Calendar
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 30 2016, 4:21 PM · Restricted Project, Prioritized, Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Oct 30 2016, 4:21 PM · Design, Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Unknown Object (Differential Revision).
Oct 30 2016, 4:17 PM · Design, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 30 2016, 4:13 PM · Restricted Project, Prioritized, Calendar
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 30 2016, 3:45 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10747: Import and export ICS from Calendar.

The Gmail/ICS integration seems to actually work OK in practice, here's an event from this install working (modulo some stuff like us not exporting a host/organizer yet):

Oct 30 2016, 3:45 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 30 2016, 3:22 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 30 2016, 3:14 PM · Restricted Project, Prioritized, Calendar
chad added a comment to T5267: Localize Phabricator.

I would subscribe to the Paste, and spend 20 seconds updating the file if it changes. Like I mentioned before, this task has already been prioritized and we're not going to work on it until other things in the prioritization queue have been completed. I think self-maintaining is a reasonable work-around.

Oct 30 2016, 7:27 AM · Prioritized, Localization
MZMcBride added a comment to T5267: Localize Phabricator.

It looks like T10814, specifically T10814#170824, provide some useful info. Thank you for that link!

Oct 30 2016, 4:40 AM · Prioritized, Localization
Gryllida added a comment to T5267: Localize Phabricator.

I would like to submit a translation to upstream. Where do I start?

Oct 30 2016, 3:41 AM · Prioritized, Localization
chad added a comment to T5267: Localize Phabricator.

P1792 is the German example.

Oct 30 2016, 1:47 AM · Prioritized, Localization
chad added a comment to T5267: Localize Phabricator.

If you want to pursue i18n ahead of the upstream, T10814 has some walkthrough I did with another user. It's basically, dump strings into a file, translate, add to src/extensions. https://secure.phabricator.com/w/community_resources/#translations has examples of Chinese and German users have shared here.

Oct 30 2016, 1:46 AM · Prioritized, Localization
chad added a comment to T5267: Localize Phabricator.

Everything you mention is covered by this task.

Oct 30 2016, 1:39 AM · Prioritized, Localization
MZMcBride added a comment to T5267: Localize Phabricator.
In T5267#198537, @chad wrote:

The current status is the infrastructure is provided, but the translations are not (you need to either translate it yourself, or check the community wiki page here for community contributed translations). Then install said translations locally.

Oct 30 2016, 1:34 AM · Prioritized, Localization
chad added a comment to T5267: Localize Phabricator.

The current status is the infrastructure is provided, but the translations are not (you need to either translate it yourself, or check the community wiki page here for community contributed translations). Then install said translations locally.

Oct 30 2016, 1:04 AM · Prioritized, Localization
MZMcBride added a comment to T5267: Localize Phabricator.

I'd like to get this task un-stuck. I'm unclear on Phabricator's current internationalization capabilities.

Oct 30 2016, 12:58 AM · Prioritized, Localization
epriestley added a comment to T11799: Garbage tool complains about invalid translation on 'set-policy' command.

This should be fixed in HEAD of master. Thanks for the report!

Oct 30 2016, 12:13 AM · Bug Report
epriestley closed T11799: Garbage tool complains about invalid translation on 'set-policy' command as Resolved by committing Restricted Diffusion Commit.
Oct 30 2016, 12:12 AM · Bug Report
epriestley added a revision to T11799: Garbage tool complains about invalid translation on 'set-policy' command: Unknown Object (Differential Revision).
Oct 30 2016, 12:01 AM · Bug Report

Oct 29 2016

epriestley added a comment to T7607: Invoicing emails probably need some work.

We can probably just use the merchant name for now. I could maybe imagine some "International Business Machines, Inc" vs "IBM" stuff down the line, but no immediate issue for "Phacility".

Oct 29 2016, 5:05 PM · Phortune, Phacility
chad added a comment to T7607: Invoicing emails probably need some work.

Do we need a new field for subjects or is Merchant Name enough? Not sure both are needed.

Oct 29 2016, 5:03 PM · Phortune, Phacility
rayzyar added a comment to T11517: arc lint missed some error reported from the golint.

seems this is due to I didn't add the --lintall option,
the change is one line removal (existing file at the base commit)
thus it's considered as not concerned, but it is concerned actually because I didn't remove the entire function

Oct 29 2016, 4:55 PM · Bug Report (Needs Information), Arcanist, Lint
seungrye closed Q506: wrong question. as invalid.
Oct 29 2016, 1:49 PM
seungrye updated the answer details for Q506: wrong question. (Answer 465).
Oct 29 2016, 1:49 PM
seungrye updated Q506: wrong question. from template function 에서 template specialized member function 호출시 발생하는 에러. to wrong question..
Oct 29 2016, 1:48 PM
seungrye added Q506: wrong question. (Answer 465).
Oct 29 2016, 1:47 PM
seungrye updated Q506: wrong question. from to template function 에서 template specialized member function 호출시 발생하는 에러..
Oct 29 2016, 1:45 PM
michelkaeser awarded T4853: A "tracked time per project" would be really usefull for project manager. a Like token.
Oct 29 2016, 12:57 PM · Phrequent
michelkaeser awarded T5149: Allow to add and edit Phrequent entries manually a Like token.
Oct 29 2016, 12:56 PM · Phrequent
michelkaeser updated subscribers of T3179: Importing data from external systems (like GitHub, JIRA, Trac, Asana, Trello, etc.).

Trac wiki import to Phabricator's Phriction.

Based on svemir's anser in https://secure.phabricator.com/Q12 a not to nice not perfect but more then nothing:

https://github.com/lfarkas/phabricator/blob/master/scripts/util/trac_wiki_import.php

Oct 29 2016, 12:52 PM · Guides, Doorkeeper
rencris created T11799: Garbage tool complains about invalid translation on 'set-policy' command.
Oct 29 2016, 8:45 AM · Bug Report
eadler added a project to T4953: If arc diff is run twice on exact same commit, will upload new diff to differential: Restricted Project.
Oct 29 2016, 7:45 AM · Restricted Project, Arcanist, Wikimedia