Page MenuHomePhabricator
Feed All Stories

Jul 14 2016

greggrossmeier added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).
In T4788#185851, @chad wrote:

If you have more than 100 subtasks, the task should probably be a project so it can be properly organized.

Jul 14 2016, 2:55 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
Danny_B added a comment to T11328: Show more info about restricted tasks in task dependecy graph.

And what is the intention behind that? None of those requested information are sensitive.

Jul 14 2016, 2:28 PM · Maniphest, Feature Request
chad added a comment to T11325: Guest users in a corporate environment.

I understand the point, but then, what do you think about "automatically" assign users to a space depending on the autentication they used to login? (i.e. only who autenticated with LDAP will belong to internal users)

Jul 14 2016, 2:17 PM · Feature Request
stevex added a comment to T11325: Guest users in a corporate environment.

I understand the point, but then, what do you think about "automatically" assign users to a space depending on the autentication they used to login? (i.e. only who autenticated with LDAP will belong to internal users)

Jul 14 2016, 2:13 PM · Feature Request
epriestley closed T11327: Creating events on Calendar broken as Invalid.

Upgrade.

Jul 14 2016, 1:59 PM · Bug Report
epriestley closed T11328: Show more info about restricted tasks in task dependecy graph as Wontfix.

It's intentional that you can not see information about tasks you don't have permission to see.

Jul 14 2016, 1:52 PM · Maniphest, Feature Request
chad added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

If you have more than 100 subtasks, the task should probably be a project so it can be properly organized.

Jul 14 2016, 1:49 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
Danny_B added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

Also, before that is done, rather than showing "Task graph too large to display ..." message, have fallback to the old plain list of tasks. Therefore the information will still be available, but just simply not provided as fancy...

Jul 14 2016, 1:45 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
Danny_B added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

Re the limiting to hardcoded 100 nodes without any criteria:

Jul 14 2016, 1:40 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
Danny_B created T11328: Show more info about restricted tasks in task dependecy graph.
Jul 14 2016, 1:34 PM · Maniphest, Feature Request
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Jul 14 2016, 1:04 PM · Design, Calendar
fernofry created T11327: Creating events on Calendar broken.
Jul 14 2016, 1:02 PM · Bug Report
epriestley closed T11325: Guest users in a corporate environment as Resolved.

https://secure.phabricator.com/book/phabricator/article/spaces/

Jul 14 2016, 12:47 PM · Feature Request
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Unknown Object (Differential Revision).
Jul 14 2016, 12:28 PM · Design, Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Jul 14 2016, 12:12 PM · Design, Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Jul 14 2016, 12:11 PM · Design, Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Unknown Object (Differential Revision).
Jul 14 2016, 12:08 PM · Design, Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Jul 14 2016, 11:53 AM · Design, Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Unknown Object (Differential Revision).
Jul 14 2016, 11:52 AM · Design, Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Unknown Object (Differential Revision).
Jul 14 2016, 11:47 AM · Design, Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Jul 14 2016, 11:44 AM · Design, Calendar
epriestley created T11326: Improve Calendar v1 Design/UI/UX.
Jul 14 2016, 11:43 AM · Design, Calendar
stevex updated the task description for T11325: Guest users in a corporate environment.
Jul 14 2016, 11:42 AM · Feature Request
timor awarded T5793: Add support for personal workboards a Like token.
Jul 14 2016, 11:40 AM · User Delight, Wikimedia, Workboards
stevex renamed T11325: Guest users in a corporate environment from Guest user to Guest users in a corporate environment.
Jul 14 2016, 11:37 AM · Feature Request
stevex created T11325: Guest users in a corporate environment.
Jul 14 2016, 11:36 AM · Feature Request
epriestley moved T7939: Support Herald rules for Calendar events from Future Work (v2+) to Unprototype (v1) on the Calendar board.
Jul 14 2016, 11:18 AM · Herald, Calendar
epriestley closed T11323: Test1 as Spite.
Jul 14 2016, 10:33 AM
epriestley closed T11324: Test1 as Spite.
Jul 14 2016, 10:33 AM
saggid added a comment to T8305: Clicking disclosure triangle next to transactions which only add inline comments has no effect in Pholio.

Hello! What you think about make correct behavior while clicking on inline comment thumbnails? Its hard work? I can try to contribute it?

Jul 14 2016, 10:18 AM · Pholio
michal.fuca.fucik added a comment to T5132: Document the special syntax you can use in commit messages to cause effects.

Hey guys, where should I hook my custom parser if I need to add any additional behaviour on 'CodeReviewed' keyword in commit message due to parsing from repository?
Actually I need to mark commit as audited when commit message contains previously specified string.

Jul 14 2016, 10:13 AM · Guides, Diffusion
saggid added an inline comment to M1460: Project - Grey Background.
Jul 14 2016, 10:02 AM · Projects (v3)
epriestley added a revision to T4788: Allow "Edit Dependencies" both ways (blocking and depending): Unknown Object (Differential Revision).
Jul 14 2016, 4:10 AM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley closed T11322: foo 234 as Spite.
Jul 14 2016, 3:46 AM
chad raised the priority of T11096: Redesign main header / quick create / search from Normal to High.
Jul 14 2016, 3:23 AM · Design
Danny_B added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

The best of the best is of course our https://phabricator.wikimedia.org/T4007 ;-)

Jul 14 2016, 2:36 AM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
20after4 awarded T4788: Allow "Edit Dependencies" both ways (blocking and depending) a Mountain of Wealth token.
Jul 14 2016, 12:38 AM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
20after4 added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).
In T4788#185751, @bd808 wrote:

The task graph can get a bit out of hand -- https://phabricator.wikimedia.org/T2001

Jul 14 2016, 12:38 AM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
bd808 added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

so the UI should still look good given that edge-case.

Understanding the use case is important in choosing how the UI degrades.

Jul 14 2016, 12:29 AM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia

Jul 13 2016

epriestley closed T9224: Probably add "Event Host" and "Event Invitees" Object Policies to Calendar Events as Resolved by committing Restricted Diffusion Commit.
Jul 13 2016, 10:42 PM · Policy, Calendar
epriestley closed T10909: Editable host of the event. as Resolved by committing Restricted Diffusion Commit.
Jul 13 2016, 10:40 PM · Calendar, Feature Request
epriestley closed T9202: Calendar UI doesn't honor user time format preferences in day view as Resolved by committing Restricted Diffusion Commit.
Jul 13 2016, 10:39 PM · Calendar
epriestley closed T8911: Calendar List view sorting happens after limits are applied as Resolved by committing Restricted Diffusion Commit.
Jul 13 2016, 10:39 PM · Calendar
apierritba awarded T10145: Adding a panel to a dashboard multiple times a Heartbreak token.
Jul 13 2016, 10:31 PM · Dashboards (v2), Bug Report
apierritba awarded T10612: Editing a panel causes it to duplicate in dashboard a Piece of Eight token.
Jul 13 2016, 10:27 PM · Dashboards (v2), Bug Report
thoughtpolice added a comment to T11314: Observe Mode + GitHub has weird mail interactions due to pull request refs.

Thanks for listening to my hair-brained schemes. Yeah, the motivation is totally clear to me FWIW, and thinking about it more, I strongly suggest this is related to T9161.

Jul 13 2016, 8:53 PM · Diffusion (v3), Restricted Project, Mail, Haskell.org, Bug Report
epriestley added a revision to T9224: Probably add "Event Host" and "Event Invitees" Object Policies to Calendar Events: Unknown Object (Differential Revision).
Jul 13 2016, 8:04 PM · Policy, Calendar
jdforrester awarded T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies a Party Time token.
Jul 13 2016, 7:47 PM · Maniphest
epriestley added a revision to T10909: Editable host of the event.: Unknown Object (Differential Revision).
Jul 13 2016, 7:38 PM · Calendar, Feature Request
epriestley added a revision to T9224: Probably add "Event Host" and "Event Invitees" Object Policies to Calendar Events: Unknown Object (Differential Revision).
Jul 13 2016, 6:38 PM · Policy, Calendar
epriestley added a revision to T10909: Editable host of the event.: Unknown Object (Differential Revision).
Jul 13 2016, 6:38 PM · Calendar, Feature Request
chad added a comment to T11212: One of our audits is displaying comments from another audit.

Thanks for looking into this further.

Jul 13 2016, 6:33 PM · Quicksand, Audit, Bug Report
chad reopened T11212: One of our audits is displaying comments from another audit as "Open".
Jul 13 2016, 6:21 PM · Quicksand, Audit, Bug Report
anton.vladimirov added a comment to T11212: One of our audits is displaying comments from another audit.

Looks like that fix affects Differential, but not Diffusion? After reading through that bug, I can totally reproduce this on demand in Audit
I have a test instance here that reproduces this problem (both actively able to reproduce and has commits in the database that are exhibiting the behavior already): https://test-kdauzhhtarbi.phacility.com/rLIBdde2f74f2793f0216f0d76618ed335a9c802cfec, but I reproduced it reliably on 3 separate instances now.

Jul 13 2016, 6:13 PM · Quicksand, Audit, Bug Report
epriestley closed T2898: Redesign Calendar for responsive layouts, a subtask of T2334: Implement Google Calendar v3 API into Calendar, as Resolved.
Jul 13 2016, 5:40 PM · Restricted Project, Prioritized, Calendar
epriestley closed T2898: Redesign Calendar for responsive layouts as Resolved.

Calendar needs design work after intervening redesigns, but the views have been responsive for some time.

Jul 13 2016, 5:40 PM · Calendar
epriestley closed T2898: Redesign Calendar for responsive layouts, a subtask of T7941: Figure out what non-list Calendar views we're going to support, as Resolved.
Jul 13 2016, 5:40 PM · Calendar
epriestley claimed T9202: Calendar UI doesn't honor user time format preferences in day view.
Jul 13 2016, 5:34 PM · Calendar
epriestley closed T7944: Add Conduit support to Calendar, a subtask of T7929: Integrate Calendar with external systems, as Resolved.
Jul 13 2016, 5:34 PM · Calendar
epriestley closed T7944: Add Conduit support to Calendar as Resolved.

calendar.event.search is still pretty useless/bare-bones (you don't get very much information back), but we can expand that as use cases arise. We don't have specific needs for this yet.

Jul 13 2016, 5:34 PM · Conduit, Calendar
epriestley moved T8361: Add a "click to see more" link to month view days with more than 15 events. from Runners Up to Unprototype (v1) on the Calendar board.
Jul 13 2016, 5:33 PM · Calendar
epriestley moved T8057: Allow creation of Calendar events by sending mail to an address from Runners Up to Future Work (v2+) on the Calendar board.
Jul 13 2016, 5:33 PM · Calendar
epriestley moved T7931: Create Calendar triggers which notify users before meetings from Runners Up to Future Work (v2+) on the Calendar board.
Jul 13 2016, 5:33 PM · Calendar
epriestley moved T9202: Calendar UI doesn't honor user time format preferences in day view from Backlog to Unprototype (v1) on the Calendar board.
Jul 13 2016, 5:33 PM · Calendar
epriestley moved T8911: Calendar List view sorting happens after limits are applied from Runners Up to Unprototype (v1) on the Calendar board.
Jul 13 2016, 5:33 PM · Calendar
epriestley added a comment to T8057: Allow creation of Calendar events by sending mail to an address.

T8267 briefly discussed the idea of automatically selecting an icon if one isn't provided.

Jul 13 2016, 5:32 PM · Calendar
epriestley closed T8267: Auto-magically assign icons to events where no icon has been set explicitly as Wontfix.

Currently, there's no way to create an event without explicitly selecting an icon, so there's no way to really implement this.

Jul 13 2016, 5:32 PM · Calendar
epriestley closed T8299: Fix Calendar day view in Firefox as Resolved.

This UI needs some cleanup in all browsers after some intervening redesign, but I don't see anything specifically wrong about it in Firefox at HEAD of master.

Jul 13 2016, 5:29 PM · Calendar
epriestley moved T8022: Implement a meeting autoscheduler from Backlog to Future Work (v2+) on the Calendar board.
Jul 13 2016, 5:28 PM · Calendar
epriestley added a revision to T9202: Calendar UI doesn't honor user time format preferences in day view: Unknown Object (Differential Revision).
Jul 13 2016, 5:28 PM · Calendar
epriestley merged T10932: Daily view of calendar uses 12h (am/pm) marking of time, although preferences set to 24h into T9202: Calendar UI doesn't honor user time format preferences in day view.
Jul 13 2016, 5:27 PM · Calendar
epriestley merged task T10932: Daily view of calendar uses 12h (am/pm) marking of time, although preferences set to 24h into T9202: Calendar UI doesn't honor user time format preferences in day view.
Jul 13 2016, 5:27 PM · Calendar, Bug Report
epriestley added a revision to T10932: Daily view of calendar uses 12h (am/pm) marking of time, although preferences set to 24h: Unknown Object (Differential Revision).
Jul 13 2016, 5:27 PM · Calendar, Bug Report
• raphael.palmeira moved T5375: Tokenizers fail in Firefox on Android from Backlog to Icebox on the Android board.
Jul 13 2016, 5:22 PM · Firefox, Android
• raphael.palmeira moved T5375: Tokenizers fail in Firefox on Android from Icebox to Backlog on the Android board.
Jul 13 2016, 5:22 PM · Firefox, Android
epriestley closed T5296: Allow user-defined date format as Resolved.

I'm just going to close this:

Jul 13 2016, 5:16 PM · Calendar, User Delight, User Preferences
epriestley added a revision to T8911: Calendar List view sorting happens after limits are applied: Unknown Object (Differential Revision).
Jul 13 2016, 4:39 PM · Calendar
epriestley closed T7989: Fill any missing gaps in Calendar event invitee statuses. as Wontfix.

We can revisit this later if use cases develop, but we haven't seen any need for it yet.

Jul 13 2016, 3:44 PM · Calendar
epriestley added a revision to T7944: Add Conduit support to Calendar: Unknown Object (Differential Revision).
Jul 13 2016, 3:43 PM · Conduit, Calendar
epriestley closed T10633: Render timezones explicitly in email as Resolved by committing Restricted Diffusion Commit.
Jul 13 2016, 3:32 PM · Calendar, Mail, Countdown, Bug Report
epriestley closed T9275: Move Calendar to EditEngine as Resolved.

This is on EditEngine + Modular Transactions now. There are probably still some remaining issues I didn't catch.

Jul 13 2016, 3:03 PM · ApplicationEditor, Policy, Calendar
epriestley closed T9275: Move Calendar to EditEngine, a subtask of T7944: Add Conduit support to Calendar, as Resolved.
Jul 13 2016, 3:03 PM · Conduit, Calendar
epriestley added a comment to T10633: Render timezones explicitly in email.

I've marked D16287 as fixing this, although it does not fix Countdown (today, only Calendar has the new behavior).

Jul 13 2016, 2:54 PM · Calendar, Mail, Countdown, Bug Report
epriestley added a revision to T10633: Render timezones explicitly in email: Unknown Object (Differential Revision).
Jul 13 2016, 2:52 PM · Calendar, Mail, Countdown, Bug Report
chad added a comment to T11212: One of our audits is displaying comments from another audit.

Sounds similar to T11092, which was recently resolved.

Jul 13 2016, 2:19 PM · Quicksand, Audit, Bug Report
20after4 added a comment to T10155: Error when displaying a repository with only one empty commit.

Needs a check for empty and at least a better error message in DiffusionBrowseQueryConduitAPIMethod.php:115

Jul 13 2016, 1:35 PM · Diffusion, Bug Report
20after4 added a comment to T10155: Error when displaying a repository with only one empty commit.

We are seeing this as well when attempting to browse an empty commit: https://phabricator.wikimedia.org/T140236

Jul 13 2016, 1:32 PM · Diffusion, Bug Report
benjumanji updated Q442: Possible to save a custom workboard filter with a name? from to Possible to save a custom workboard filter with a name?.
Jul 13 2016, 10:19 AM
anton.vladimirov added a comment to T11212: One of our audits is displaying comments from another audit.

I'm unable to reproduce on a test install right now, but then again, I stopped reproducing on my install after rebooting the server. It looks like something happens eventually to cause this to break and I start getting these broken comments.
Looks like every time I get a broken one it doesn't have a transaction PHID associated with it and all comments submitted together have the same wrong associated commitPHID.

Jul 13 2016, 6:54 AM · Quicksand, Audit, Bug Report
anton.vladimirov added a comment to T11212: One of our audits is displaying comments from another audit.

oh neat!

Jul 13 2016, 1:53 AM · Quicksand, Audit, Bug Report
chad added a comment to T11212: One of our audits is displaying comments from another audit.

You can use a free instance at http://phacility.com/ if you need a clean, up to date place to test privately.

Jul 13 2016, 1:51 AM · Quicksand, Audit, Bug Report
anton.vladimirov added a comment to T11212: One of our audits is displaying comments from another audit.

This is, by the way, on a brand new install that's not even a month old.
I tried to reproduce it on another install that is older and I'm not having any luck.

Jul 13 2016, 1:34 AM · Quicksand, Audit, Bug Report
anton.vladimirov added a comment to T11212: One of our audits is displaying comments from another audit.

This actually is a lot worse than I originally thought.
All inline comments that are made on an audit are actually applied to the audit I was previously commenting on (like an off by 1 error). I've isolated the following things:

  • This happens across repositories (i.e. if I have multiple repositories, commenting on one commit and then switching to another repository's commit and commenting on it will produce a comment on the first commit)
  • This happens for all users
  • This happens regardless of audit status - i.e. commits with audit requested exhibit this as much as commits that don't require audit.
  • Submitting an empty comment first thing before adding any content to a commit works around this problem - subsequently added commits appear as expected.
  • The broken state can be easily detected by unavailability of the "hover state" of the overall commit field - pressing "z" does nothing
Jul 13 2016, 1:28 AM · Quicksand, Audit, Bug Report

Jul 12 2016

epriestley added a comment to T11291: Error while executing task (phd daemon).

(Presuming that fixed things until we see evidence otherwise.)

Jul 12 2016, 11:29 PM · Daemons, Bug Report
epriestley closed T11291: Error while executing task (phd daemon) as Resolved by committing Restricted Diffusion Commit.
Jul 12 2016, 11:29 PM · Daemons, Bug Report
epriestley closed T11321: test subtask, a subtask of T2772: Phacility (Blockers), as Spite.
Jul 12 2016, 11:21 PM · Phacility
epriestley closed T11321: test subtask as Spite.
Jul 12 2016, 11:21 PM
epriestley added a revision to T9275: Move Calendar to EditEngine: Unknown Object (Differential Revision).
Jul 12 2016, 11:20 PM · ApplicationEditor, Policy, Calendar
epriestley added a revision to T10633: Render timezones explicitly in email: Unknown Object (Differential Revision).
Jul 12 2016, 11:20 PM · Calendar, Mail, Countdown, Bug Report
hach-que added a comment to T10203: Support Windows hosts in Drydock.

I should add that their plans for mid-2016 is to integrate all of this Windows OpenSSH support into the OpenSSH upstream repository, which is likely to be the time that Microsoft declares it production ready.

Jul 12 2016, 11:14 PM · Haskell.org, Harbormaster, Feature Request, Drydock