Page MenuHomePhabricator
Feed All Stories

Jul 15 2016

chad added a subtask for T3612: Lightbox v2: T11332: Present Pholio inline comments in a lightbox.
Jul 15 2016, 8:13 PM · Lightbox, Restricted Project, Files, Pholio
chad added a parent task for T11332: Present Pholio inline comments in a lightbox: T3612: Lightbox v2.
Jul 15 2016, 8:13 PM · Restricted Project, Pholio, Feature Request
chad renamed T11332: Present Pholio inline comments in a lightbox from Increase preview window in Pholio inline comments to Present Pholio inline comments in a lightbox.
Jul 15 2016, 8:12 PM · Restricted Project, Pholio, Feature Request
chad updated the task description for T10333: Add groups to workboard columns.
Jul 15 2016, 8:00 PM · Restricted Project, Restricted Project, Workboards (v3)
chad updated the task description for T10333: Add groups to workboard columns.
Jul 15 2016, 7:59 PM · Restricted Project, Restricted Project, Workboards (v3)
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Jul 15 2016, 7:26 PM · Design, Calendar
epriestley moved T11326: Improve Calendar v1 Design/UI/UX from Backlog to Unprototype (v1) on the Calendar board.
Jul 15 2016, 7:25 PM · Design, Calendar
epriestley closed T11333: Inconsistency in task tags as Invalid.

Since there doesn't appear to be a way to reproduce this at HEAD, we can't move forward.

Jul 15 2016, 7:20 PM · Bug Report
jasonfsmitty added a comment to T11335: Undesirable 'push' commits in feed.

You can configure the repository track only value to not track refs/meta, which is apparently where gitblit records it's reflog.

Jul 15 2016, 7:20 PM · Bug Report
epriestley added a comment to T11334: Add support for Ipsilon as an Auth Provider.

Ipsilon support would almost certainly take the form of an auth adapter. Phabricator auth adapters are not restricted to OAuth2: they include LDAP, username/password, OAuth1, and Persona (and T814 has examples that include HTTP Basic / Kerberos-via-HTTP Basic).

Jul 15 2016, 7:18 PM · Feature Request
tflink added a comment to T11334: Add support for Ipsilon as an Auth Provider.

Just to make sure that I was clear enough in my initial request - Ipsilon is not an OAuth2 provider in the same way Github or Asana is.

Jul 15 2016, 7:15 PM · Feature Request
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Unknown Object (Differential Revision).
Jul 15 2016, 7:10 PM · Design, Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Jul 15 2016, 7:05 PM · Design, Calendar
eadler added a comment to T10939: Support for OWNERS files.

General question: Why is the owners option "Add as reviewer (blocking)" if an owner uploads a revision? I know that this is expected, but why? For example at Wikimedia we currently have the system, that every change needs a review from an "owner" before the patch gets merged, so it's not useful, if an owner of the package uploads a change, and no reviewers get added. Maybe the a compromise may be a setting, where you can choose, if a package gets added as reviewer too, if the author of the revision is an owner too? I think that would help all.

Jul 15 2016, 6:59 PM · Prioritized, Restricted Project, Owners
jasonfsmitty added a comment to T11335: Undesirable 'push' commits in feed.

You can configure the repository track only value to not track refs/meta, which is apparently where gitblit records it's reflog.

Jul 15 2016, 6:57 PM · Bug Report
epriestley added a comment to T11334: Add support for Ipsilon as an Auth Provider.

Community Resources has some other working examples of auth extensions and Adding New Classes explains how to write them today. But there's no formal support until T5055 / T5447.

Jul 15 2016, 6:47 PM · Feature Request
epriestley added a project to T10448: Modularize mail tags: Prioritized.
Jul 15 2016, 6:39 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
rebeccahughes edited the content of Community Resources.
Jul 15 2016, 6:29 PM
avivey added a comment to T11335: Undesirable 'push' commits in feed.

Phabricator is looking at all refs, and gitblit is recording some information as refs, which interact strangely.

Jul 15 2016, 6:28 PM · Bug Report
avivey merged T11335: Undesirable 'push' commits in feed into T11314: Observe Mode + GitHub has weird mail interactions due to pull request refs.
Jul 15 2016, 6:26 PM · Diffusion (v3), Restricted Project, Mail, Haskell.org, Bug Report
avivey merged task T11335: Undesirable 'push' commits in feed into T11314: Observe Mode + GitHub has weird mail interactions due to pull request refs.
Jul 15 2016, 6:26 PM · Bug Report
jasonfsmitty added a comment to T11335: Undesirable 'push' commits in feed.

It's a little concerning that gitblit doesn't host it's own code, instead relying on github. Regardless, I haven't yet found a public gitblit repo that I can point to for reproduction.

Jul 15 2016, 6:03 PM · Bug Report
jasonfsmitty created T11335: Undesirable 'push' commits in feed.
Jul 15 2016, 6:00 PM · Bug Report
tflink added a comment to T11334: Add support for Ipsilon as an Auth Provider.

I can understand that, thank you for responding and explaining.

Jul 15 2016, 5:58 PM · Feature Request
epriestley closed T11334: Add support for Ipsilon as an Auth Provider as Wontfix.

We aren't interested in maintaining this since we haven't seen other interest in it, but feel free to add it to Community Resources.

Jul 15 2016, 5:34 PM · Feature Request
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Restricted Differential Revision.
Jul 15 2016, 5:30 PM · Design, Calendar
tflink renamed T11334: Add support for Ipsilon as an Auth Provider from Add Auth Support for Ipsilon instances to Add support for Ipsilon as an Auth Provider.
Jul 15 2016, 5:23 PM · Feature Request
tflink created T11334: Add support for Ipsilon as an Auth Provider.
Jul 15 2016, 5:22 PM · Feature Request
avivey placed T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess up for grabs.
Jul 15 2016, 4:22 PM · Documentation, Herald
jasonfsmitty added a comment to T11333: Inconsistency in task tags.

I have not been able to reproduce in phacility, and moving tasks around in our current install works correctly.

Jul 15 2016, 4:19 PM · Bug Report
epriestley added a comment to T11326: Improve Calendar v1 Design/UI/UX.

I spent pretty much the whole afternoon yesterday getting "All Day" events working properly without getting a result I was happy with (some of this was untangling date controls, which will probably come upstream eventually).

Jul 15 2016, 3:29 PM · Design, Calendar
jasonfsmitty added a comment to T11333: Inconsistency in task tags.
In T11333#186012, @chad wrote:

We require bug reports be reproducible by the reporter under our basic "free support" model. The basic idea is it's better if you spend 1-2 hours than us spending 1-2 days guessing the problem though back and forth questioning.

One thing you could do is test a current version of Phabricator with your steps on http://phacility.com with a free test instance.

Jul 15 2016, 3:18 PM · Bug Report
jasonfsmitty added a comment to T11333: Inconsistency in task tags.

FWIW, there are the transaction logs (via conduit) for a task that was experiencing the issue.

Jul 15 2016, 3:18 PM · Bug Report
chad added a comment to T11333: Inconsistency in task tags.

There may be some extra steps here, but I think this covers what we did. Unfortunately this spans several months, and I'm not in a position to setup another install and walk through this to test.

Jul 15 2016, 3:16 PM · Bug Report
jasonfsmitty added a comment to T11333: Inconsistency in task tags.
In T11333#186009, @chad wrote:

For example, 11.9.0 sounds like a Milestone, not a subproject. Is that correct?

Jul 15 2016, 2:59 PM · Bug Report
chad added a comment to T11333: Inconsistency in task tags.

For example, 11.9.0 sounds like a Milestone, not a subproject. Is that correct?

Jul 15 2016, 2:02 PM · Bug Report
chad added a comment to T11333: Inconsistency in task tags.

What are the minimum set of steps on a new, clean install we can follow to reproduce the error your seeing locally?

Jul 15 2016, 1:55 PM · Bug Report
saggid added a comment to T11332: Present Pholio inline comments in a lightbox.

Many thanks for this explanations :)

Jul 15 2016, 1:47 PM · Restricted Project, Pholio, Feature Request
d.maznekov closed Q443: How to create Panel with Closed task as resolved.
Jul 15 2016, 1:29 PM · Dashboards (v2)
d.maznekov added Q443: How to create Panel with Closed task (Answer 418).
Jul 15 2016, 1:28 PM
jasonfsmitty created T11333: Inconsistency in task tags.
Jul 15 2016, 12:47 PM · Bug Report
d.maznekov updated Q443: How to create Panel with Closed task from to How to create Panel with Closed task.
Jul 15 2016, 12:02 PM · Dashboards (v2)
20after4 updated the diff for D16304: Fall back to parent tasks / subtasks when the task graph is big.
  • Don't show commits twice in task details.
Jul 15 2016, 10:31 AM
chad added a comment to T11332: Present Pholio inline comments in a lightbox.

Actually probably just going to merge this into T3612. We want to eventually allow image commenting in the "lightbox" UI. With that clicking on "inline image" would bring up a full lightbox, not just a dialog.

Jul 15 2016, 4:02 AM · Restricted Project, Pholio, Feature Request
chad added a comment to T11332: Present Pholio inline comments in a lightbox.

If this is a feature request, we require a root problem. See Describing Root Problems for how to find the core problem. I understand you want it bigger, but I have no idea why or how you use Pholio. I have concerns arbitrarily enlarging it does not solve your core problem and that any random number chosen will again be bumped into by another install. Functionally, we don't intend Pholio to be used as your using it, that is, if you're highlighting large areas, these aren't details, they're features. Features should be discussed just as a normal comment.

Jul 15 2016, 3:50 AM · Restricted Project, Pholio, Feature Request
saggid added a comment to T11332: Present Pholio inline comments in a lightbox.

Peoples now have a big monitors, and i think what increase height from 200 to 400px help all to get greater usability with Pholio module.

Jul 15 2016, 3:35 AM · Restricted Project, Pholio, Feature Request
• huanzhancheng added a watcher for Differential: • huanzhancheng.
Jul 15 2016, 3:30 AM
saggid edited projects for T11332: Present Pholio inline comments in a lightbox, added: Feature Request; removed Bug Report.
Jul 15 2016, 3:22 AM · Restricted Project, Pholio, Feature Request
chad added a comment to T11332: Present Pholio inline comments in a lightbox.

Did you mean to file this as a feature request?

Jul 15 2016, 3:15 AM · Restricted Project, Pholio, Feature Request
saggid updated the task description for T11332: Present Pholio inline comments in a lightbox.
Jul 15 2016, 2:55 AM · Restricted Project, Pholio, Feature Request
saggid created T11332: Present Pholio inline comments in a lightbox.
Jul 15 2016, 2:48 AM · Restricted Project, Pholio, Feature Request
20after4 updated subscribers of D16304: Fall back to parent tasks / subtasks when the task graph is big.

I misplaced the end of the if (!$task_graph->isEmpty()) block

Jul 15 2016, 12:58 AM
20after4 updated the diff for D16304: Fall back to parent tasks / subtasks when the task graph is big.

I misplaced the end of the if (!$task_graph->isEmpty()) block

Jul 15 2016, 12:57 AM
20after4 added inline comments to D16304: Fall back to parent tasks / subtasks when the task graph is big.
Jul 15 2016, 12:50 AM
20after4 retitled D16304: Fall back to parent tasks / subtasks when the task graph is big from to Fall back to parent tasks / subtasks when the task graph is big.
Jul 15 2016, 12:45 AM

Jul 14 2016

avivey edited the content of Community Resources.
Jul 14 2016, 11:55 PM
avivey added a comment to P2001 AddSubscribersFromJIRAIssuesHeraldCustomAction.php.
Jul 14 2016, 11:52 PM · Herald
avivey changed the visibility for P2001 AddSubscribersFromJIRAIssuesHeraldCustomAction.php.
Jul 14 2016, 11:51 PM · Herald
avivey created P2001 AddSubscribersFromJIRAIssuesHeraldCustomAction.php.
Jul 14 2016, 11:51 PM · Herald
hach-que changed the image for Image Macro "topquoll".
Jul 14 2016, 11:24 PM
anton.vladimirov added a comment to T11331: Explicitly specifying allowed protocols breaks viewing raw files.

But I still kind of think that if you generated a link to your own content you should be able to navigate to it, so it seems reasonable that either:

  • remote URI that start with pre-configured base URI are considered valid
  • "View Raw File" generates a local URI relative to base URI to avoid this check
Jul 14 2016, 11:00 PM · Bug Report
anton.vladimirov added a comment to T11331: Explicitly specifying allowed protocols breaks viewing raw files.

I guess I can phrase that differently, then.
Consider that this services as an exception and the associated error message is extremely confusing:

  • It specifies a URI that is valid and is not external to my server and calls it both remote and invalid, which is odd
  • The URI that is surfaced is a long and very internal-looking one, clearly generated by Phabricator itself
  • There is no explanation given as to why this is considered invalid.
Jul 14 2016, 10:57 PM · Bug Report
epriestley closed T11331: Explicitly specifying allowed protocols breaks viewing raw files as Invalid.

This isn't a bug. List HTTP and HTTPS if you want to use these protocols.

Jul 14 2016, 10:41 PM · Bug Report
anton.vladimirov created T11331: Explicitly specifying allowed protocols breaks viewing raw files.
Jul 14 2016, 10:36 PM · Bug Report
yelirekim added a comment to T11330: Allow Herald to "Queue Call to Webhook: ...".

Ok cool.

Jul 14 2016, 9:41 PM · Feature Request
epriestley added a comment to T11330: Allow Herald to "Queue Call to Webhook: ...".

Ohhh, sorry, I missed that this is a service call thing rather than a redirect/workflow thing.

Jul 14 2016, 9:32 PM · Feature Request
yelirekim added a comment to T11330: Allow Herald to "Queue Call to Webhook: ...".

I was thinking custom field that just pings a callback url was what I was thinking.

Jul 14 2016, 9:28 PM · Feature Request
epriestley added a comment to T11330: Allow Herald to "Queue Call to Webhook: ...".

You could write a CustomField that was hidden and had some static prefilled value for each form, but I think you might have some amount of trouble getting the UX to work well after the task was created (e.g., you can put some "link back to the thing you came from" in the properties, but not easily render a banner at the top of the page with an obvious "continue" button, nor easily detect that the user just created the object and seamlessly redirect).

Jul 14 2016, 9:23 PM · Feature Request
dariusz added a comment to T5523: Make bulk moves easier on Workboards.

hey all,

Jul 14 2016, 9:11 PM · Restricted Project, Workboards
yelirekim added a comment to T11330: Allow Herald to "Queue Call to Webhook: ...".

I guess this is customfieldable already, isn't it? There will be weirdness with checking state in the field / the interface doesn't explicitly support it, but I'm pretty sure it's doable.

Jul 14 2016, 8:48 PM · Feature Request
epriestley added a comment to T11330: Allow Herald to "Queue Call to Webhook: ...".

Some general sorts of thoughts:

Jul 14 2016, 8:30 PM · Feature Request
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Unknown Object (Differential Revision).
Jul 14 2016, 8:06 PM · Design, Calendar
chad added a comment to T11326: Improve Calendar v1 Design/UI/UX.

I'll have my laptop with me next week, should be easy for me to clean up CSS stuff on the road.

Jul 14 2016, 8:05 PM · Design, Calendar
chad added a comment to T11326: Improve Calendar v1 Design/UI/UX.

Visually, I have a hard time picking out the current day/week.

Jul 14 2016, 8:04 PM · Design, Calendar
chad added a comment to T11326: Improve Calendar v1 Design/UI/UX.

Use of link color to convey state is weird?

Jul 14 2016, 8:04 PM · Design, Calendar
chad added a comment to T11326: Improve Calendar v1 Design/UI/UX.

I'll CSS in the event details later, but wanted this to go full width if possible.

Jul 14 2016, 7:36 PM · Design, Calendar
chad added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

See T4788#184477 for current plans.

Jul 14 2016, 6:59 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
quiddity added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

[...] Still, I think it would be pretty simple to just shut off the task graph (but not the list?) in those situations [...]

Jul 14 2016, 6:56 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
CodeMouse92 added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

I definitely agree that in most cases, 100+ subtasks (especially direct subtasks) is better as a project. Still, I think it would be pretty simple to just shut off the task graph (but not the list?) in those situations if there is an exception that hasn't been thought of.

Jul 14 2016, 6:36 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
20after4 added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

It might be useful if the dependency resolution was only two-levels deep. That wouldn't really solve the problem for extremely wide trees though.

Jul 14 2016, 6:25 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
Danny_B added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).
In T4788#185851, @chad wrote:

If you have more than 100 subtasks, the task should probably be a project so it can be properly organized.

Jul 14 2016, 6:08 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
yelirekim updated the task description for T11330: Allow Herald to "Queue Call to Webhook: ...".
Jul 14 2016, 5:39 PM · Feature Request
yelirekim created T11330: Allow Herald to "Queue Call to Webhook: ...".
Jul 14 2016, 5:38 PM · Feature Request
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Unknown Object (Differential Revision).
Jul 14 2016, 5:23 PM · Design, Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Unknown Object (Differential Revision).
Jul 14 2016, 5:09 PM · Design, Calendar
epriestley added a comment to T11326: Improve Calendar v1 Design/UI/UX.

My test data is pretty sketchy:

Jul 14 2016, 5:05 PM · Design, Calendar
chad added a comment to T11326: Improve Calendar v1 Design/UI/UX.

got a full screenshot?

Jul 14 2016, 5:04 PM · Design, Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Unknown Object (Differential Revision).
Jul 14 2016, 4:59 PM · Design, Calendar
epriestley added a comment to T11096: Redesign main header / quick create / search.

Ah, fair enough. Two options it is, then.

Jul 14 2016, 4:50 PM · Design
chad added a comment to T11096: Redesign main header / quick create / search.

I would want to on admin.phacility.com

Jul 14 2016, 4:50 PM · Design
epriestley added a comment to T11326: Improve Calendar v1 Design/UI/UX.

I poked at it a little bit but only got this far:

Jul 14 2016, 4:45 PM · Design, Calendar
epriestley added a comment to T11096: Redesign main header / quick create / search.

We can just replace ui.custom-header with two separate options I guess and put deprecation guidance in the old option.

Jul 14 2016, 4:44 PM · Design
chad added a comment to T11326: Improve Calendar v1 Design/UI/UX.

I'll get you an update month view here this afternoon, I've been mulling it over.

Jul 14 2016, 4:27 PM · Design, Calendar
chad added a comment to T11096: Redesign main header / quick create / search.

@epriestley I think my rough plan here is:

Jul 14 2016, 4:24 PM · Design
chad added a project to T11326: Improve Calendar v1 Design/UI/UX: Design.
Jul 14 2016, 4:21 PM · Design, Calendar
epriestley added a comment to T11329: Provide a policy controlled way to reset factors from the web UI.

(And no matter what the policy is, this allows attackers to compromise a support account and then strip MFA from a "better" account, upgrading access.)

Jul 14 2016, 3:56 PM · Restricted Project, Feature Request
epriestley added a comment to T11329: Provide a policy controlled way to reset factors from the web UI.

In the general case, as with the upstream cluster (T7639) I think the quorum thing in T9515 that @eadler mentions is the most promising way forward to reduce MFA support costs. Briefly, it would work like this:

Jul 14 2016, 3:47 PM · Restricted Project, Feature Request
eadler added a comment to T11329: Provide a policy controlled way to reset factors from the web UI.

See also T6549 and T9515

Jul 14 2016, 3:29 PM · Restricted Project, Feature Request
yelirekim created T11329: Provide a policy controlled way to reset factors from the web UI.
Jul 14 2016, 3:20 PM · Restricted Project, Feature Request
epriestley added a comment to T11326: Improve Calendar v1 Design/UI/UX.

Month view in desktop mode should be flush with box?

Jul 14 2016, 3:07 PM · Design, Calendar